From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from adelie.canonical.com ([91.189.90.139]:45830 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752508Ab0LZTiI (ORCPT ); Sun, 26 Dec 2010 14:38:08 -0500 Message-ID: <4D17999E.4000500@canonical.com> Date: Sun, 26 Dec 2010 20:38:06 +0100 From: David Henningsson MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Subject: Re: [PATCH] DVB: TechnoTrend CT-3650 IR support References: <4D170785.1070306@canonical.com> <4D1729DB.80406@infradead.org> In-Reply-To: <4D1729DB.80406@infradead.org> Content-Type: multipart/mixed; boundary="------------000404000808080505080908" List-ID: Sender: Mauro Carvalho Chehab This is a multi-part message in MIME format. --------------000404000808080505080908 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2010-12-26 12:41, Mauro Carvalho Chehab wrote: > Hi David, > > Em 26-12-2010 07:14, David Henningsson escreveu: >> Hi Linux-media, >> >> As a spare time project I bought myself a TT CT-3650, to see if I could get it working. Waling Dijkstra did write a IR& CI patch for this model half a year ago, so I was hopeful. (Reference: http://www.mail-archive.com/linux-media@vger.kernel.org/msg19860.html ) >> >> Having tested the patch, the IR is working (tested all keys via the "evtest" tool), however descrambling is NOT working. >> >> Waling's patch was reviewed but never merged. So I have taken the IR part of the patch, cleaned it up a little, and hopefully this part is ready for merging now. Patch is against linux-2.6.git. > > Could you please rebase it to work with the rc_core support? I suspect that you > based it on a kernel older than .36, as the dvb_usb rc struct changed. Ok, I have now done this, but I'm not completely satisfied, perhaps you can help out a little? I'm new to IR/RC stuff, but I feel I'm missing correct "repeat" functionality, i e, if you keep a key pressed it appears as separate key presses with whatever interval set as .rc_interval. (This was probably a problem with the old patch as well.) Is there any support for this is rc_core? I'm attaching a temporary patch (just for review) so you know what I'm talking about. > The better is to base it over the latest V4L/DVB/RC development git, available at: > http://git.linuxtv.org/media_tree.git Ok. I was probably confused with this entry: http://linuxtv.org/news.php?entry=2010-01-19.mchehab telling me to base it on v4l-dvb.git, which is not updated for four months. However, http://git.linuxtv.org/ correctly lists the media_tree.git as the repository of choice. Thanks for the review! -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic --------------000404000808080505080908 Content-Type: text/x-patch; name="0001-DVB-IR-CT-3650.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-DVB-IR-CT-3650.patch" >>From 8c42121a08c5dabbd1a943cc1e5726ed99f0d957 Mon Sep 17 00:00:00 2001 From: David Henningsson Date: Sun, 26 Dec 2010 14:23:58 +0100 Subject: [PATCH] DVB: IR support for CT-3650 Signed-off-by: David Henningsson --- drivers/media/dvb/dvb-usb/ttusb2.c | 28 ++++++++++++++++++++++++++++ 1 files changed, 28 insertions(+), 0 deletions(-) mode change 100644 => 100755 debian/rules diff --git a/debian/rules b/debian/rules old mode 100644 new mode 100755 diff --git a/drivers/media/dvb/dvb-usb/ttusb2.c b/drivers/media/dvb/dvb-usb/ttusb2.c index a6de489..ded8a4b 100644 --- a/drivers/media/dvb/dvb-usb/ttusb2.c +++ b/drivers/media/dvb/dvb-usb/ttusb2.c @@ -128,6 +128,27 @@ static struct i2c_algorithm ttusb2_i2c_algo = { .functionality = ttusb2_i2c_func, }; +/* command to poll IR receiver (copied from pctv452e.c) */ +#define CMD_GET_IR_CODE 0x1b + +/* IR */ +static int tt3650_rc_query(struct dvb_usb_device *d) +{ + int ret; + u8 rx[9]; /* A CMD_GET_IR_CODE reply is 9 bytes long */ + ret = ttusb2_msg(d, CMD_GET_IR_CODE, NULL, 0, rx, sizeof(rx)); + if (ret != 0) + return ret; + + if (rx[8] & 0x01) { + /* got a "press" event */ + deb_info("%s: cmd=0x%02x sys=0x%02x\n", __func__, rx[2], rx[3]); + rc_keydown(d->rc_dev, rx[2], 0); + } + return 0; +} + + /* Callbacks for DVB USB */ static int ttusb2_identify_state (struct usb_device *udev, struct dvb_usb_device_properties *props, struct dvb_usb_device_description **desc, @@ -345,6 +366,13 @@ static struct dvb_usb_device_properties ttusb2_properties_ct3650 = { .size_of_priv = sizeof(struct ttusb2_state), + .rc.core = { + .rc_interval = 250, + .rc_codes = RC_MAP_TT_1500, + .rc_query = tt3650_rc_query, + .allowed_protos = RC_TYPE_UNKNOWN, + }, + .num_adapters = 1, .adapter = { { -- 1.7.1 --------------000404000808080505080908--