From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Andy Walls <awalls@md.metrocast.net>
Cc: linux-media@vger.kernel.org, Jean Delvare <khali@linux-fr.org>,
Jarod Wilson <jarod@redhat.com>, Janne Grunau <j@jannau.net>
Subject: Re: [PATCH 2/3] ir-kbd-i2c: Add HD PVR IR Rx support to ir-kbd-i2c
Date: Wed, 29 Dec 2010 09:12:33 -0200 [thread overview]
Message-ID: <4D1B17A1.1010803@redhat.com> (raw)
In-Reply-To: <1293587266.3098.14.camel@localhost>
Em 28-12-2010 23:47, Andy Walls escreveu:
>
> Add HD PVR IR Rx support to ir-kbd-i2c
Hmm... I know nothing about the hardware designs used on hd-pvr, but
it seems wrong to have both lirc-zilog and ir-kbd-i2c registering for
RX for the same device.
There are variants with hd-pvr that uses ir-kbd-i2c and others
that use another I2C chipset? Or, for some versions of Z8, the RX logic
is identical to the one provided by ir-kbd-i2c?
>
> Signed-off-by: Andy Walls <awalls@md.metrocast.net>
>
> ---
> drivers/media/video/ir-kbd-i2c.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/ir-kbd-i2c.c b/drivers/media/video/ir-kbd-i2c.c
> index dd54c3d..c87b6bc 100644
> --- a/drivers/media/video/ir-kbd-i2c.c
> +++ b/drivers/media/video/ir-kbd-i2c.c
> @@ -449,6 +449,7 @@ static const struct i2c_device_id ir_kbd_id[] = {
> { "ir_video", 0 },
> /* IR device specific entries should be added here */
> { "ir_rx_z8f0811_haup", 0 },
> + { "ir_rx_z8f0811_hdpvr", 0 },
> { }
> };
>
next prev parent reply other threads:[~2010-12-29 11:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1293587067.3098.10.camel@localhost>
2010-12-29 1:46 ` [PATCH 1/3] hdpvr: Add I2C and ir-kdb-i2c registration of the Zilog Z8 IR chip Andy Walls
2010-12-29 11:08 ` Mauro Carvalho Chehab
2010-12-29 13:40 ` Andy Walls
2011-01-05 12:50 ` Jean Delvare
2011-01-05 22:44 ` Andy Walls
2010-12-29 1:47 ` [PATCH 2/3] ir-kbd-i2c: Add HD PVR IR Rx support to ir-kbd-i2c Andy Walls
2010-12-29 11:12 ` Mauro Carvalho Chehab [this message]
2010-12-29 14:14 ` Andy Walls
2011-01-05 12:53 ` Jean Delvare
2010-12-29 1:49 ` [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field Andy Walls
2011-01-05 14:45 ` Jean Delvare
2011-01-05 17:34 ` Mauro Carvalho Chehab
2011-01-05 21:51 ` Jean Delvare
2011-01-05 22:02 ` Mauro Carvalho Chehab
2011-01-06 1:20 ` Andy Walls
2011-01-13 9:46 ` Jean Delvare
2011-01-13 13:31 ` Jean Delvare
2011-01-06 0:46 ` Andy Walls
2011-01-13 13:21 ` Jean Delvare
2011-01-13 14:12 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1B17A1.1010803@redhat.com \
--to=mchehab@redhat.com \
--cc=awalls@md.metrocast.net \
--cc=j@jannau.net \
--cc=jarod@redhat.com \
--cc=khali@linux-fr.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).