Re: nasty bug at qv4l2

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 31-12-2010 13:08, Hans Verkuil escreveu:
> On Friday, December 31, 2010 16:02:10 Hans de Goede wrote:
>> Hi,
>>
>> Hans V. I've tested your patch for avoiding the double
>> conversion problem, and I can report it fixes the issue seen with
>> webcameras which need 90 degrees rotation.
>>
>> While testing I found a bug in gspca, which gets triggered by
>> qv4l2 which makes it impossible to switch between userptr and
>> mmap mode. While fixing that I also found some locking issues in
>> gspca. As these all touch the gscpa core I'll send a patch set
>> to Jean Francois Moine for this.
>>
>> With the issues in gspca fixed, I found a bug in qv4l2 when using
>> read mode in raw mode (not passing the correct src_size to
>> libv4lconvert_convert).
>>
>> I've attached 2 patches to qv4l2, fixing the read issue and a similar
>> issue in mmap / userptr mode. These apply on top of your patch.
> 
> Thanks for testing this! I've committed mine and your patches for qv4l2.

Ok, I did some tests here too. The applied patches fix the bugs I've
reported: the pac7302 driver formats are properly reported (the emulated ones),
and it is now possible to change resolution/format with the uvc driver.

Cheers,
Mauro