From: Hans de Goede <hdegoede@redhat.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Philips SPC315NC is vertically flipped
Date: Mon, 03 Jan 2011 14:03:36 +0100 [thread overview]
Message-ID: <4D21C928.2000306@redhat.com> (raw)
In-Reply-To: <4D21AA15.6080703@redhat.com>
Hi,
On 01/03/2011 11:51 AM, Mauro Carvalho Chehab wrote:
> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>
> diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
> index f32ef7b..a182efe 100644
> --- a/lib/libv4lconvert/control/libv4lcontrol.c
> +++ b/lib/libv4lconvert/control/libv4lcontrol.c
> @@ -46,6 +46,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
> { 0x0471, 0x0326, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
> /* Philips SPC210NC */
> { 0x0471, 0x032d, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
> + /* Philips SPC315NC */
> + { 0x0471, 0x032e, 0, NULL, NULL, V4LCONTROL_VFLIPPED },
> /* Genius E-M 112 (also want whitebalance by default) */
> { 0x093a, 0x2476, 0, NULL, NULL,
> V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },
Are you sure it is only vertically flipped ? I've have the Philips SPC 200NC (0471:0325)
myself and it simply has the sensor upside down (so both h and v flipped).
Did you happen to use skype to test this? Skype is known to decide to mirror the image
before showing it in some cases (I don't know when / why skype does this).
Regards,
Hans
next prev parent reply other threads:[~2011-01-03 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 10:51 [PATCH] Philips SPC315NC is vertically flipped Mauro Carvalho Chehab
2011-01-03 13:03 ` Hans de Goede [this message]
2011-01-03 13:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D21C928.2000306@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox