* [PATCH] Philips SPC315NC is vertically flipped
@ 2011-01-03 10:51 Mauro Carvalho Chehab
2011-01-03 13:03 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2011-01-03 10:51 UTC (permalink / raw)
To: Hans de Goede; +Cc: Linux Media Mailing List
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
index f32ef7b..a182efe 100644
--- a/lib/libv4lconvert/control/libv4lcontrol.c
+++ b/lib/libv4lconvert/control/libv4lcontrol.c
@@ -46,6 +46,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
{ 0x0471, 0x0326, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
/* Philips SPC210NC */
{ 0x0471, 0x032d, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
+ /* Philips SPC315NC */
+ { 0x0471, 0x032e, 0, NULL, NULL, V4LCONTROL_VFLIPPED },
/* Genius E-M 112 (also want whitebalance by default) */
{ 0x093a, 0x2476, 0, NULL, NULL,
V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Philips SPC315NC is vertically flipped
2011-01-03 10:51 [PATCH] Philips SPC315NC is vertically flipped Mauro Carvalho Chehab
@ 2011-01-03 13:03 ` Hans de Goede
2011-01-03 13:16 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2011-01-03 13:03 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux Media Mailing List
Hi,
On 01/03/2011 11:51 AM, Mauro Carvalho Chehab wrote:
> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>
> diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
> index f32ef7b..a182efe 100644
> --- a/lib/libv4lconvert/control/libv4lcontrol.c
> +++ b/lib/libv4lconvert/control/libv4lcontrol.c
> @@ -46,6 +46,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
> { 0x0471, 0x0326, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
> /* Philips SPC210NC */
> { 0x0471, 0x032d, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
> + /* Philips SPC315NC */
> + { 0x0471, 0x032e, 0, NULL, NULL, V4LCONTROL_VFLIPPED },
> /* Genius E-M 112 (also want whitebalance by default) */
> { 0x093a, 0x2476, 0, NULL, NULL,
> V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },
Are you sure it is only vertically flipped ? I've have the Philips SPC 200NC (0471:0325)
myself and it simply has the sensor upside down (so both h and v flipped).
Did you happen to use skype to test this? Skype is known to decide to mirror the image
before showing it in some cases (I don't know when / why skype does this).
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Philips SPC315NC is vertically flipped
2011-01-03 13:03 ` Hans de Goede
@ 2011-01-03 13:16 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2011-01-03 13:16 UTC (permalink / raw)
To: Hans de Goede; +Cc: Linux Media Mailing List
Em 03-01-2011 11:03, Hans de Goede escreveu:
> Hi,
>
> On 01/03/2011 11:51 AM, Mauro Carvalho Chehab wrote:
>> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>>
>> diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
>> index f32ef7b..a182efe 100644
>> --- a/lib/libv4lconvert/control/libv4lcontrol.c
>> +++ b/lib/libv4lconvert/control/libv4lcontrol.c
>> @@ -46,6 +46,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
>> { 0x0471, 0x0326, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
>> /* Philips SPC210NC */
>> { 0x0471, 0x032d, 0, NULL, NULL, V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
>> + /* Philips SPC315NC */
>> + { 0x0471, 0x032e, 0, NULL, NULL, V4LCONTROL_VFLIPPED },
>> /* Genius E-M 112 (also want whitebalance by default) */
>> { 0x093a, 0x2476, 0, NULL, NULL,
>> V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },
>
> Are you sure it is only vertically flipped ? I've have the Philips SPC 200NC (0471:0325)
> myself and it simply has the sensor upside down (so both h and v flipped).
Yes, I'm sure about that. Only vertical is flipped on this webcam.
> Did you happen to use skype to test this? Skype is known to decide to mirror the image
> before showing it in some cases (I don't know when / why skype does this).
My previous test were with qv4l2. With skype, plus the above patch, the webcam is also
working properly.
>
> Regards,
>
> Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-03 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-03 10:51 [PATCH] Philips SPC315NC is vertically flipped Mauro Carvalho Chehab
2011-01-03 13:03 ` Hans de Goede
2011-01-03 13:16 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox