From: Andreas Oberritter <obi@linuxtv.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] av7110: make array offset unsigned
Date: Fri, 07 Jan 2011 13:44:15 +0100 [thread overview]
Message-ID: <4D270A9F.7080104@linuxtv.org> (raw)
In-Reply-To: <20110106194059.GC1717@bicker>
On 01/06/2011 08:41 PM, Dan Carpenter wrote:
> In the CA_GET_SLOT_INFO ioctl, we only check whether "num" is too large,
> but we don't check if it's negative.
>
> drivers/media/dvb/ttpci/av7110_ca.c
> 278 ca_slot_info_t *info=(ca_slot_info_t *)parg;
> 279
> 280 if (info->num > 1)
> 281 return -EINVAL;
> 282 av7110->ci_slot[info->num].num = info->num;
>
> Let's just make it unsigned.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Nack. You're changing an interface to userspace. Please add a check to
av7110_ca.c instead.
Regards,
Andreas
next prev parent reply other threads:[~2011-01-07 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 19:41 [patch] [media] av7110: make array offset unsigned Dan Carpenter
2011-01-07 12:44 ` Andreas Oberritter [this message]
2011-01-07 13:46 ` [patch v2] [media] av7110: check for negative array offset Dan Carpenter
2011-01-07 19:01 ` Oliver Endriss
2011-01-07 19:41 ` [patch v3] " Dan Carpenter
2011-01-07 13:51 ` [patch] [media] av7110: make array offset unsigned Dan Carpenter
2011-01-07 14:02 ` Vasiliy Kulikov
2011-01-07 14:05 ` Andreas Oberritter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D270A9F.7080104@linuxtv.org \
--to=obi@linuxtv.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox