public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates
Date: Tue, 11 Jan 2011 20:08:10 -0200	[thread overview]
Message-ID: <4D2CD4CA.7090507@redhat.com> (raw)
In-Reply-To: <4D21FDC1.7000803@samsung.com>

Em 03-01-2011 14:48, Sylwester Nawrocki escreveu:
> Hi Mauro,
> 
> Please pull from our tree for the following items:

> 6. Patches for SAA7134 driver for Videbuf2 testing.

There's something wrong with those patches. I got lots of errors: 

  CC [M]  /home/v4l/new_build/v4l/saa7134-tvaudio.o
/home/v4l/new_build/v4l/saa7134-core.c: In function 'saa7134_dma_free':
/home/v4l/new_build/v4l/saa7134-core.c:262: warning: unused variable 'dma'
/home/v4l/new_build/v4l/saa7134-core.c: In function 'saa7134_finidev':
/home/v4l/new_build/v4l/saa7134-core.c:1006: warning: unused variable 'mops'
/home/v4l/new_build/v4l/saa7134-core.c: In function 'saa7134_buffer_requeue':
/home/v4l/new_build/v4l/saa7134-core.c:1085: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-core.c:1085: warning: type defaults to 'int' in declaration of '__mptr'
/home/v4l/new_build/v4l/saa7134-core.c:1085: warning: initialization from incompatible pointer type
/home/v4l/new_build/v4l/saa7134-core.c:1085: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c: In function 'buffer_activate':
/home/v4l/new_build/v4l/saa7134-ts.c:49: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:54: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c: In function 'buffer_prepare':
/home/v4l/new_build/v4l/saa7134-ts.c:79: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:79: warning: type defaults to 'int' in declaration of '__mptr'
/home/v4l/new_build/v4l/saa7134-ts.c:79: warning: initialization from incompatible pointer type
/home/v4l/new_build/v4l/saa7134-ts.c:79: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:89: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:89: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:92: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:93: warning: passing argument 1 of 'saa7134_dma_free' from incompatible pointer type
/home/v4l/new_build/v4l/saa7134.h:728: note: expected 'struct vb2_queue *' but argument is of type 'struct videobuf_queue *'
/home/v4l/new_build/v4l/saa7134-ts.c:96: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:98: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:102: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:103: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:104: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:107: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:118: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:120: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:124: warning: passing argument 1 of 'saa7134_dma_free' from incompatible pointer type
/home/v4l/new_build/v4l/saa7134.h:728: note: expected 'struct vb2_queue *' but argument is of type 'struct videobuf_queue *'
/home/v4l/new_build/v4l/saa7134-ts.c: In function 'buffer_queue':
/home/v4l/new_build/v4l/saa7134-ts.c:144: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:144: warning: type defaults to 'int' in declaration of '__mptr'
/home/v4l/new_build/v4l/saa7134-ts.c:144: warning: initialization from incompatible pointer type
/home/v4l/new_build/v4l/saa7134-ts.c:144: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c: In function 'buffer_release':
/home/v4l/new_build/v4l/saa7134-ts.c:151: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:151: warning: type defaults to 'int' in declaration of '__mptr'
/home/v4l/new_build/v4l/saa7134-ts.c:151: warning: initialization from incompatible pointer type
/home/v4l/new_build/v4l/saa7134-ts.c:151: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-ts.c:157: warning: passing argument 1 of 'saa7134_dma_free' from incompatible pointer type
/home/v4l/new_build/v4l/saa7134.h:728: note: expected 'struct vb2_queue *' but argument is of type 'struct videobuf_queue *'
/home/v4l/new_build/v4l/saa7134-ts.c: In function 'saa7134_irq_ts_done':
/home/v4l/new_build/v4l/saa7134-ts.c:306: error: 'struct saa7134_buf' has no member named 'vb'
/home/v4l/new_build/v4l/saa7134-tvaudio.c: In function 'mute_input_7134':
/home/v4l/new_build/v4l/saa7134-tvaudio.c:197: error: 'struct saa7134_board' has no member named 'radio'
/home/v4l/new_build/v4l/saa7134-tvaudio.c: In function 'tvaudio_thread_ddep':
/home/v4l/new_build/v4l/saa7134-tvaudio.c:791: error: 'struct saa7134_board' has no member named 'radio'

Ok, those are the last ones from the patch series.

Please answer/fix the issues I've pointed, in order to allow me to finish vb2 tests
and move those stuff forward.

Thanks!
Mauro

      parent reply	other threads:[~2011-01-11 20:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 16:48 [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates Sylwester Nawrocki
2011-01-11 18:23 ` Mauro Carvalho Chehab
2011-01-11 16:42   ` Pawel Osciak
2011-01-11 19:06     ` Mauro Carvalho Chehab
2011-01-11 20:19 ` Mauro Carvalho Chehab
2011-01-12 10:25   ` Marek Szyprowski
2011-01-12 18:49     ` Mauro Carvalho Chehab
2011-01-13  3:05       ` Pawel Osciak
2011-01-13 12:18         ` Mauro Carvalho Chehab
2011-01-12 20:23     ` Mauro Carvalho Chehab
2011-01-13  8:46       ` Andrzej Pietrasiewicz
2011-01-13 12:13         ` Andrzej Pietrasiewicz
2011-01-13 13:04           ` Mauro Carvalho Chehab
2011-01-13 12:58         ` Mauro Carvalho Chehab
2011-01-16 15:11           ` Mauro Carvalho Chehab
2011-01-11 21:31 ` Mauro Carvalho Chehab
2011-01-11 21:57 ` Mauro Carvalho Chehab
2011-01-12  2:47   ` Pawel Osciak
2011-01-12 16:19   ` Sylwester Nawrocki
2011-01-11 22:08 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2CD4CA.7090507@redhat.com \
    --to=mchehab@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox