link error w/ media-0006-sensors

link error w/ media-0006-sensors

[Michael Jones]

Hi Laurent & Sakari,

On Laurent's media-0006-sensors branch, when compiling with
CONFIG_VIDEO_OMAP3=m, I got the following linking error:

ERROR: "omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko]
undefined!

I can get rid of the error with the patch below. But as always, I
wonder: Why didn't anybody else come across this error? Are you all
compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see
where someone is using that?

And would anything be wrong with the patch below?

-Michael

diff --git a/arch/arm/plat-omap/omap-pm-noop.c b/arch/arm/plat-omap/omap-pm-noop.c
index e129ce8..9e0bcb6 100644
--- a/arch/arm/plat-omap/omap-pm-noop.c
+++ b/arch/arm/plat-omap/omap-pm-noop.c
@@ -88,6 +88,7 @@ int omap_pm_set_min_bus_tput(struct device *dev, u8 agent_id, unsigned long r)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(omap_pm_set_min_bus_tput);
 
 int omap_pm_set_max_dev_wakeup_lat(struct device *req_dev, struct device *dev,
 				   long t)





MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

Re: link error w/ media-0006-sensors

[Laurent Pinchart]

Hi Michael,

On Tuesday 18 January 2011 17:14:37 Michael Jones wrote:
> Hi Laurent & Sakari,
> 
> On Laurent's media-0006-sensors branch, when compiling with
> CONFIG_VIDEO_OMAP3=m, I got the following linking error:
> 
> ERROR: "omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko]
> undefined!
> 
> I can get rid of the error with the patch below. But as always, I
> wonder: Why didn't anybody else come across this error? Are you all
> compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see
> where someone is using that?
> 
> And would anything be wrong with the patch below?

Martin Hostettler sent the same patch to linux-omap today ("[PATCH] OMAP: PM: 
Export omap_pm_set_min_bus_tput to modules"). See Please see Paul Wamsley's 
answer on the list.

-- 
Regards,

Laurent Pinchart

Re: link error w/ media-0006-sensors

[Michael Jones]

Hi Laurent,

sorry to resurrect this from a month ago...

I've continued to export omap_pm_set_min_bus_tput() to enable building
the omap3-isp module, although Paul Wamsley's reply you referred to
clearly indicates that this is the wrong approach.

Aren't you also building omap3-isp as a module?  How are you guys
getting around this?

-Michael

On 01/19/2011 12:30 AM, Laurent Pinchart wrote:
> Hi Michael,
> 
> On Tuesday 18 January 2011 17:14:37 Michael Jones wrote:
>> Hi Laurent & Sakari,
>>
>> On Laurent's media-0006-sensors branch, when compiling with
>> CONFIG_VIDEO_OMAP3=m, I got the following linking error:
>>
>> ERROR: "omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko]
>> undefined!
>>
>> I can get rid of the error with the patch below. But as always, I
>> wonder: Why didn't anybody else come across this error? Are you all
>> compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see
>> where someone is using that?
>>
>> And would anything be wrong with the patch below?
> 
> Martin Hostettler sent the same patch to linux-omap today ("[PATCH] OMAP: PM: 
> Export omap_pm_set_min_bus_tput to modules"). See Please see Paul Wamsley's 
> answer on the list.
> 


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

Re: link error w/ media-0006-sensors

[Laurent Pinchart]

Hi Michael,

On Monday 21 February 2011 15:47:28 Michael Jones wrote:
> Hi Laurent,
> 
> sorry to resurrect this from a month ago...
> 
> I've continued to export omap_pm_set_min_bus_tput() to enable building
> the omap3-isp module, although Paul Wamsley's reply you referred to
> clearly indicates that this is the wrong approach.
> 
> Aren't you also building omap3-isp as a module?  How are you guys
> getting around this?

On MeeGo omap_pm_set_min_bus_tput() is exported. A quick fix would be to add a 
callback to board code, or even remove the call completely, as 
omap_pm_set_min_bus_tput() in a no-op in mainline. A good fix would be to 
export the functionality of omap_pm_set_min_bus_tput() in a generic API that 
could be used by drivers.

-- 
Regards,

Laurent Pinchart