public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Andy Walls <awalls@md.metrocast.net>
Subject: Re: [GIT PATCHES FOR 2.6.39] fix cx18 regression
Date: Mon, 31 Jan 2011 12:12:58 -0200	[thread overview]
Message-ID: <4D46C36A.1040407@redhat.com> (raw)
In-Reply-To: <201101260823.43809.hverkuil@xs4all.nl>

Em 26-01-2011 05:23, Hans Verkuil escreveu:
> Mauro, please get this upstream asap since this fix needs to go into 2.6.38
> as well.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit e5fb95675639f064ca40df7ad319f1c380443999:
>   Hans Verkuil (1):
>         [media] vivi: fix compiler warning
> 
> are available in the git repository at:
> 
>   ssh://linuxtv.org/git/hverkuil/media_tree.git cx18-fix
> 
> Hans Verkuil (1):
>       cx18: fix kernel oops when setting MPEG control before capturing.
> 
>  drivers/media/video/cx18/cx18-driver.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 

I tried to apply it against 2.6.38-rc2, but it failed:

       	mutex_init(&cx->serialize_lock);
        mutex_init(&cx->gpio_lock);
        mutex_init(&cx->epu2apu_mb_lock);
       	mutex_init(&cx->epu2cpu_mb_lock);

        ret = cx18_create_in_workq(cx);
<<<<<<<
=======
       	cx->cxhdl.capabilities = CX2341X_CAP_HAS_TS | CX2341X_CAP_HAS_SLICED_VBI;
        cx->cxhdl.ops = &cx18_cxhdl_ops;
        cx->cxhdl.func = cx18_api_func;
        cx->cxhdl.priv = &cx->streams[CX18_ENC_STREAM_TYPE_MPG];
        ret = cx2341x_handler_init(&cx->cxhdl, 50);
>>>>>>>
        if (ret)
                return ret;

Perhaps this change requires some patch delayed for .39?

Cheers,
Mauro

  reply	other threads:[~2011-01-31 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26  7:23 [GIT PATCHES FOR 2.6.39] fix cx18 regression Hans Verkuil
2011-01-31 14:12 ` Mauro Carvalho Chehab [this message]
2011-02-02 23:50   ` Andy Walls
2011-02-03  7:09     ` Hans Verkuil
2011-02-05 12:13   ` Hans Verkuil
  -- strict thread matches above, loose matches on Subject: below --
2011-02-03 12:23 Andy Walls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D46C36A.1040407@redhat.com \
    --to=mchehab@redhat.com \
    --cc=awalls@md.metrocast.net \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox