From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55112 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752555Ab1BDADw (ORCPT ); Thu, 3 Feb 2011 19:03:52 -0500 Message-ID: <4D4B4264.9080705@redhat.com> Date: Thu, 03 Feb 2011 22:03:48 -0200 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Devin Heitmueller CC: Linux Media Mailing List Subject: Re: [PATCH RESEND] Fix bug in au0828 VBI streaming References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-ID: Sender: Em 03-02-2011 21:38, Devin Heitmueller escreveu: > On Wed, Feb 2, 2011 at 8:58 AM, Devin Heitmueller > wrote: >> On Sun, Jan 23, 2011 at 5:12 PM, Devin Heitmueller >> wrote: >>> Attached is a patch for a V4L2 spec violation with regards to the >>> au0828 not working in streaming mode. >>> >>> This was just an oversight on my part when I did the original VBI >>> support for this bridge, as libzvbi was silently falling back to using >>> the read() interface. >> >> Mauro, >> >> Where are we at with this patch. It's trivial and VBI is broken in >> V4L2 streaming mode without it. > > Mauro, > > I see this has been committed for 2.6.39. Given the trivial nature, > can we get it in there for 2.6.38 as well? It's a bugfix and the > au0828 VBI support is new to 2.6.38. If it doesn't go in, then the > VBI support will be present but broken for a full release cycle. This > could definitely cause problems for existing applications that now > detect the presence of VBI support, but then break when they try to > use it. It is already on my local fixes tree. I'll be sending upstream together with the next set of fixes. Cheers, Mauro