From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: linux-kernel@vger.kernel.org, security@kernel.org,
Luca Risolia <luca.risolia@studio.unibo.it>,
linux-usb@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 07/20] video: sn9c102: world-wirtable sysfs files
Date: Fri, 04 Feb 2011 13:29:12 -0200 [thread overview]
Message-ID: <4D4C1B48.4040107@infradead.org> (raw)
In-Reply-To: <b560d7c146330b382b90d739a76d580ed4051d4e.1296818921.git.segoon@openwall.com>
Em 04-02-2011 10:23, Vasiliy Kulikov escreveu:
> Don't allow everybody to change video settings.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Compile tested only.
>
> drivers/media/video/sn9c102/sn9c102_core.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/video/sn9c102/sn9c102_core.c b/drivers/media/video/sn9c102/sn9c102_core.c
> index 84984f6..ce56a1c 100644
> --- a/drivers/media/video/sn9c102/sn9c102_core.c
> +++ b/drivers/media/video/sn9c102/sn9c102_core.c
> @@ -1430,9 +1430,9 @@ static DEVICE_ATTR(i2c_reg, S_IRUGO | S_IWUSR,
> sn9c102_show_i2c_reg, sn9c102_store_i2c_reg);
> static DEVICE_ATTR(i2c_val, S_IRUGO | S_IWUSR,
> sn9c102_show_i2c_val, sn9c102_store_i2c_val);
> -static DEVICE_ATTR(green, S_IWUGO, NULL, sn9c102_store_green);
> -static DEVICE_ATTR(blue, S_IWUGO, NULL, sn9c102_store_blue);
> -static DEVICE_ATTR(red, S_IWUGO, NULL, sn9c102_store_red);
> +static DEVICE_ATTR(green, S_IWUSR, NULL, sn9c102_store_green);
> +static DEVICE_ATTR(blue, S_IWUSR, NULL, sn9c102_store_blue);
> +static DEVICE_ATTR(red, S_IWUSR, NULL, sn9c102_store_red);
> static DEVICE_ATTR(frame_header, S_IRUGO, sn9c102_show_frame_header, NULL);
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
next prev parent reply other threads:[~2011-02-04 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1296818921.git.segoon@openwall.com>
2011-02-04 12:23 ` [PATCH 07/20] video: sn9c102: world-wirtable sysfs files Vasiliy Kulikov
2011-02-04 15:29 ` Mauro Carvalho Chehab [this message]
2011-02-04 20:28 ` Luca Risolia
2011-03-12 20:23 ` [PATCH 00/20] world-writable files in sysfs and debugfs Vasiliy Kulikov
2011-03-14 22:18 ` [Security] " Andrew Morton
2011-03-15 2:26 ` James Bottomley
2011-03-15 3:09 ` [Security] " Greg KH
2011-03-15 11:50 ` James Bottomley
2011-03-15 14:18 ` Greg KH
2011-03-15 14:25 ` James Bottomley
2011-03-15 16:08 ` Vasiliy Kulikov
2011-03-15 16:32 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4C1B48.4040107@infradead.org \
--to=mchehab@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luca.risolia@studio.unibo.it \
--cc=security@kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox