From: "Kim, HeungJun" <riverful.kim@samsung.com>
To: Sylwester Nawrocki <snjw23@gmail.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl,
s.nawrocki@samsung.com, kyungmin.park@samsung.com
Subject: Re: [PATCH v4] Add support for M5MO-LS 8 Mega Pixel camera
Date: Tue, 08 Feb 2011 13:03:33 +0900 [thread overview]
Message-ID: <4D50C095.5060502@samsung.com> (raw)
In-Reply-To: <4D5067E4.2030709@gmail.com>
I've checked runnig checkpatch.pl, but I've not seen this message before.
And I re-check the patch sent now, but it's not.
Probably, It's issue between git send-email and our mail server setting.
I'll check once again, and resend.
Thanks let me know.
Regards
Heungjun Kim
2011-02-08 오전 6:45, Sylwester Nawrocki 쓴 글:
> Hi HeungJun,
>
> On 02/07/2011 12:44 PM, Heungjun Kim wrote:
>> Add I2C/V4L2 subdev driver for M5MO-LS camera sensor with integrated
>> image processor.
>>
>
> There is something wrong with this patch. It looks like it got mangled by
> the mailer. I can see some Korean characters in it and checkpatch.pl
> returns errors:
>
> ERROR: patch seems to be corrupt (line wrapped?)
> #122: FILE: drivers/media/video/Kconfig:747:
> =20
>
> ERROR: spaces required around that '=' (ctx:WxV)
> #208: FILE: drivers/media/video/m5mols/m5mols.h:36:
> + I2C_8BIT =3D 1,
> ^
>
> ERROR: spaces required around that '=' (ctx:WxV)
> #209: FILE: drivers/media/video/m5mols/m5mols.h:37:
> + I2C_16BIT =3D 2,
> ^
>
> ERROR: spaces required around that '=' (ctx:WxV)
> #210: FILE: drivers/media/video/m5mols/m5mols.h:38:
> + I2C_32BIT =3D 4,
> ^
> ...
>
> ERROR: spaces required around that '=' (ctx:WxV)
> #1500: FILE: drivers/media/video/m5mols/m5mols_core.c:892:
> + .remove =3D m5mols_remove,
> ^
>
> ERROR: spaces required around that '=' (ctx:WxV)
> #1501: FILE: drivers/media/video/m5mols/m5mols_core.c:893:
> + .id_table =3D m5mols_id,
> ^
>
> WARNING: please, no space before tabs
> #1672: FILE: include/media/m5mols.h:23:
> +* ^I^Ito be called after enabling and before disabling$
>
> total: 344 errors, 6 warnings, 1514 lines checked
>
>
> Regards,
> Sylwester
>
prev parent reply other threads:[~2011-02-08 4:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:44 [PATCH v4] Add support for M5MO-LS 8 Mega Pixel camera Heungjun Kim
2011-02-07 21:45 ` Sylwester Nawrocki
2011-02-08 4:03 ` Kim, HeungJun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D50C095.5060502@samsung.com \
--to=riverful.kim@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=snjw23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox