public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <maurochehab@gmail.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Qing Xu <qingx@marvell.com>, Hans Verkuil <hverkuil@xs4all.nl>,
	Neil Johnson <realdealneil@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Uwe Taeubert <u.taeubert@road.de>,
	"Karicheri, Muralidharan" <m-karicheri2@ti.com>,
	Eino-Ville Talvala <talvala@stanford.edu>
Subject: Re: [RFD] frame-size switching: preview / single-shot use-case
Date: Thu, 17 Feb 2011 16:27:16 -0200	[thread overview]
Message-ID: <4D5D6884.1090104@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1102151641490.16709@axis700.grange>

Em 15-02-2011 15:33, Guennadi Liakhovetski escreveu:
> Hi
> 
> This topic has been slightly discussed several times [1] before, but there 
> has been no conclusion, nor I'm aware of any implementation, suitably 
> resolving this problem. I've added to CC all involved in earlier 
> discussions, that I managed to find.
> 
> What seems a typical use-case to me is a system with a vewfinder or a 
> display, providing a live preview of the video data from a source, like a 
> camera, with a relatively low resolution, and a possibility to take 
> high-resolution still photos with a very short delay.
> 
> Currently this is pretty difficult to realise, e.g., with soc-camera 
> drivers you have to free the videobuf(2) queue, by either closing and 
> re-opening the interface, or by issuing an ioctl(VIDIOC_REQBUFS, 
> count=0) if your driver is already using videobuf2 and if this is really 
> working;), configure with a different resolution and re-allocate 
> videobuffers (or use different buffers, allocated per USERPTR). Another 
> possibility would be to allocate and use buffers large enough for still 
> photos, also for the preview, which would be wasteful, because one can 
> well need many more preview than still-shot buffers.
> 
> So, it seems to me, we could live with a better solution.
> 
> 1. We could use separate inputs for different capture modes and support 
> per-input videobuf queues. Advantage: no API changes required. 
> Disadvantages: confusing, especially, if a driver already exports multiple 
> inputs. The driver does not know, whether this mode is required or not, 
> always exporting 2 inputs for this purpose doesn't seem like a good idea. 
> Eventually, the user might want not 2, but 3 or more of such videobuf 
> queues.

Very bad. The high res is not a new input.
> 
> 2. Use different IO methods, e.g., mmap() for preview and read() for still 
> shots. I'm just mentioning this possibility here, because it occurred in 
> one of previous threads, but I don't really like it either. What if you 
> want to use the same IO method for all? Etc.

Can be done.
> 
> 3. Not liking either of the above, it seems we need yet a new API for 
> this... How about extending VIDIOC_REQBUFS with a videobuf queue index, 
> thus using up one of the remaining two 32-bit reserved fields? Then we 
> need one more ioctl() like VIDIOC_BUFQ_SELECT to switch from one queue to 
> another, after which setting frame format and queuing and dequeuing 
> buffers will affect this currently selected queue. We could also keep 
> REQBUFS as is and require BUFQ_SELECT to be called before it for any queue 
> except the default 0.
> 
> Yes, I know, that some video sensors have a double register set for this 
> dual-format operation, so, for them it is natural to support two queues, 
> and drivers are certainly most welcome to use this feature for, say, the 
> first two queues. On other sensors and for any further queues switching 
> will have to be done in software.

Seems too hacky to me. 

There's a 4th alternative: open the device twice, and use different settings
on each open. Userspace can stop streaming on one file descriptor and 
start the other one when he wants to take a high-res picture.

Cheers,
Mauro

  parent reply	other threads:[~2011-02-17 18:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 17:33 [RFD] frame-size switching: preview / single-shot use-case Guennadi Liakhovetski
2011-02-15 17:41 ` Karicheri, Muralidharan
2011-02-16  2:50 ` Qing Xu
2011-02-16  7:42   ` Guennadi Liakhovetski
2011-02-16  8:49     ` Hans Verkuil
2011-02-16  9:02       ` Guennadi Liakhovetski
2011-02-16  9:11         ` Laurent Pinchart
2011-02-16 10:35           ` Guennadi Liakhovetski
2011-02-17 16:46             ` Guennadi Liakhovetski
2011-02-18  9:47               ` Laurent Pinchart
2011-02-17 19:04             ` Mauro Carvalho Chehab
2011-02-17 19:26               ` Guennadi Liakhovetski
2011-02-17 20:46                 ` Mauro Carvalho Chehab
2011-02-17 21:13                   ` Guennadi Liakhovetski
2011-02-18 10:27               ` Laurent Pinchart
2011-02-16  2:55 ` Qing Xu
2011-02-17 18:27 ` Mauro Carvalho Chehab [this message]
     [not found] <4D5D9B57.3090809@gmail.com>
2011-02-17 23:09 ` Michal Nazarewicz
2011-02-18 10:31   ` Laurent Pinchart
2011-02-18 11:37     ` Michal Nazarewicz
2011-02-18 12:57       ` Laurent Pinchart
2011-02-18 13:19         ` Michal Nazarewicz
2011-02-18 13:21           ` Laurent Pinchart
2011-02-18 14:05             ` Michal Nazarewicz
2011-02-18 14:13               ` Laurent Pinchart
2011-02-18 12:33     ` Mauro Carvalho Chehab
2011-02-18 12:36       ` Laurent Pinchart
2011-02-18 12:46       ` Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5D6884.1090104@gmail.com \
    --to=maurochehab@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=qingx@marvell.com \
    --cc=realdealneil@gmail.com \
    --cc=robert.jarzmik@free.fr \
    --cc=talvala@stanford.edu \
    --cc=u.taeubert@road.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox