From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Igor M. Liplianin" <liplianin@me.by>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 5/9 v2] ds3000: clean up in tune procedure
Date: Thu, 24 Feb 2011 20:33:00 -0300 [thread overview]
Message-ID: <4D66EAAC.7020601@redhat.com> (raw)
In-Reply-To: <201102242225.35913.liplianin@me.by>
Em 24-02-2011 17:25, Igor M. Liplianin escreveu:
> В сообщении от 24 февраля 2011 21:11:13 автор Mauro Carvalho Chehab написал:
>> Em 24-02-2011 16:04, Mauro Carvalho Chehab escreveu:
>>> Hi Igor,
>>>
>>> Em 01-02-2011 20:40, Igor M. Liplianin escreveu:
>>>> Variable 'retune' does not make sense.
>>>> Loop is not needed for only one try.
>>>> Remove unnecessary dprintk's.
>>>>
>>>> Signed-off-by: Igor M. Liplianin <liplianin@me.by>
>>>
>>> This patch didn't apply. Please fix and resend.
>>
>> PS.: I won't try to apply patches 7, 8 and 9, as they are all related to
>> tune changes. They'll probably fail to apply, and, even if not failing or
>> if I fix the conflicts, they may be breaking the driver. So, please put
>> them on your next patch series.
>>
>> thanks!
>> Mauro
> Hi Mauro,
>
> Will do tonight.
OK.
> BTW, Why did you dropp/miss dw2102 patches?
> They was sent before ds3000 series.
I probably missed, or they are still on my queue. While in general I apply
patches in order, sometimes I reorder them, trying to merge first the more
trivial ones (or the ones that I had already analyzed, like the altera ones).
Please take a look at Patchwork. If they're there, then I'll probably be
handling until the weekend. Otherwise, just re-send them to me.
That's said, it is probably a good idea if you could have a git repository
somewhere to send me patches. Git works better when there are lots of
patches, so, works better for driver maintainers.
Thanks,
Mauro
next prev parent reply other threads:[~2011-02-24 23:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 22:40 [PATCH 5/9 v2] ds3000: clean up in tune procedure Igor M. Liplianin
2011-02-24 19:04 ` Mauro Carvalho Chehab
2011-02-24 19:11 ` Mauro Carvalho Chehab
2011-02-24 20:25 ` Igor M. Liplianin
2011-02-24 20:27 ` Igor M. Liplianin
2011-02-24 23:33 ` Mauro Carvalho Chehab [this message]
2011-02-24 23:33 ` Mauro Carvalho Chehab
2011-02-25 17:37 ` Igor M. Liplianin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D66EAAC.7020601@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox