Re: [RFC PATCH v2 1/3] v4l2-ctrls: change the boolean type of V4L2_CID_FOCUS_AUTO to menu type

["Kim, HeungJun" <riverful.kim@samsung.com>]

Hans, and Laurent,

2011-02-25 오후 6:54, Hans Verkuil 쓴 글:
> On Friday, February 25, 2011 10:21:59 Laurent Pinchart wrote:
>> On Friday 25 February 2011 07:21:27 Kim, HeungJun wrote:
>>> Support more modes of autofocus, it changes the type of V4L2_CID_FOCUS_AUTO
>>> from boolean to menu. And it includes 4 kinds of enumeration types:
>>>
>>> V4L2_FOCUS_AUTO, V4L2_FOCUS_MANUAL, V4L2_FOCUS_MACRO, V4L2_FOCUS_CONTINUOUS
>>>
>>> Signed-off-by: Heungjun Kim <riverful.kim@samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> ---
>>>  drivers/media/video/v4l2-ctrls.c |   11 ++++++++++-
>>>  include/linux/videodev2.h        |    6 ++++++
>>>  2 files changed, 16 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/media/video/v4l2-ctrls.c
>>> b/drivers/media/video/v4l2-ctrls.c index 2412f08..0b1cce0 100644
>>> --- a/drivers/media/video/v4l2-ctrls.c
>>> +++ b/drivers/media/video/v4l2-ctrls.c
>>> @@ -197,6 +197,13 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
>>>  		"Aperture Priority Mode",
>>>  		NULL
>>>  	};
>>> +	static const char * const camera_focus_auto[] = {
>>> +		"Manual Mode",
>>> +		"Auto Mode",
>>> +		"Macro Mode",
>>> +		"Continuous Mode",
>>
>> This might be nit-picking, but maybe the menu entries should be named "Manual 
>> Focus", "Auto Focus", "Macro Focus" and "Continuous Auto Focus". Hans ?
> 
> Yes, that's better. Although I believe that it should be 'Macro Auto Focus',
> right?
> 
> But if we change this for 'focus' then we need to do the same for the auto
> exposure menu which currently also uses the term 'Mode'.
> 
> Do you agree?

Although listenning Laurent's opinion first, if my opinion is asked, I agree
using term 'Focus', and agree using term 'Exposure' (is it right??) at the
exposure auto control, too.

If the name is decided, and came to the conclusion, I would modify to maintain
the term 'Focus' in the focus control name.

Regards,
Heungjun Kim