linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: halli manjunatha <manjunatha_halli@ti.com>
Cc: linux-media <linux-media@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Matti J. Aaltonen" <matti.j.aaltonen@nokia.com>
Subject: Re: [GIT PULL] TI WL 128x FM V4L2 driver
Date: Sun, 27 Feb 2011 07:58:59 -0300	[thread overview]
Message-ID: <4D6A2E73.6070806@redhat.com> (raw)
In-Reply-To: <AANLkTinAYrGV1k357Bn8trtxafZDoYozG7LDcm3KNBSt@mail.gmail.com>

Em 25-01-2011 03:48, halli manjunatha escreveu:
> Hi Mauro,
> 
> Please pull the WL128x FM V4L2 driver from
> http://dev.omapzoom.org/pub/scm/manju/L24x-btfm.git fm_v4l2_upstream
> 
> This is TI WL128x FM V4L2 driver and it introduces ‘wl128x’ folder
> under the ‘drivers/media/radio’. This driver enables support for FM RX
> and TX for Texas Instrument's WL128x (also compatible with WL127x)
> WiLink chip sets. The V4L2 FM driver can work in either Rx or Tx mode,
> and V4L2 interfaces are provided for both.
> 
> Texas Instrument's WL128x chip set packs BT, FM, GPS and WLAN in a
> single die with BT, FM and GPS being interfaced over a single UART.
> This driver works on top of the shared transport line discipline
> driver. This driver can also be made use for the WL127x version of the
> chip which packs BT, FM and WLAN only.
> 
> This driver has been reviewed by various folks within TI and also in
> Linux media community. The driver has been tested extensively on TI
> platforms and we believe that it is ready for merge into mainline.

Applied, thanks.

>From what I understood from your comments, this driver will also cover 
wl127x chips. As such, it would be better to double check if all functionalities
present at drivers/media/radio/radio-wl1273.c (assuming that wl1273 is covered)
are also on the new driver, and, if not, merge the remaining ones and deprecate
the wl1273-specific driver.

Cheers,
Mauro
> 
> The following changes since commit db309d3d54c2f721dd1176ce86c63b0381c0a258:
>   Mauro Carvalho Chehab (1):
>         [media] add support for Encore FM3
> 
> are available in the git repository at:
> 
>   http://dev.omapzoom.org/pub/scm/manju/L24x-btfm.git fm_v4l2_upstream
> 
> Manjunatha Halli (7):
>       drivers:media:radio: wl128x: FM Driver common header file
>       drivers:media:radio: wl128x: FM Driver V4L2 sources
>       drivers:media:radio: wl128x: FM Driver Common sources
>       drivers:media:radio: wl128x: FM driver RX sources
>       drivers:media:radio: wl128x: FM driver TX sources
>       drivers:media:radio: wl128x: Kconfig & Makefile for wl128x driver
>       drivers:media:radio: Update Kconfig and Makefile for wl128x FM driver
> 
>  drivers/media/radio/Kconfig               |    3 +
>  drivers/media/radio/Makefile              |    1 +
>  drivers/media/radio/wl128x/Kconfig        |   17 +
>  drivers/media/radio/wl128x/Makefile       |    6 +
>  drivers/media/radio/wl128x/fmdrv.h        |  244 +++++
>  drivers/media/radio/wl128x/fmdrv_common.c | 1677 +++++++++++++++++++++++++++++
>  drivers/media/radio/wl128x/fmdrv_common.h |  402 +++++++
>  drivers/media/radio/wl128x/fmdrv_rx.c     |  847 +++++++++++++++
>  drivers/media/radio/wl128x/fmdrv_rx.h     |   59 +
>  drivers/media/radio/wl128x/fmdrv_tx.c     |  425 ++++++++
>  drivers/media/radio/wl128x/fmdrv_tx.h     |   37 +
>  drivers/media/radio/wl128x/fmdrv_v4l2.c   |  580 ++++++++++
>  drivers/media/radio/wl128x/fmdrv_v4l2.h   |   33 +
>  13 files changed, 4331 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/media/radio/wl128x/Kconfig
>  create mode 100644 drivers/media/radio/wl128x/Makefile
>  create mode 100644 drivers/media/radio/wl128x/fmdrv.h
>  create mode 100644 drivers/media/radio/wl128x/fmdrv_common.c
>  create mode 100644 drivers/media/radio/wl128x/fmdrv_common.h
>  create mode 100644 drivers/media/radio/wl128x/fmdrv_rx.c
>  create mode 100644 drivers/media/radio/wl128x/fmdrv_rx.h
>  create mode 100644 drivers/media/radio/wl128x/fmdrv_tx.c
>  create mode 100644 drivers/media/radio/wl128x/fmdrv_tx.h
>  create mode 100644 drivers/media/radio/wl128x/fmdrv_v4l2.c
>  create mode 100644 drivers/media/radio/wl128x/fmdrv_v4l2.h
> 


  parent reply	other threads:[~2011-02-27 10:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25  5:48 [GIT PULL] TI WL 128x FM V4L2 driver halli manjunatha
2011-01-25 15:04 ` Mark Brown
2011-01-27  9:32   ` halli manjunatha
2011-01-27  9:54     ` Mark Brown
2011-01-27 11:43       ` Ohad Ben-Cohen
     [not found] ` <AANLkTingOYyEs4ZZrcaV0NOhiuGzSpvkATPRFjhFMCmE@mail.gmail.com>
2011-02-14 12:28   ` halli manjunatha
2011-02-27 10:58 ` Mauro Carvalho Chehab [this message]
2011-02-28 13:12   ` halli manjunatha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6A2E73.6070806@redhat.com \
    --to=mchehab@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=manjunatha_halli@ti.com \
    --cc=matti.j.aaltonen@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).