From: Jiri Slaby <jslaby@suse.cz>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: mchehab@infradead.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com
Subject: Re: [PATCH v2 -resend#1 1/1] V4L: videobuf, don't use dma addr as physical
Date: Mon, 28 Feb 2011 16:47:58 +0100 [thread overview]
Message-ID: <4D6BC3AE.903@suse.cz> (raw)
In-Reply-To: <20110228145301.GC10846@dumpdata.com>
On 02/28/2011 03:53 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 28, 2011 at 10:37:02AM +0100, Jiri Slaby wrote:
>> mem->dma_handle is a dma address obtained by dma_alloc_coherent which
>> needn't be a physical address in presence of IOMMU. So ensure we are
>
> Can you add a comment why you are fixing it? Is there a bug report for this?
> Under what conditions did you expose this fault?
No, by a just peer review when I was looking for something completely
different.
> You also might want to mention that "needn't be a physical address as
> a hardware IOMMU can (and most likely) will return a bus address where
> physical != bus address."
Mauro, do you want me to resend this with such an udpate in the changelog?
> Otherwise you can stick 'Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>'
> on it.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2011-02-28 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 9:37 [PATCH v2 -resend#1 1/1] V4L: videobuf, don't use dma addr as physical Jiri Slaby
2011-02-28 10:53 ` Laurent Pinchart
2011-02-28 15:07 ` Jiri Slaby
2011-02-28 15:14 ` Laurent Pinchart
2011-02-28 15:45 ` Jiri Slaby
2011-02-28 14:53 ` Konrad Rzeszutek Wilk
2011-02-28 15:47 ` Jiri Slaby [this message]
2011-02-28 18:20 ` Mauro Carvalho Chehab
2011-03-21 22:43 ` Mauro Carvalho Chehab
2011-03-21 22:55 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6BC3AE.903@suse.cz \
--to=jslaby@suse.cz \
--cc=jirislaby@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).