Re: [PATCH] Ngene cam device name

[Andreas Oberritter <obi@linuxtv.org>]

On 03/11/2011 10:46 PM, Ralph Metzler wrote:
> Andreas Oberritter writes:
>  > >> On 03/10/2011 04:29 PM, Issa Gorissen wrote:
>  > > Now, according to Mauro comments, he has put this code into staging because of
>  > > the usage of sec0 name for a cam device.
>  > > 
>  > > Please comment on Oliver's explanations from this thread
>  > > 
>  > > http://www.mail-archive.com/linux-media@vger.kernel.org/msg26901.html
>  > 
>  > Oliver explained that he's not going to put work into this driver,
>  > because he's not using it.
>  > 
>  > Until now, I haven't heard any reasons for just adding another device
>  > node other than it being easier than defining a proper interface. The
>  > fact that a solution "just works as is" is not sufficient to move a
>  > driver from staging. IMO the CI driver should not have been included at
>  > all in its current shape.
> 
> Unless you want to move the writing to/reading from the CI module into
> ioctls of the ci device you need another node. 
> Even nicer would be having the control messages moved to ioctls and the
> TS IO in read/write of ci, but this would break the old interface.

It's possible to keep compatibility. Just add ioctls to get and set the
interface version. Default to the current version, not supporting TS
I/O. If the version is set to e.g. 1, switch from the current interface
to the new one, using ioctls for control messages.

> What kind of proper interface were you thinking about?

At least something that's documented and has a defined behaviour.

Regards,
Andreas