From: Antti Palosaari <crope@iki.fi>
To: Florian Mickler <florian@mickler.org>
Cc: mchehab@infradead.org, oliver@neukum.org, jwjstone@fastmail.fm,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 09/16] [media] au6610: get rid of on-stack dma buffer
Date: Fri, 18 Mar 2011 23:40:07 +0200 [thread overview]
Message-ID: <4D83D137.6000307@iki.fi> (raw)
In-Reply-To: <20110318222713.4c51f1ed@schatten.dmk.lab>
On 03/18/2011 11:27 PM, Florian Mickler wrote:
> On Fri, 18 Mar 2011 18:34:58 +0200
> Antti Palosaari<crope@iki.fi> wrote:
>
>> On 03/15/2011 10:43 AM, Florian Mickler wrote:
>>> usb_control_msg initiates (and waits for completion of) a dma transfer using
>>> the supplied buffer. That buffer thus has to be seperately allocated on
>>> the heap.
>>>
>>> In lib/dma_debug.c the function check_for_stack even warns about it:
>>> WARNING: at lib/dma-debug.c:866 check_for_stack
>>>
>>> Note: This change is tested to compile only, as I don't have the hardware.
>>>
>>> Signed-off-by: Florian Mickler<florian@mickler.org>
>>
>>
>> This patch did not found from patchwork! Probably skipped due to broken
>> Cc at my contact. Please resend.
>>
>> Anyhow, I tested and reviewed it.
>>
>> Acked-by: Antti Palosaari<crope@iki.fi>
>> Reviewed-by: Antti Palosaari<crope@iki.fi>
>> Tested-by: Antti Palosaari<crope@iki.fi>
>>
>> [1] https://patchwork.kernel.org/project/linux-media/list/
>>
>> Antti
>>
>
> Yes, there was some broken adressing on my side. Sorry.
>
> Thanks for review&& test! I will resend (hopefully this weekend) the
> series when I reviewed some of the other patches if it is
> feasible/better to use prealocated memory as suggested by Mauro.
>
> How often does au6610_usb_msg get called in normal operation? Should it
> use preallocated memory?
It is called by demodulator and tuner drivers via I2C. One call per one
register access. Tuner driver is qt1010 and demod driver is zl10353.
When you perform tune to channel and device is in sleep there is maybe
100 or more calls. After channel is tuned as OK, application starts
calling only some signalling statistics from demod, it is usually only
few calls per sec.
On my experience I cannot say if it is wise to preallocate or not.
Anyhow, this same apply for all DVB USB drivers.
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2011-03-18 21:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 11:16 [PATCH] [media] dib0700: get rid of on-stack dma buffers Florian Mickler
2011-03-06 12:06 ` Oliver Neukum
2011-03-06 14:38 ` Florian Mickler
2011-03-06 14:45 ` [PATCH 1/3 v2] " Florian Mickler
2011-03-06 14:45 ` [PATCH 2/3] [media] dib0700: remove unused variable Florian Mickler
2011-03-06 14:45 ` [PATCH 3/3] [media] dib0700: don't ignore errors in driver probe Florian Mickler
2011-03-06 15:06 ` [PATCH] [media] dib0700: get rid of on-stack dma buffers Oliver Neukum
2011-03-06 15:45 ` Florian Mickler
2011-03-06 16:44 ` Oliver Neukum
2011-03-06 17:47 ` [PATCH 1/2 v3] " Florian Mickler
2011-03-06 17:47 ` [PATCH 2/2] [media] dib0700: remove unused variable Florian Mickler
2011-03-06 17:57 ` [PATCH 1/2 v3] [media] dib0700: get rid of on-stack dma buffers Florian Mickler
2011-03-15 8:36 ` Florian Mickler
2011-03-15 8:43 ` [PATCH 01/16] " Florian Mickler
2011-03-15 8:43 ` [PATCH 02/16] [media] dib0700: remove unused variable Florian Mickler
2011-03-15 8:43 ` [PATCH 03/16] [media] a800: get rid of on-stack dma buffers Florian Mickler
2011-03-15 8:43 ` [PATCH 04/16] [media] vp7045: " Florian Mickler
2011-03-15 8:43 ` [PATCH 05/16] [media] ec168: get rid of on stack " Florian Mickler
2011-03-18 16:36 ` Antti Palosaari
2011-03-18 21:33 ` Florian Mickler
2011-03-15 8:43 ` [PATCH 06/16] [media] ce6230: get rid of on-stack dma buffer Florian Mickler
2011-03-18 16:36 ` Antti Palosaari
2011-03-18 21:28 ` Florian Mickler
2011-03-15 8:43 ` [PATCH 07/16] [media] friio: get rid of on-stack dma buffers Florian Mickler
2011-03-15 8:43 ` [PATCH 11/16] [media] lmedm04: correct indentation Florian Mickler
2011-03-15 8:43 ` [PATCH 12/16] [media] lmedm04: get rid of on-stack dma buffers Florian Mickler
2011-03-15 20:54 ` Malcolm Priestley
2011-03-15 21:46 ` Florian Mickler
2011-03-15 12:02 ` [PATCH 01/16] [media] dib0700: " Mauro Carvalho Chehab
2011-03-15 21:14 ` Florian Mickler
[not found] ` <1300178655-24832-9-git-send-email-florian@mickler.org>
2011-03-18 16:34 ` [PATCH 09/16] [media] au6610: get rid of on-stack dma buffer Antti Palosaari
2011-03-18 21:27 ` Florian Mickler
2011-03-18 21:40 ` Antti Palosaari [this message]
2011-03-15 11:37 ` [PATCH 1/2 v3] [media] dib0700: get rid of on-stack dma buffers Mauro Carvalho Chehab
2011-03-06 13:49 ` [PATCH] " Jack Stone
2011-03-06 14:00 ` Florian Mickler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D83D137.6000307@iki.fi \
--to=crope@iki.fi \
--cc=florian@mickler.org \
--cc=jwjstone@fastmail.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox