public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kim, HeungJun" <riverful.kim@samsung.com>
To: Sylwester Nawrocki <snjw23@gmail.com>
Cc: Kim HeungJun <riverful@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Add support for M-5MOLS 8 Mega Pixel camera
Date: Mon, 21 Mar 2011 15:08:33 +0900	[thread overview]
Message-ID: <4D86EB61.1010706@samsung.com> (raw)
In-Reply-To: <4D8503EC.6040103@gmail.com>

Hi Sylwester,

2011-03-20 오전 4:28, Sylwester Nawrocki 쓴 글:
> On 03/19/2011 04:11 PM, Kim HeungJun wrote:
>> Hi Sylwester,
>>
>> Thanks for the reviews. :)
>>
>> 2011. 3. 19., 오후 10:37, Sylwester Nawrocki 작성:
>>
>>> Hi HeungJun,
>>>
>>> On 03/16/2011 02:38 PM, Kim, Heungjun wrote:
>>>> Add I2C/V4L2 subdev driver for M-5MOLS camera sensor with integrated
>>>> image signal processor.
>>>>
[snip]
>>>>
>>>> 3. Speed-up whole I2C operation
>>>> 	: I've tested several times for decreasing the stabilization time
>>>> 	while I2C communication, and I have find proper time. Of course,
>>>> 	it's more faster than previous version.
>>>
>>> That sounds good. Do you think the delays before I2C read/write could
>>> be avoided in some (if not all) cases by using some status registers
>>> polling?
>> I don't understand literally. Could you explain more detailed with some examples?
>> My understanding is that it might be an issues or problem when getting some
>> status registers with polling it. is it right?
> 
> My concern is that we might not need an extra delay between consecutive 
> read or write operations in every case. Possibly it would be enough
> to read the status of some operations instead. But that just what I suspect.
Ah, I understand. The consecutive delay needs to read/write operations.
Because, in non-delay cases, I found the values is not changed to be read
when the driver is reading continuously at the different address. I means,
if there is not regular amount of delay in r/w operations, the value is kept
the previous value to be read by I2C operation. It's the same way in writing
case. It's wierd.

It might be different the kind of M-5MOLS sensor's FW and packaging type. But,
I expect that the internal ARM core of M-5MOLS takes time to proceed something
and to load values through I2C bus for the host process. 

Regards,
Heungjun Kim

  reply	other threads:[~2011-03-21  6:08 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 13:38 [PATCH] Add support for M-5MOLS 8 Mega Pixel camera Kim, Heungjun
2011-03-19 13:37 ` Sylwester Nawrocki
2011-03-19 15:11   ` Kim HeungJun
2011-03-19 19:28     ` Sylwester Nawrocki
2011-03-21  6:08       ` Kim, HeungJun [this message]
2011-04-04 12:20 ` Sungchun Kang
2011-04-05  5:36   ` Kim, HeungJun
2011-04-05  5:38     ` Kim, HeungJun
2011-05-13 10:06 ` [PATCH v7] Add support for M-5MOLS 8 Mega Pixel camera ISP HeungJun, Kim
2011-05-13 11:38   ` HeungJun, Kim
2011-05-16  1:03     ` [PATCH v8] " HeungJun, Kim
2011-05-20  5:56       ` [PATCH v9] " HeungJun, Kim
2011-05-25 13:54         ` Sakari Ailus
2011-05-26  7:12           ` Kim, HeungJun
2011-06-05 11:55             ` Sakari Ailus
2011-06-05 12:11               ` Hans Verkuil
2011-06-05 13:08                 ` Sakari Ailus
2011-06-05 13:13               ` Sylwester Nawrocki
2011-06-06 10:17                 ` Sakari Ailus
2011-06-06  9:14               ` Kim HeungJun
2011-05-27 12:58           ` [PATCH 0/5] Fix micellaneous issues for M-5MOLS driver HeungJun, Kim
2011-05-31  7:35             ` [PATCH v2 0/4] " HeungJun, Kim
2011-05-31  7:35             ` [PATCH v2 1/4] m5mols: Fix capture image size register definition HeungJun, Kim
2011-05-31  7:36             ` [PATCH v2 2/4] m5mols: add m5mols_read_u8/u16/u32() according to I2C byte width HeungJun, Kim
2011-05-31  7:36             ` [PATCH v2 3/4] m5mols: remove union in the m5mols_get_version(), and VERSION_SIZE HeungJun, Kim
2011-06-05 12:03               ` Sakari Ailus
2011-06-05 12:11                 ` Sakari Ailus
2011-06-06  9:20                   ` Kim HeungJun
2011-05-31  7:36             ` [PATCH v2 4/4] m5mols: add parenthesis <> for the head and back of email address HeungJun, Kim
2011-05-27 12:58           ` [PATCH 1/5] m5mols: fix reading wrong size of captured main/thumb image HeungJun, Kim
2011-05-27 12:58           ` [PATCH 2/5] m5mols: add m5mols_read_u8/u16/u32() according to I2C byte width HeungJun, Kim
2011-05-27 12:58           ` [PATCH 3/5] m5mols: remove union in the m5mols_get_version(), and VERSION_SIZE HeungJun, Kim
2011-05-27 12:58           ` [PATCH 4/5] m5mols: rename m5mols_capture_error_handler() to proper name HeungJun, Kim
2011-05-27 12:58           ` [PATCH 5/5] m5mols: add parenthesis <> for the head and back of email address HeungJun, Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D86EB61.1010706@samsung.com \
    --to=riverful.kim@samsung.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=riverful@gmail.com \
    --cc=s.nawrocki@samsung.com \
    --cc=snjw23@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox