From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:43224 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754773Ab1CVAoA (ORCPT ); Mon, 21 Mar 2011 20:44:00 -0400 Message-ID: <4D87F0CB.2090705@iki.fi> Date: Tue, 22 Mar 2011 02:43:55 +0200 From: Antti Palosaari MIME-Version: 1.0 To: Malcolm Priestley CC: Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH 1/2] v180 - DM04/QQBOX added support for BS2F7HZ0194 versions References: <1297560908.24985.5.camel@tvboxspy> <4D87EAA7.2040803@redhat.com> <1300753968.15997.4.camel@localhost> In-Reply-To: <1300753968.15997.4.camel@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-ID: Sender: On 03/22/2011 02:32 AM, Malcolm Priestley wrote: > On Mon, 2011-03-21 at 21:17 -0300, Mauro Carvalho Chehab wrote: >> Em 12-02-2011 23:35, Malcolm Priestley escreveu: >>> Old versions of these boxes have the BS2F7HZ0194 tuner module on >>> both the LME2510 and LME2510C. >>> >>> Firmware dvb-usb-lme2510-s0194.fw and/or dvb-usb-lme2510c-s0194.fw >>> files are required. >>> >>> See Documentation/dvb/lmedm04.txt >>> >>> Patch 535181 is also required. >>> >>> Signed-off-by: Malcolm Priestley >>> --- >> >>> @@ -1110,5 +1220,5 @@ module_exit(lme2510_module_exit); >>> >>> MODULE_AUTHOR("Malcolm Priestley"); >>> MODULE_DESCRIPTION("LME2510(C) DVB-S USB2.0"); >>> -MODULE_VERSION("1.76"); >>> +MODULE_VERSION("1.80"); >>> MODULE_LICENSE("GPL"); >> >> >> There were a merge conflict on this patch. The version we have was 1.75. >> >> Maybe some patch got missed? > > 1.76 relates to remote control patches. > > https://patchwork.kernel.org/patch/499391/ > https://patchwork.kernel.org/patch/499401/ Those are NEC extended remotes. You are now setting it as 32 bit NEC, in my understanding it should be defined as 24 bit NEC extended. Anyhow, my opinion is still that we *should* make all NEC remotes as 32 bit and leave handling of NEC 16, NEC 24, NEC 32 to NEC decoder. For example AF9015 current NEC handling is too complex for that reason... I don't like how it is implemented currently. Antti -- http://palosaari.fi/