public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Auke Kok <auke-jan.h.kok@intel.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] [media] use pci_dev->revision
Date: Thu, 24 Mar 2011 12:51:41 -0700	[thread overview]
Message-ID: <4D8BA0CD.3090105@intel.com> (raw)
In-Reply-To: <1300718156-25395-1-git-send-email-bjorn@mork.no>

On 03/21/11 07:35, Bjørn Mork wrote:
> pci_setup_device() has saved the PCI revision in the pci_dev
> struct since Linux 2.6.23.  Use it.
>
> Cc: Auke Kok<auke-jan.h.kok@intel.com>
> Signed-off-by: Bjørn Mork<bjorn@mork.no>
> ---
> I assume some of these drivers could have the revision
> removed from their driver specific structures as well, but
> I haven't done that to avoid unnecessary ABI changes.
>
>   drivers/media/common/saa7146_core.c        |    7 +------
>   drivers/media/dvb/b2c2/flexcop-pci.c       |    4 +---
>   drivers/media/dvb/bt8xx/bt878.c            |    2 +-
>   drivers/media/dvb/mantis/mantis_pci.c      |    5 ++---
>   drivers/media/video/bt8xx/bttv-driver.c    |    2 +-
>   drivers/media/video/cx18/cx18-driver.c     |    2 +-
>   drivers/media/video/cx23885/cx23885-core.c |    2 +-
>   drivers/media/video/cx88/cx88-mpeg.c       |    2 +-
>   drivers/media/video/cx88/cx88-video.c      |    2 +-
>   drivers/media/video/ivtv/ivtv-driver.c     |    4 +---
>   drivers/media/video/saa7134/saa7134-core.c |    2 +-
>   drivers/media/video/saa7164/saa7164-core.c |    2 +-
>   drivers/media/video/zoran/zoran_card.c     |    2 +-
>   13 files changed, 14 insertions(+), 24 deletions(-)

looks great, thanks for picking up this (overdue) cleanup :)

Auke

      reply	other threads:[~2011-03-24 19:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21 14:35 [PATCH] [media] use pci_dev->revision Bjørn Mork
2011-03-24 19:51 ` Auke Kok [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D8BA0CD.3090105@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=bjorn@mork.no \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox