From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"david.cohen@nokia.com" <david.cohen@nokia.com>,
"hiroshi.doyu@nokia.com" <hiroshi.doyu@nokia.com>
Subject: Re: [PATCH 1/4] omap iommu: Check existence of arch_iommu
Date: Sun, 27 Mar 2011 20:04:10 +0300 [thread overview]
Message-ID: <4D8F6E0A.5080404@maxwell.research.nokia.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739404E21D57E2@dbde02.ent.ti.com>
Hiremath, Vaibhav wrote:
>> -----Original Message-----
>> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
>> owner@vger.kernel.org] On Behalf Of Sakari Ailus
>> Sent: Friday, March 25, 2011 8:43 PM
>> To: linux-media@vger.kernel.org
>> Cc: laurent.pinchart@ideasonboard.com; david.cohen@nokia.com;
>> hiroshi.doyu@nokia.com
>> Subject: [PATCH 1/4] omap iommu: Check existence of arch_iommu
>>
>> Check that the arch_iommu has been installed before trying to use it. This
>> will lead to kernel oops if the arch_iommu isn't there.
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
>> ---
>> arch/arm/plat-omap/iommu.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
>> index b1107c0..f0fea0b 100644
>> --- a/arch/arm/plat-omap/iommu.c
>> +++ b/arch/arm/plat-omap/iommu.c
>> @@ -104,6 +104,9 @@ static int iommu_enable(struct iommu *obj)
>> if (!obj)
>> return -EINVAL;
>>
>> + if (!arch_iommu)
>> + return -ENOENT;
>> +
> [Hiremath, Vaibhav] Similar patch has already been submitted and
accepted in community, not sure which baseline you are using. Please
refer to below commit -
>
Thanks, Vaibhav. I guess I need to update my tree and resend the set...
Cheers,
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2011-03-27 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D8CB106.7030608@maxwell.research.nokia.com>
2011-03-25 15:13 ` [PATCH 1/4] omap iommu: Check existence of arch_iommu Sakari Ailus
2011-03-25 15:19 ` Sakari Ailus
2011-03-25 19:07 ` Hiremath, Vaibhav
2011-03-27 17:04 ` Sakari Ailus [this message]
2011-03-25 15:13 ` [PATCH 2/4] omap iommu: Add module information to struct iommu_functions Sakari Ailus
2011-03-25 15:13 ` [PATCH 3/4] omap2 iommu: Set module information in omap2_iommu_ops Sakari Ailus
2011-03-25 15:13 ` [PATCH 4/4] omap iommu: Prevent iommu implementations from being unloaded while in use Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8F6E0A.5080404@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=david.cohen@nokia.com \
--cc=hiroshi.doyu@nokia.com \
--cc=hvaibhav@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox