public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Marko Ristola <marko.ristola@kolumbus.fi>
To: Marko Ristola <marko.ristola@kolumbus.fi>
Cc: Andreas Oberritter <obi@linuxtv.org>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Speed up DVB TS stream delivery from DMA buffer into dvb-core's buffer
Date: Fri, 08 Apr 2011 22:37:05 +0300	[thread overview]
Message-ID: <4D9F63E1.6060808@kolumbus.fi> (raw)
In-Reply-To: <4D9F2C83.6070401@kolumbus.fi>


Here is some statistics without likely and with likely functions.

It seems that using likely() gives better performance with Phenom I too.

	%	Plain knl %	No likely	%	With likely	%
dvb_ringbuffer_write	5,9	62,8	8,7	81,3	5,7	79,2
dvb_dmx_swfilter_packet	1,2	12,8	0,7	6,5	0,8	11,1
dvb_dmx_swfilter_204	2,3	24,5	1,3	12,1	0,7	9,7


Here "Plain knl %" is "perf top -d 30" percentage.
24,5 12,1 and 9,7 are percentages without a patch, with basic patch
and last is with "likely" functions using patch.

Regards,
Marko Ristola


08.04.2011 18:40, Marko Ristola kirjoitti:
> Avoid unnecessary DVB TS 188 sized packet copying from DMA buffer into stack.
> Backtrack one 188 sized packet just after some garbage bytes when possible.
> This obsoletes patch https://patchwork.kernel.org/patch/118147/
> 
> Signed-off-by: Marko Ristola marko.ristola@kolumbus.fi
> diff --git a/drivers/media/dvb/dvb-core/dvb_demux.c b/drivers/media/dvb/dvb-core/dvb_demux.c
> index 4a88a3e..faa3671 100644
> --- a/drivers/media/dvb/dvb-core/dvb_demux.c
> +++ b/drivers/media/dvb/dvb-core/dvb_demux.c
> @@ -478,97 +478,94 @@ void dvb_dmx_swfilter_packets(struct dvb_demux *demux, const u8 *buf,
>  
>  EXPORT_SYMBOL(dvb_dmx_swfilter_packets);
>  

  reply	other threads:[~2011-04-08 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 15:40 [PATCH] Speed up DVB TS stream delivery from DMA buffer into dvb-core's buffer Marko Ristola
2011-04-08 19:37 ` Marko Ristola [this message]
2011-04-10 12:28   ` Andreas Oberritter
2011-04-10 12:10 ` Andreas Oberritter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9F63E1.6060808@kolumbus.fi \
    --to=marko.ristola@kolumbus.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=obi@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox