Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 19-04-2011 16:54, Antonio Ospite escreveu:
> On Tue, 19 Apr 2011 20:20:29 +0200
> Jean-Francois Moine <moinejf@free.fr> wrote:
> 
>> The following changes since commit
>> d58307d6a1e2441ebaf2d924df4346309ff84c7d:
>>
>>   [media] anysee: add more info about known board configs (2011-04-19 10:35:37 -0300)
>>
>> are available in the git repository at:
>>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
>>
>> Antonio Ospite (2):
>>       Add Y10B, a 10 bpp bit-packed greyscale format.
>>       gspca - kinect: New subdriver for Microsoft Kinect
>>
> 
> Ah glad to see that, so there was no major concern on the code, was
> there?

There's just a problem that I noticed:

drivers/media/video/gspca/kinect.c: In function ‘send_cmd.clone.0’:
drivers/media/video/gspca/kinect.c:202: warning: the frame size of 1548 bytes is larger than 1024 bytes

Please, don't do things like:

+ uint8_t obuf[0x400];
+ uint8_t ibuf[0x200];

at the stack. Instead, put it into a per-device struct.

Anyway, I've applied your patches here. Please send us a fix for it
as soon as possible.

Thanks,
Mauro