[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Jean-Francois Moine]

The following changes since commit
d58307d6a1e2441ebaf2d924df4346309ff84c7d:

  [media] anysee: add more info about known board configs (2011-04-19 10:35:37 -0300)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

Antonio Ospite (2):
      Add Y10B, a 10 bpp bit-packed greyscale format.
      gspca - kinect: New subdriver for Microsoft Kinect

Jean-François Moine (1):
      gspca - zc3xx: Adjust the mc501cb exchanges

Patrice Chotard (5):
      gspca - jeilinj: suppress workqueue
      gspca - jeilinj: use gspca_dev->usb_err to forward error to upper layer
      gspca - jeilinj: add 640*480 resolution support
      gspca - jeilinj: Add SPORTSCAM_DV15 camera support
      gspca - jeilinj: add SPORTSCAM specific controls

 Documentation/DocBook/media-entities.tmpl |    1 +
 Documentation/DocBook/v4l/pixfmt-y10b.xml |   43 +++
 Documentation/DocBook/v4l/pixfmt.xml      |    1 +
 Documentation/DocBook/v4l/videodev2.h.xml |    3 +
 Documentation/video4linux/gspca.txt       |    1 +
 drivers/media/video/gspca/Kconfig         |    9 +
 drivers/media/video/gspca/Makefile        |    2 +
 drivers/media/video/gspca/jeilinj.c       |  581 ++++++++++++++++++++---------
 drivers/media/video/gspca/kinect.c        |  427 +++++++++++++++++++++
 drivers/media/video/gspca/zc3xx.c         |   42 +--
 include/linux/videodev2.h                 |    3 +
 11 files changed, 905 insertions(+), 208 deletions(-)
 create mode 100644 Documentation/DocBook/v4l/pixfmt-y10b.xml
 create mode 100644 drivers/media/video/gspca/kinect.c

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

On Tue, 19 Apr 2011 20:20:29 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> The following changes since commit
> d58307d6a1e2441ebaf2d924df4346309ff84c7d:
> 
>   [media] anysee: add more info about known board configs (2011-04-19 10:35:37 -0300)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
> 
> Antonio Ospite (2):
>       Add Y10B, a 10 bpp bit-packed greyscale format.
>       gspca - kinect: New subdriver for Microsoft Kinect
> 

Ah glad to see that, so there was no major concern on the code, was
there?

Thanks Jean-Francois,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Mauro Carvalho Chehab]

Em 19-04-2011 16:54, Antonio Ospite escreveu:
> On Tue, 19 Apr 2011 20:20:29 +0200
> Jean-Francois Moine <moinejf@free.fr> wrote:
> 
>> The following changes since commit
>> d58307d6a1e2441ebaf2d924df4346309ff84c7d:
>>
>>   [media] anysee: add more info about known board configs (2011-04-19 10:35:37 -0300)
>>
>> are available in the git repository at:
>>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
>>
>> Antonio Ospite (2):
>>       Add Y10B, a 10 bpp bit-packed greyscale format.
>>       gspca - kinect: New subdriver for Microsoft Kinect
>>
> 
> Ah glad to see that, so there was no major concern on the code, was
> there?

There's just a problem that I noticed:

drivers/media/video/gspca/kinect.c: In function ‘send_cmd.clone.0’:
drivers/media/video/gspca/kinect.c:202: warning: the frame size of 1548 bytes is larger than 1024 bytes

Please, don't do things like:

+ uint8_t obuf[0x400];
+ uint8_t ibuf[0x200];

at the stack. Instead, put it into a per-device struct.

Anyway, I've applied your patches here. Please send us a fix for it
as soon as possible.

Thanks,
Mauro

[PATCH 0/3] gspca_kinect fixup

[Antonio Ospite]

Hi,

some incremental fixes for the gspca kinect driver, the first patch in 
the series by Drew Fisher addresses the issue Mauro was pointing out.

Thanks,
   Antonio

Antonio Ospite (1):
  gspca - kinect: fix comments referring to color camera

Drew Fisher (2):
  gspca - kinect: move communications buffers out of stack
  gspca - kinect: fix a typo s/steram/stream/

 drivers/media/video/gspca/kinect.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[PATCH 1/3] gspca - kinect: move communications buffers out of stack

[Antonio Ospite]

From: Drew Fisher <drew.m.fisher@gmail.com>

Move large communications buffers out of stack and into device
structure. This prevents the frame size from being >1kB and fixes a
compiler warning when CONFIG_FRAME_WARN=1024:

drivers/media/video/gspca/kinect.c: In function ‘send_cmd.clone.0’:
drivers/media/video/gspca/kinect.c:202: warning: the frame size of 1548 bytes is larger than 1024 bytes

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Drew Fisher <drew.m.fisher@gmail.com>
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 drivers/media/video/gspca/kinect.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
index f85e746..79c4ef5 100644
--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -62,6 +62,8 @@ struct sd {
 	struct gspca_dev gspca_dev; /* !! must be the first item */
 	uint16_t cam_tag;           /* a sequence number for packets */
 	uint8_t stream_flag;        /* to identify different steram types */
+	uint8_t obuf[0x400];        /* output buffer for control commands */
+	uint8_t ibuf[0x200];        /* input buffer for control commands */
 };
 
 /* V4L2 controls supported by the driver */
@@ -133,8 +135,8 @@ static int send_cmd(struct gspca_dev *gspca_dev, uint16_t cmd, void *cmdbuf,
 	struct sd *sd = (struct sd *) gspca_dev;
 	struct usb_device *udev = gspca_dev->dev;
 	int res, actual_len;
-	uint8_t obuf[0x400];
-	uint8_t ibuf[0x200];
+	uint8_t *obuf = sd->obuf;
+	uint8_t *ibuf = sd->ibuf;
 	struct cam_hdr *chdr = (void *)obuf;
 	struct cam_hdr *rhdr = (void *)ibuf;
 
-- 
1.7.4.4

[PATCH 2/3] gspca - kinect: fix a typo s/steram/stream/

[Antonio Ospite]

From: Drew Fisher <drew.m.fisher@gmail.com>

Signed-off-by: Drew Fisher <drew.m.fisher@gmail.com>
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 drivers/media/video/gspca/kinect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
index 79c4ef5..b4f9e2b 100644
--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -61,7 +61,7 @@ struct cam_hdr {
 struct sd {
 	struct gspca_dev gspca_dev; /* !! must be the first item */
 	uint16_t cam_tag;           /* a sequence number for packets */
-	uint8_t stream_flag;        /* to identify different steram types */
+	uint8_t stream_flag;        /* to identify different stream types */
 	uint8_t obuf[0x400];        /* output buffer for control commands */
 	uint8_t ibuf[0x200];        /* input buffer for control commands */
 };
-- 
1.7.4.4

[PATCH 3/3] gspca - kinect: fix comments referring to color camera

[Antonio Ospite]

Use the expression "video stream" instead of "color camera" which is
more correct as the driver supports the RGB and IR image on the same
endpoint.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 drivers/media/video/gspca/kinect.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
index b4f9e2b..2028c64 100644
--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -233,7 +233,7 @@ static int sd_config(struct gspca_dev *gspca_dev,
 
 	sd->cam_tag = 0;
 
-	/* Only color camera is supported for now,
+	/* Only video stream is supported for now,
 	 * which has stream flag = 0x80 */
 	sd->stream_flag = 0x80;
 
@@ -243,7 +243,7 @@ static int sd_config(struct gspca_dev *gspca_dev,
 	cam->nmodes = ARRAY_SIZE(video_camera_mode);
 
 #if 0
-	/* Setting those values is not needed for color camera */
+	/* Setting those values is not needed for video stream */
 	cam->npkt = 15;
 	gspca_dev->pkt_size = 960 * 2;
 #endif
-- 
1.7.4.4

[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Jean-Francois Moine]

The following changes since commit
f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:

  [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

Jean-François Moine (10):
      gspca - cpia1: Fix some warnings.
      gspca - kinect: Remove __devinitdata
      gspca - stk014 / t613: Accept the index 0 in querymenu
      gspca - main: Version change to 2.13
      gspca - main: Remove USB traces
      gspca - cpia1: Remove a bad conditional compilation instruction
      gspca: Unset debug by default
      gspca: Fix some warnings tied to 'no debug'
      gspca - sunplus: Simplify code and fix some warnings
      gspca - sunplus: Simplify code and fix some errors when 'debug'

 drivers/media/video/gspca/cpia1.c       |    6 +--
 drivers/media/video/gspca/gl860/gl860.c |   15 +----
 drivers/media/video/gspca/gspca.c       |    4 +-
 drivers/media/video/gspca/gspca.h       |    6 +-
 drivers/media/video/gspca/kinect.c      |    2 +-
 drivers/media/video/gspca/spca508.c     |    5 +-
 drivers/media/video/gspca/stk014.c      |   15 ++---
 drivers/media/video/gspca/sunplus.c     |   99 ++++++++++--------------------
 drivers/media/video/gspca/t613.c        |   17 ++----
 drivers/media/video/gspca/zc3xx.c       |    5 +-
 10 files changed, 61 insertions(+), 113 deletions(-)

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Antonio Ospite]

On Tue, 17 May 2011 10:54:17 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> The following changes since commit
> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:
> 
>   [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
> 
[...]

Hi Jean-Francois, sometimes it is useful to add also a "why" section to
commit messages so others can follow your thoughts, and even learn from
them.

I have this very simple scheme: a summary of the "what" goes into the
short commit message and the "why" and "how" go into the long commit
message when they are not immediately trivial from the code; for
instance the "why" of the USB trace changes in this series wasn't
trivial to me.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Mauro Carvalho Chehab]

Em 17-05-2011 06:36, Antonio Ospite escreveu:
> On Tue, 17 May 2011 10:54:17 +0200
> Jean-Francois Moine <moinejf@free.fr> wrote:
> 
>> The following changes since commit
>> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:
>>
>>   [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)
>>
>> are available in the git repository at:
>>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
>>
> [...]
> 
> Hi Jean-Francois, sometimes it is useful to add also a "why" section to
> commit messages so others can follow your thoughts, and even learn from
> them.
> 
> I have this very simple scheme: a summary of the "what" goes into the
> short commit message and the "why" and "how" go into the long commit
> message when they are not immediately trivial from the code; for
> instance the "why" of the USB trace changes in this series wasn't
> trivial to me.

Yeah, providing a good documentation is important to allow the others to know what's
happening at the driver.

Jean-Francois,

Could you please add more comments to your patch series? I'll discard this pull
request from my queue. So, feel free to re-base your tree if you need.

Thanks,
Mauro

[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Jean-Francois Moine]

The following changes since commit
f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:

  [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

Jean-François Moine (9):
      gspca - cpia1: Fix some warnings.
      gspca - kinect: Remove __devinitdata
      gspca - stk014 / t613: Accept the index 0 in querymenu
      gspca - main: Version change to 2.13
      gspca - main: Remove USB traces
      gspca - cpia1: Remove a bad conditional compilation instruction
      gspca: Unset debug by default
      gspca: Fix some warnings tied to 'no debug'
      gspca - sunplus: Fix some warnings and simplify code

 drivers/media/video/gspca/cpia1.c       |    6 +--
 drivers/media/video/gspca/gl860/gl860.c |   15 +----
 drivers/media/video/gspca/gspca.c       |    4 +-
 drivers/media/video/gspca/gspca.h       |    6 +-
 drivers/media/video/gspca/kinect.c      |    2 +-
 drivers/media/video/gspca/spca508.c     |    5 +-
 drivers/media/video/gspca/stk014.c      |   15 ++---
 drivers/media/video/gspca/sunplus.c     |   99 ++++++++++--------------------
 drivers/media/video/gspca/t613.c        |   17 ++----
 drivers/media/video/gspca/zc3xx.c       |    5 +-
 10 files changed, 61 insertions(+), 113 deletions(-)

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

On Sat, 21 May 2011 08:59:33 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> The following changes since commit
> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:
> 
>   [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
> 
> Jean-François Moine (9):
[...]
>       gspca - main: Remove USB traces

OK, now I got it, thanks a lot :)

BTW there are still a lot of messages using D_USBI and D_USBO in gspca
subdrivers which are now muted unconditionally  by that change, however
I notice that they are mostly about telling what registers and values
are being set and got, we could call that "device specific" messages and
they are kind of independent form the USB transport indeed; do you
think it is worth to have a new debug level to replace D_USB{I,O} in
order to keep those messages? I am not sure about the name tho: D_COMM,
D_DEV, D_REGS, D_IC, D_HW?

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Mauro Carvalho Chehab]

Em 21-05-2011 03:59, Jean-Francois Moine escreveu:
> The following changes since commit
> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:
> 
>   [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

It is a way better! Thanks for the comments.

Applied, thanks!
Mauro

[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Jean-Francois Moine]

The following changes since commit
87cf028f3aa1ed51fe29c36df548aa714dc7438f:

  [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_v2.6.40

Jean-François Moine (6):
      gspca - ov519: Fix a regression for ovfx2 webcams
      gspca - ov519: Change the ovfx2 bulk transfer size
      gspca: Remove coarse_expo_autogain.h
      gspca - stv06xx: Set a lower default value of gain for hdcs sensors
      gspca - ov519: New sensor ov9600 with bridge ovfx2
      gspca - ov519: Set the default frame rate to 15 fps

 drivers/media/video/gspca/coarse_expo_autogain.h |  116 ---------------------
 drivers/media/video/gspca/ov519.c                |  117 ++++++++++++++++++---
 drivers/media/video/gspca/stv06xx/stv06xx_hdcs.h |    2 +-
 3 files changed, 101 insertions(+), 134 deletions(-)
 delete mode 100644 drivers/media/video/gspca/coarse_expo_autogain.h

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: [GIT PATCHES FOR 2.6.40] gspca for_v2.6.40

[Mauro Carvalho Chehab]

Em 23-05-2011 06:20, Jean-Francois Moine escreveu:
> The following changes since commit
> 87cf028f3aa1ed51fe29c36df548aa714dc7438f:
> 
>   [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_v2.6.40
> 
> Jean-François Moine (6):
>       gspca - ov519: Fix a regression for ovfx2 webcams
>       gspca - ov519: Change the ovfx2 bulk transfer size
>       gspca: Remove coarse_expo_autogain.h
>       gspca - stv06xx: Set a lower default value of gain for hdcs sensors
>       gspca - ov519: Set the default frame rate to 15 fps

The above seems to be bug fixes. So, I'm adding them for the current
version (Linux 3.0).

>       gspca - ov519: New sensor ov9600 with bridge ovfx2

This one is a new feature. Adding it for -next.

All patches added.

Thanks,
Mauro