public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: stefan.ringel@arcor.de
Cc: linux-media@vger.kernel.org, d.belimov@gmail.com
Subject: Re: [PATCH 1/5] tm6000: add mts parameter
Date: Tue, 19 Apr 2011 18:21:22 -0300	[thread overview]
Message-ID: <4DADFCD2.1090401@redhat.com> (raw)
In-Reply-To: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de>

Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
> From: Stefan Ringel <stefan.ringel@arcor.de>
> 
> add mts parameter

Stefan,

The MTS config depends on the specific board design (generally present on
mono NTSC cards). So, it should be inside the cards struct, and not 
provided as an userspace parameter.

Mauro.
> 
> 
> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
> ---
>  drivers/staging/tm6000/tm6000-cards.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
> index 146c7e8..eef58da 100644
> --- a/drivers/staging/tm6000/tm6000-cards.c
> +++ b/drivers/staging/tm6000/tm6000-cards.c
> @@ -61,6 +61,10 @@ module_param_array(card,  int, NULL, 0444);
>  
>  static unsigned long tm6000_devused;
>  
> +static unsigned int xc2028_mts;
> +module_param(xc2028_mts, int, 0644);
> +MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
> +
>  
>  struct tm6000_board {
>  	char            *name;
> @@ -685,6 +689,9 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>  		ctl.demod = XC3028_FE_ZARLINK456;
>  		ctl.vhfbw7 = 1;
>  		ctl.uhfbw8 = 1;
> +		if (xc2028_mts)
> +			ctl.mts = 1;
> +
>  		xc2028_cfg.tuner = TUNER_XC2028;
>  		xc2028_cfg.priv  = &ctl;
>  


  parent reply	other threads:[~2011-04-19 21:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04 20:18 [PATCH 1/5] tm6000: add mts parameter stefan.ringel
2011-04-04 20:18 ` [PATCH 2/5] tm6000: add dtv78 parameter stefan.ringel
2011-04-19 21:22   ` Mauro Carvalho Chehab
2011-04-20  8:36     ` Stefan Ringel
     [not found]     ` <4DAE96F8.2070307@arcor.de>
     [not found]       ` <4DAED3E0.2030606@redhat.com>
2011-04-20 14:30         ` Stefan Ringel
2011-05-03 10:04           ` Mauro Carvalho Chehab
2011-05-03 16:37             ` Stefan Ringel
2011-04-04 20:18 ` [PATCH 3/5] tm6000: add audio mode parameter stefan.ringel
2011-04-19 21:26   ` Mauro Carvalho Chehab
2011-04-20  8:36     ` Stefan Ringel
2011-05-03 10:07       ` Mauro Carvalho Chehab
2011-05-03 14:25         ` Stefan Ringel arcor
2011-05-03 14:42           ` Mauro Carvalho Chehab
2011-05-03 14:52             ` Stefan Ringel
2011-05-03 15:02               ` Stefan Ringel
2011-04-04 20:18 ` [PATCH 4/5] tm6000: add kernel module desciption stefan.ringel
2011-04-04 20:18 ` [PATCH 5/5] tm6000: add CARDLIST stefan.ringel
2011-04-19 21:21 ` Mauro Carvalho Chehab [this message]
2011-04-20  8:14   ` [PATCH 1/5] tm6000: add mts parameter Stefan Ringel
2011-04-20 12:37     ` Mauro Carvalho Chehab
2011-04-20 14:19       ` Stefan Ringel
2011-04-20 15:17         ` Mauro Carvalho Chehab
2011-04-20 15:27           ` Stefan Ringel
2011-04-20 16:16             ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DADFCD2.1090401@redhat.com \
    --to=mchehab@redhat.com \
    --cc=d.belimov@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=stefan.ringel@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox