[PATCH 1/5] tm6000: add mts parameter

[PATCH 1/5] tm6000: add mts parameter

[stefan.ringel]

From: Stefan Ringel <stefan.ringel@arcor.de>

add mts parameter


Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
---
 drivers/staging/tm6000/tm6000-cards.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
index 146c7e8..eef58da 100644
--- a/drivers/staging/tm6000/tm6000-cards.c
+++ b/drivers/staging/tm6000/tm6000-cards.c
@@ -61,6 +61,10 @@ module_param_array(card,  int, NULL, 0444);
 
 static unsigned long tm6000_devused;
 
+static unsigned int xc2028_mts;
+module_param(xc2028_mts, int, 0644);
+MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
+
 
 struct tm6000_board {
 	char            *name;
@@ -685,6 +689,9 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
 		ctl.demod = XC3028_FE_ZARLINK456;
 		ctl.vhfbw7 = 1;
 		ctl.uhfbw8 = 1;
+		if (xc2028_mts)
+			ctl.mts = 1;
+
 		xc2028_cfg.tuner = TUNER_XC2028;
 		xc2028_cfg.priv  = &ctl;
 
-- 
1.7.3.4

[PATCH 2/5] tm6000: add dtv78 parameter

[stefan.ringel]

From: Stefan Ringel <stefan.ringel@arcor.de>

add dtv78 parameter


Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
---
 drivers/staging/tm6000/tm6000-cards.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
index eef58da..cf2e76c 100644
--- a/drivers/staging/tm6000/tm6000-cards.c
+++ b/drivers/staging/tm6000/tm6000-cards.c
@@ -65,6 +65,9 @@ static unsigned int xc2028_mts;
 module_param(xc2028_mts, int, 0644);
 MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
 
+static unsigned int xc2028_dtv78;
+module_param(xc2028_dtv78, int, 0644);
+MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)");
 
 struct tm6000_board {
 	char            *name;
@@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
 		ctl.read_not_reliable = 0;
 		ctl.msleep = 10;
 		ctl.demod = XC3028_FE_ZARLINK456;
-		ctl.vhfbw7 = 1;
-		ctl.uhfbw8 = 1;
+
+		if (xc2028_dtv78) {
+			ctl.vhfbw7 = 1;
+			ctl.uhfbw8 = 1;
+		}
+
 		if (xc2028_mts)
 			ctl.mts = 1;
 
-- 
1.7.3.4

Re: [PATCH 2/5] tm6000: add dtv78 parameter

[Mauro Carvalho Chehab]

Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
> From: Stefan Ringel <stefan.ringel@arcor.de>
> 
> add dtv78 parameter

The dtv78 entry is a hack meant for card usage in Australia, that
speeds up channel detection there. Again, it should be specified
only when needed, and at per-board basis.
> 
> 
> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
> ---
>  drivers/staging/tm6000/tm6000-cards.c |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
> index eef58da..cf2e76c 100644
> --- a/drivers/staging/tm6000/tm6000-cards.c
> +++ b/drivers/staging/tm6000/tm6000-cards.c
> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts;
>  module_param(xc2028_mts, int, 0644);
>  MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
>  
> +static unsigned int xc2028_dtv78;
> +module_param(xc2028_dtv78, int, 0644);
> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)");
>  
>  struct tm6000_board {
>  	char            *name;
> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>  		ctl.read_not_reliable = 0;
>  		ctl.msleep = 10;
>  		ctl.demod = XC3028_FE_ZARLINK456;
> -		ctl.vhfbw7 = 1;
> -		ctl.uhfbw8 = 1;
> +
> +		if (xc2028_dtv78) {
> +			ctl.vhfbw7 = 1;
> +			ctl.uhfbw8 = 1;
> +		}
> +
>  		if (xc2028_mts)
>  			ctl.mts = 1;
>  

Re: [PATCH 2/5] tm6000: add dtv78 parameter

[Stefan Ringel]

Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab:
> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>
>> add dtv78 parameter
> The dtv78 entry is a hack meant for card usage in Australia, that
> speeds up channel detection there. Again, it should be specified
> only when needed, and at per-board basis.
I have test and auto detect doesn't work right. That is also region 
specific staff and it's better to set outside. In other words in Germany 
it must set this param and in other country, which use only 7MHz or 8MHz 
it doesn't set (i.e. Australia).
>>
>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>> ---
>>   drivers/staging/tm6000/tm6000-cards.c |   11 +++++++++--
>>   1 files changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
>> index eef58da..cf2e76c 100644
>> --- a/drivers/staging/tm6000/tm6000-cards.c
>> +++ b/drivers/staging/tm6000/tm6000-cards.c
>> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts;
>>   module_param(xc2028_mts, int, 0644);
>>   MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
>>
>> +static unsigned int xc2028_dtv78;
>> +module_param(xc2028_dtv78, int, 0644);
>> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)");
>>
>>   struct tm6000_board {
>>   	char            *name;
>> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>>   		ctl.read_not_reliable = 0;
>>   		ctl.msleep = 10;
>>   		ctl.demod = XC3028_FE_ZARLINK456;
>> -		ctl.vhfbw7 = 1;
>> -		ctl.uhfbw8 = 1;
>> +
>> +		if (xc2028_dtv78) {
>> +			ctl.vhfbw7 = 1;
>> +			ctl.uhfbw8 = 1;
>> +		}
>> +
>>   		if (xc2028_mts)
>>   			ctl.mts = 1;
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] tm6000: add dtv78 parameter

[Stefan Ringel]

Am 20.04.2011 14:38, schrieb Mauro Carvalho Chehab:
> Em 20-04-2011 05:19, Stefan Ringel escreveu:
>> Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab:
>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>
>>>> add dtv78 parameter
>>> The dtv78 entry is a hack meant for card usage in Australia, that
>>> speeds up channel detection there. Again, it should be specified
>>> only when needed, and at per-board basis.
>> I have test and auto detect doesn't work right. That is also region
>> specific staff and it's better to set outside. In other words in Germany
>> it must set this param and in other country, which use only 7MHz or 8MHz it doesn't set (i.e. Australia).
> xc3028 has a logic to detect and work on both Australia and Europe.
> If that logic is broken, we should fix it, not adding a manual
> parameter for it.
>
It positively a bug. When I use lower band (7MHz, load DTV7 SCODE) it 
doesn't work, then I go in the high band (8MHz, load DTV78, DTV8 SCODE) 
and have channels and can watch TV. If I go now in the lower band (7MHz, 
don't reload SCODE) it works. This effect is for me a bug.
>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>> ---
>>>>    drivers/staging/tm6000/tm6000-cards.c |   11 +++++++++--
>>>>    1 files changed, 9 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
>>>> index eef58da..cf2e76c 100644
>>>> --- a/drivers/staging/tm6000/tm6000-cards.c
>>>> +++ b/drivers/staging/tm6000/tm6000-cards.c
>>>> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts;
>>>>    module_param(xc2028_mts, int, 0644);
>>>>    MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
>>>>
>>>> +static unsigned int xc2028_dtv78;
>>>> +module_param(xc2028_dtv78, int, 0644);
>>>> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)");
>>>>
>>>>    struct tm6000_board {
>>>>        char            *name;
>>>> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>>>>            ctl.read_not_reliable = 0;
>>>>            ctl.msleep = 10;
>>>>            ctl.demod = XC3028_FE_ZARLINK456;
>>>> -        ctl.vhfbw7 = 1;
>>>> -        ctl.uhfbw8 = 1;
>>>> +
>>>> +        if (xc2028_dtv78) {
>>>> +            ctl.vhfbw7 = 1;
>>>> +            ctl.uhfbw8 = 1;
>>>> +        }
>>>> +
>>>>            if (xc2028_mts)
>>>>                ctl.mts = 1;
>>>>
>>> -- 
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] tm6000: add dtv78 parameter

[Mauro Carvalho Chehab]

Em 20-04-2011 11:30, Stefan Ringel escreveu:
> Am 20.04.2011 14:38, schrieb Mauro Carvalho Chehab:
>> Em 20-04-2011 05:19, Stefan Ringel escreveu:
>>> Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab:
>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>
>>>>> add dtv78 parameter
>>>> The dtv78 entry is a hack meant for card usage in Australia, that
>>>> speeds up channel detection there. Again, it should be specified
>>>> only when needed, and at per-board basis.
>>> I have test and auto detect doesn't work right. That is also region
>>> specific staff and it's better to set outside. In other words in Germany
>>> it must set this param and in other country, which use only 7MHz or 8MHz it doesn't set (i.e. Australia).
>> xc3028 has a logic to detect and work on both Australia and Europe.
>> If that logic is broken, we should fix it, not adding a manual
>> parameter for it.
>>
> It positively a bug. When I use lower band (7MHz, load DTV7 SCODE) it doesn't work, then I go in the high band (8MHz, load DTV78, DTV8 SCODE) and have channels and can watch TV. If I go now in the lower band (7MHz, don't reload SCODE) it works. This effect is for me a bug.

The fix for it should be at xc3028. Please propose a patch for it. Maybe we should add there
a parameter for auto-detection, or to force it to use dtv78, if bandwith is > 6MHz.


>>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>>> ---
>>>>>    drivers/staging/tm6000/tm6000-cards.c |   11 +++++++++--
>>>>>    1 files changed, 9 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
>>>>> index eef58da..cf2e76c 100644
>>>>> --- a/drivers/staging/tm6000/tm6000-cards.c
>>>>> +++ b/drivers/staging/tm6000/tm6000-cards.c
>>>>> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts;
>>>>>    module_param(xc2028_mts, int, 0644);
>>>>>    MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
>>>>>
>>>>> +static unsigned int xc2028_dtv78;
>>>>> +module_param(xc2028_dtv78, int, 0644);
>>>>> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)");
>>>>>
>>>>>    struct tm6000_board {
>>>>>        char            *name;
>>>>> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>>>>>            ctl.read_not_reliable = 0;
>>>>>            ctl.msleep = 10;
>>>>>            ctl.demod = XC3028_FE_ZARLINK456;
>>>>> -        ctl.vhfbw7 = 1;
>>>>> -        ctl.uhfbw8 = 1;
>>>>> +
>>>>> +        if (xc2028_dtv78) {
>>>>> +            ctl.vhfbw7 = 1;
>>>>> +            ctl.uhfbw8 = 1;
>>>>> +        }
>>>>> +
>>>>>            if (xc2028_mts)
>>>>>                ctl.mts = 1;
>>>>>
>>>> -- 
>>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] tm6000: add dtv78 parameter

[Stefan Ringel]

Am 03.05.2011 12:04, schrieb Mauro Carvalho Chehab:
> Em 20-04-2011 11:30, Stefan Ringel escreveu:
>> Am 20.04.2011 14:38, schrieb Mauro Carvalho Chehab:
>>> Em 20-04-2011 05:19, Stefan Ringel escreveu:
>>>> Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab:
>>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>>
>>>>>> add dtv78 parameter
>>>>> The dtv78 entry is a hack meant for card usage in Australia, that
>>>>> speeds up channel detection there. Again, it should be specified
>>>>> only when needed, and at per-board basis.
>>>> I have test and auto detect doesn't work right. That is also region
>>>> specific staff and it's better to set outside. In other words in Germany
>>>> it must set this param and in other country, which use only 7MHz or 8MHz it doesn't set (i.e. Australia).
>>> xc3028 has a logic to detect and work on both Australia and Europe.
>>> If that logic is broken, we should fix it, not adding a manual
>>> parameter for it.
>>>
>> It positively a bug. When I use lower band (7MHz, load DTV7 SCODE) it doesn't work, then I go in the high band (8MHz, load DTV78, DTV8 SCODE) and have channels and can watch TV. If I go now in the lower band (7MHz, don't reload SCODE) it works. This effect is for me a bug.
> The fix for it should be at xc3028. Please propose a patch for it. Maybe we should add there
> a parameter for auto-detection, or to force it to use dtv78, if bandwith is>  6MHz.
>
>
The last I have scanned and used in auto mode was last year. And now 
work fine :-) . When have you change the code?
>>>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>> ---
>>>>>>     drivers/staging/tm6000/tm6000-cards.c |   11 +++++++++--
>>>>>>     1 files changed, 9 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
>>>>>> index eef58da..cf2e76c 100644
>>>>>> --- a/drivers/staging/tm6000/tm6000-cards.c
>>>>>> +++ b/drivers/staging/tm6000/tm6000-cards.c
>>>>>> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts;
>>>>>>     module_param(xc2028_mts, int, 0644);
>>>>>>     MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
>>>>>>
>>>>>> +static unsigned int xc2028_dtv78;
>>>>>> +module_param(xc2028_dtv78, int, 0644);
>>>>>> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)");
>>>>>>
>>>>>>     struct tm6000_board {
>>>>>>         char            *name;
>>>>>> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>>>>>>             ctl.read_not_reliable = 0;
>>>>>>             ctl.msleep = 10;
>>>>>>             ctl.demod = XC3028_FE_ZARLINK456;
>>>>>> -        ctl.vhfbw7 = 1;
>>>>>> -        ctl.uhfbw8 = 1;
>>>>>> +
>>>>>> +        if (xc2028_dtv78) {
>>>>>> +            ctl.vhfbw7 = 1;
>>>>>> +            ctl.uhfbw8 = 1;
>>>>>> +        }
>>>>>> +
>>>>>>             if (xc2028_mts)
>>>>>>                 ctl.mts = 1;
>>>>>>
>>>>> -- 
>>>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>>>> the body of a message to majordomo@vger.kernel.org
>>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/5] tm6000: add audio mode parameter

[stefan.ringel]

From: Stefan Ringel <stefan.ringel@arcor.de>

add audio mode parameter


Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
---
 drivers/staging/tm6000/tm6000-stds.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
index da3e51b..a9e1921 100644
--- a/drivers/staging/tm6000/tm6000-stds.c
+++ b/drivers/staging/tm6000/tm6000-stds.c
@@ -22,12 +22,17 @@
 #include "tm6000.h"
 #include "tm6000-regs.h"
 
+static unsigned int tm6010_a_mode;
+module_param(tm6010_a_mode, int, 0644);
+MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
+
 struct tm6000_reg_settings {
 	unsigned char req;
 	unsigned char reg;
 	unsigned char value;
 };
 
+/* must be updated */
 enum tm6000_audio_std {
 	BG_NICAM,
 	BTSC,
-- 
1.7.3.4

Re: [PATCH 3/5] tm6000: add audio mode parameter

[Mauro Carvalho Chehab]

Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
> From: Stefan Ringel <stefan.ringel@arcor.de>
> 
> add audio mode parameter

Why we need a parameter for it? It should be determined based on
the standard.

> 
> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
> ---
>  drivers/staging/tm6000/tm6000-stds.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
> index da3e51b..a9e1921 100644
> --- a/drivers/staging/tm6000/tm6000-stds.c
> +++ b/drivers/staging/tm6000/tm6000-stds.c
> @@ -22,12 +22,17 @@
>  #include "tm6000.h"
>  #include "tm6000-regs.h"
>  
> +static unsigned int tm6010_a_mode;
> +module_param(tm6010_a_mode, int, 0644);
> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
> +
>  struct tm6000_reg_settings {
>  	unsigned char req;
>  	unsigned char reg;
>  	unsigned char value;
>  };
>  
> +/* must be updated */
>  enum tm6000_audio_std {
>  	BG_NICAM,
>  	BTSC,

Re: [PATCH 3/5] tm6000: add audio mode parameter

[Stefan Ringel]

Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab:
> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>
>> add audio mode parameter
> Why we need a parameter for it? It should be determined based on
> the standard.
>
tm6010 has a sif decoder, and I think if auto detect doesn't work, use 
can set the audio standard, which it has in your region. Or it's better 
if users can see image but can hear audio?
>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>> ---
>>   drivers/staging/tm6000/tm6000-stds.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
>> index da3e51b..a9e1921 100644
>> --- a/drivers/staging/tm6000/tm6000-stds.c
>> +++ b/drivers/staging/tm6000/tm6000-stds.c
>> @@ -22,12 +22,17 @@
>>   #include "tm6000.h"
>>   #include "tm6000-regs.h"
>>
>> +static unsigned int tm6010_a_mode;
>> +module_param(tm6010_a_mode, int, 0644);
>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
>> +
>>   struct tm6000_reg_settings {
>>   	unsigned char req;
>>   	unsigned char reg;
>>   	unsigned char value;
>>   };
>>
>> +/* must be updated */
>>   enum tm6000_audio_std {
>>   	BG_NICAM,
>>   	BTSC,

Re: [PATCH 3/5] tm6000: add audio mode parameter

[Mauro Carvalho Chehab]

Em 20-04-2011 05:36, Stefan Ringel escreveu:
> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab:
>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>
>>> add audio mode parameter
>> Why we need a parameter for it? It should be determined based on
>> the standard.
>>
> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio?

I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with
my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio
decoding.

>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>> ---
>>>   drivers/staging/tm6000/tm6000-stds.c |    5 +++++
>>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
>>> index da3e51b..a9e1921 100644
>>> --- a/drivers/staging/tm6000/tm6000-stds.c
>>> +++ b/drivers/staging/tm6000/tm6000-stds.c
>>> @@ -22,12 +22,17 @@
>>>   #include "tm6000.h"
>>>   #include "tm6000-regs.h"
>>>
>>> +static unsigned int tm6010_a_mode;
>>> +module_param(tm6010_a_mode, int, 0644);
>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
>>> +
>>>   struct tm6000_reg_settings {
>>>       unsigned char req;
>>>       unsigned char reg;
>>>       unsigned char value;
>>>   };
>>>
>>> +/* must be updated */
>>>   enum tm6000_audio_std {
>>>       BG_NICAM,
>>>       BTSC,
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] tm6000: add audio mode parameter

[Stefan Ringel arcor]

Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab:
> Em 20-04-2011 05:36, Stefan Ringel escreveu:
>> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab:
>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>
>>>> add audio mode parameter
>>> Why we need a parameter for it? It should be determined based on
>>> the standard.
>>>
>> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio?
> I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with
> my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio
> decoding.
>
In the next patch I will send it. A preview I have send to be test (
https://patchwork.kernel.org/patch/722021/ ).
>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>> ---
>>>>   drivers/staging/tm6000/tm6000-stds.c |    5 +++++
>>>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
>>>> index da3e51b..a9e1921 100644
>>>> --- a/drivers/staging/tm6000/tm6000-stds.c
>>>> +++ b/drivers/staging/tm6000/tm6000-stds.c
>>>> @@ -22,12 +22,17 @@
>>>>   #include "tm6000.h"
>>>>   #include "tm6000-regs.h"
>>>>
>>>> +static unsigned int tm6010_a_mode;
>>>> +module_param(tm6010_a_mode, int, 0644);
>>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
>>>> +
>>>>   struct tm6000_reg_settings {
>>>>       unsigned char req;
>>>>       unsigned char reg;
>>>>       unsigned char value;
>>>>   };
>>>>
>>>> +/* must be updated */
>>>>   enum tm6000_audio_std {
>>>>       BG_NICAM,
>>>>       BTSC,
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] tm6000: add audio mode parameter

[Mauro Carvalho Chehab]

Em 03-05-2011 11:25, Stefan Ringel arcor escreveu:
> Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab:
>> Em 20-04-2011 05:36, Stefan Ringel escreveu:
>>> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab:
>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>
>>>>> add audio mode parameter
>>>> Why we need a parameter for it? It should be determined based on
>>>> the standard.
>>>>
>>> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio?
>> I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with
>> my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio
>> decoding.
>>
> In the next patch I will send it. A preview I have send to be test (
> https://patchwork.kernel.org/patch/722021/ ).

I tested your preview. Didn't make any difference.

>>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>>> ---
>>>>>   drivers/staging/tm6000/tm6000-stds.c |    5 +++++
>>>>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
>>>>> index da3e51b..a9e1921 100644
>>>>> --- a/drivers/staging/tm6000/tm6000-stds.c
>>>>> +++ b/drivers/staging/tm6000/tm6000-stds.c
>>>>> @@ -22,12 +22,17 @@
>>>>>   #include "tm6000.h"
>>>>>   #include "tm6000-regs.h"
>>>>>
>>>>> +static unsigned int tm6010_a_mode;
>>>>> +module_param(tm6010_a_mode, int, 0644);
>>>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
>>>>> +
>>>>>   struct tm6000_reg_settings {
>>>>>       unsigned char req;
>>>>>       unsigned char reg;
>>>>>       unsigned char value;
>>>>>   };
>>>>>
>>>>> +/* must be updated */
>>>>>   enum tm6000_audio_std {
>>>>>       BG_NICAM,
>>>>>       BTSC,
>>> -- 
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 3/5] tm6000: add audio mode parameter

[Stefan Ringel]

Am 03.05.2011 16:42, schrieb Mauro Carvalho Chehab:
> Em 03-05-2011 11:25, Stefan Ringel arcor escreveu:
>> Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab:
>>> Em 20-04-2011 05:36, Stefan Ringel escreveu:
>>>> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab:
>>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>>
>>>>>> add audio mode parameter
>>>>> Why we need a parameter for it? It should be determined based on
>>>>> the standard.
>>>>>
>>>> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio?
>>> I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with
>>> my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio
>>> decoding.
>>>
>> In the next patch I will send it. A preview I have send to be test (
>> https://patchwork.kernel.org/patch/722021/ ).
> I tested your preview. Didn't make any difference.
Has you test with all setting variants? (BG_A2 works auto and A2 audio 
mode).
>>>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>> ---
>>>>>>    drivers/staging/tm6000/tm6000-stds.c |    5 +++++
>>>>>>    1 files changed, 5 insertions(+), 0 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
>>>>>> index da3e51b..a9e1921 100644
>>>>>> --- a/drivers/staging/tm6000/tm6000-stds.c
>>>>>> +++ b/drivers/staging/tm6000/tm6000-stds.c
>>>>>> @@ -22,12 +22,17 @@
>>>>>>    #include "tm6000.h"
>>>>>>    #include "tm6000-regs.h"
>>>>>>
>>>>>> +static unsigned int tm6010_a_mode;
>>>>>> +module_param(tm6010_a_mode, int, 0644);
>>>>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
>>>>>> +
>>>>>>    struct tm6000_reg_settings {
>>>>>>        unsigned char req;
>>>>>>        unsigned char reg;
>>>>>>        unsigned char value;
>>>>>>    };
>>>>>>
>>>>>> +/* must be updated */
>>>>>>    enum tm6000_audio_std {
>>>>>>        BG_NICAM,
>>>>>>        BTSC,
>>>> -- 
>>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] tm6000: add audio mode parameter

[Stefan Ringel]

Am 03.05.2011 16:52, schrieb Stefan Ringel:
> Am 03.05.2011 16:42, schrieb Mauro Carvalho Chehab:
>> Em 03-05-2011 11:25, Stefan Ringel arcor escreveu:
>>> Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab:
>>>> Em 20-04-2011 05:36, Stefan Ringel escreveu:
>>>>> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab:
>>>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>>>
>>>>>>> add audio mode parameter
>>>>>> Why we need a parameter for it? It should be determined based on
>>>>>> the standard.
>>>>>>
>>>>> tm6010 has a sif decoder, and I think if auto detect doesn't work, 
>>>>> use can set the audio standard, which it has in your region. Or 
>>>>> it's better if users can see image but can hear audio?
>>>> I did some tests with SIF and MTS here. None of them were capable 
>>>> of working with BTSC signals with
>>>> my devices. Adding a parameter won't help it at all. What we need 
>>>> to do is to fix the audio
>>>> decoding.
>>>>
>>> In the next patch I will send it. A preview I have send to be test (
>>> https://patchwork.kernel.org/patch/722021/ ).
>> I tested your preview. Didn't make any difference.
> Has you test with all setting variants? (BG_A2 works auto and A2 audio 
> mode).
I use mplayer, and have in the first use the wrong parameter. Now I know 
the right parameter for mplayer:

mplayer -vc rawyuy2 -ac pcm -ao alsa:device=hw=0.0 -tv 
driver=v4l2:device=/dev/video2:input=0:outfmt=yv12:freq=210.25:normid=3:alsa:adevice=hw.2,0:amode=1:immediatemode=0 
-fs tv://
>>>>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>>> ---
>>>>>>>    drivers/staging/tm6000/tm6000-stds.c |    5 +++++
>>>>>>>    1 files changed, 5 insertions(+), 0 deletions(-)
>>>>>>>
>>>>>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c 
>>>>>>> b/drivers/staging/tm6000/tm6000-stds.c
>>>>>>> index da3e51b..a9e1921 100644
>>>>>>> --- a/drivers/staging/tm6000/tm6000-stds.c
>>>>>>> +++ b/drivers/staging/tm6000/tm6000-stds.c
>>>>>>> @@ -22,12 +22,17 @@
>>>>>>>    #include "tm6000.h"
>>>>>>>    #include "tm6000-regs.h"
>>>>>>>
>>>>>>> +static unsigned int tm6010_a_mode;
>>>>>>> +module_param(tm6010_a_mode, int, 0644);
>>>>>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 
>>>>>>> only)");
>>>>>>> +
>>>>>>>    struct tm6000_reg_settings {
>>>>>>>        unsigned char req;
>>>>>>>        unsigned char reg;
>>>>>>>        unsigned char value;
>>>>>>>    };
>>>>>>>
>>>>>>> +/* must be updated */
>>>>>>>    enum tm6000_audio_std {
>>>>>>>        BG_NICAM,
>>>>>>>        BTSC,
>>>>> -- 
>>>>> To unsubscribe from this list: send the line "unsubscribe 
>>>>> linux-media" in
>>>>> the body of a message to majordomo@vger.kernel.org
>>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe 
>> linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/5] tm6000: add kernel module desciption

[stefan.ringel]

From: Stefan Ringel <stefan.ringel@arcor.de>

add kernel module desciption


Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
---
 drivers/staging/tm6000/README |   40 ++++++++++++++++++++++++++++++++++++++++
 1 files changed, 40 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/tm6000/README b/drivers/staging/tm6000/README
index c340ebc..48e8d9b 100644
--- a/drivers/staging/tm6000/README
+++ b/drivers/staging/tm6000/README
@@ -1,3 +1,43 @@
+tm6000
+======
+
+You will only use analogue tv, you must additionally load tm6000_alsa. 
+You will only use digital tv, you must additionally load tm6000_dvb.
+For both must load tm6000, tm6000_alsa and tm6000_dvb.
+
+Kernel module parameter:
+
+tm6000
+------
+debug:
+i2c_debug:
+ir_debug:
+card : see CARDLIST
+enable_ir: enable infrared
+    0 -> disable
+    1 -> enable (default)
+tm6010_a_mode: set audio mode (tm6010 only)
+    0 -> auto
+    1 -> A2
+    2 -> NICAM
+    3 -> BTSC
+    etc.
+xc2028_mts: enable mts firmware (xc2028/3028 only)
+    0 -> disable (default)
+    1 -> enable mts firmware
+xc2028_dtv78: set dualband (xc2028/3028 only)
+    0 -> singleband/auto (default) i.e. dtv7 only
+    1 -> dualband
+
+tm6000_alsa
+-----------
+debug: enable debug information
+
+tm6000_dvb
+----------
+debug: enable debug information
+
+
 Todo:
 	- Fix the loss of some blocks when receiving the video URB's
 	- Add a lock at tm6000_read_write_usb() to prevent two simultaneous access to the
-- 
1.7.3.4

[PATCH 5/5] tm6000: add CARDLIST

[stefan.ringel]

From: Stefan Ringel <stefan.ringel@arcor.de>

add CARDLIST


Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
---
 drivers/staging/tm6000/CARDLIST |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 drivers/staging/tm6000/CARDLIST

diff --git a/drivers/staging/tm6000/CARDLIST b/drivers/staging/tm6000/CARDLIST
new file mode 100644
index 0000000..b5edce4
--- /dev/null
+++ b/drivers/staging/tm6000/CARDLIST
@@ -0,0 +1,16 @@
+  1 -> Generic tm5600 board                   (tm5600)          [6000:0001]
+  2 -> Generic tm6000 board                   (tm6000)          [6000:0001]
+  3 -> Generic tm6010 board                   (tm6010)          [6000:0002]
+  4 -> 10Moons UT821                          (tm5600)          [6000:0001]
+  5 -> 10Moons UT330                          (tm5600)
+  6 -> ADSTech Dual TV                        (tm6000)          [06e1:f332]
+  7 -> FreeCom and similar                    (tm6000)          [14aa:0620]
+  8 -> ADSTech Mini Dual TV                   (tm6000)          [06e1:b339]
+  9 -> Hauppauge WinTV HVR-900H/USB2 Stick    (tm6010)          [2040:6600,2040:6601,2040:6610,2040:6611]
+ 10 -> Beholder Wander                        (tm6010)          [6000:dec0]
+ 11 -> Beholder Voyager                       (tm6010)          [6000:dec1]
+ 12 -> TerraTec Cinergy Hybrid XE/Cinergy Hybrid Stick (tm6010) [0ccd:0086,0ccd:00a5]
+ 13 -> TwinHan TU501                          (tm6010)          [13d3:3240,13d3:3241,13d3:3243,13d3:3264]
+ 14 -> Beholder Wander Lite                   (tm6010)          [6000:dec2]
+ 15 -> Beholder Voyager Lite                  (tm6010)          [6000:dec3]
+
-- 
1.7.3.4

Re: [PATCH 1/5] tm6000: add mts parameter

[Mauro Carvalho Chehab]

Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
> From: Stefan Ringel <stefan.ringel@arcor.de>
> 
> add mts parameter

Stefan,

The MTS config depends on the specific board design (generally present on
mono NTSC cards). So, it should be inside the cards struct, and not 
provided as an userspace parameter.

Mauro.
> 
> 
> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
> ---
>  drivers/staging/tm6000/tm6000-cards.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
> index 146c7e8..eef58da 100644
> --- a/drivers/staging/tm6000/tm6000-cards.c
> +++ b/drivers/staging/tm6000/tm6000-cards.c
> @@ -61,6 +61,10 @@ module_param_array(card,  int, NULL, 0444);
>  
>  static unsigned long tm6000_devused;
>  
> +static unsigned int xc2028_mts;
> +module_param(xc2028_mts, int, 0644);
> +MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
> +
>  
>  struct tm6000_board {
>  	char            *name;
> @@ -685,6 +689,9 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>  		ctl.demod = XC3028_FE_ZARLINK456;
>  		ctl.vhfbw7 = 1;
>  		ctl.uhfbw8 = 1;
> +		if (xc2028_mts)
> +			ctl.mts = 1;
> +
>  		xc2028_cfg.tuner = TUNER_XC2028;
>  		xc2028_cfg.priv  = &ctl;
>  

Re: [PATCH 1/5] tm6000: add mts parameter

[Stefan Ringel]

Am 19.04.2011 23:21, schrieb Mauro Carvalho Chehab:
> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>
>> add mts parameter
> Stefan,
>
> The MTS config depends on the specific board design (generally present on
> mono NTSC cards). So, it should be inside the cards struct, and not
> provided as an userspace parameter.
>
> Mauro.
No. It wrong. I think edge board must work under all region and TV 
standards and if I set MTS, it doesn't work in Germany (PAL_BG and 
DVB-T). The best is to set outside region specific params.
>> .
>>
>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>> ---
>>   drivers/staging/tm6000/tm6000-cards.c |    7 +++++++
>>   1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
>> index 146c7e8..eef58da 100644
>> --- a/drivers/staging/tm6000/tm6000-cards.c
>> +++ b/drivers/staging/tm6000/tm6000-cards.c
>> @@ -61,6 +61,10 @@ module_param_array(card,  int, NULL, 0444);
>>
>>   static unsigned long tm6000_devused;
>>
>> +static unsigned int xc2028_mts;
>> +module_param(xc2028_mts, int, 0644);
>> +MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
>> +
>>
>>   struct tm6000_board {
>>   	char            *name;
>> @@ -685,6 +689,9 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>>   		ctl.demod = XC3028_FE_ZARLINK456;
>>   		ctl.vhfbw7 = 1;
>>   		ctl.uhfbw8 = 1;
>> +		if (xc2028_mts)
>> +			ctl.mts = 1;
>> +
>>   		xc2028_cfg.tuner = TUNER_XC2028;
>>   		xc2028_cfg.priv  =&ctl;
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] tm6000: add mts parameter

[Mauro Carvalho Chehab]

Em 20-04-2011 05:14, Stefan Ringel escreveu:
> Am 19.04.2011 23:21, schrieb Mauro Carvalho Chehab:
>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>
>>> add mts parameter
>> Stefan,
>>
>> The MTS config depends on the specific board design (generally present on
>> mono NTSC cards). So, it should be inside the cards struct, and not
>> provided as an userspace parameter.
>>
>> Mauro.
> No. It wrong. I think edge board must work under all region and TV standards and if I set MTS, it doesn't work in Germany (PAL_BG and DVB-T). The best is to set outside region specific params.

Stefan,

Not all boards have MTS wired. Also, MTS works only for BTSC and EIAJ,
e. g. STD M/N. The SIF output works for all standards, depending of the audio
decoder capabilities, and if the SIF is properly wired. AFAIK, tm5600/6000/tm6010 
is a worldwide decoder, so if SIF is wired, it should be capable of also decoding
BTSC, EIAJ and the other sound standards found elsewhere.

In other words, boards shipped outside NTSC or PAL-M Countries use SIF and supports
worldwide standards. however, most boards shipped in US with xc3028 have only
MTS wired and won't work outside NTSC/PAL-M/PAL-N area (America, Japan and a few
other places).

>>> .
>>>
>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>> ---
>>>   drivers/staging/tm6000/tm6000-cards.c |    7 +++++++
>>>   1 files changed, 7 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
>>> index 146c7e8..eef58da 100644
>>> --- a/drivers/staging/tm6000/tm6000-cards.c
>>> +++ b/drivers/staging/tm6000/tm6000-cards.c
>>> @@ -61,6 +61,10 @@ module_param_array(card,  int, NULL, 0444);
>>>
>>>   static unsigned long tm6000_devused;
>>>
>>> +static unsigned int xc2028_mts;
>>> +module_param(xc2028_mts, int, 0644);
>>> +MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
>>> +
>>>
>>>   struct tm6000_board {
>>>       char            *name;
>>> @@ -685,6 +689,9 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>>>           ctl.demod = XC3028_FE_ZARLINK456;
>>>           ctl.vhfbw7 = 1;
>>>           ctl.uhfbw8 = 1;
>>> +        if (xc2028_mts)
>>> +            ctl.mts = 1;
>>> +
>>>           xc2028_cfg.tuner = TUNER_XC2028;
>>>           xc2028_cfg.priv  =&ctl;
>>>
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 1/5] tm6000: add mts parameter

[Stefan Ringel]

Am 20.04.2011 14:37, schrieb Mauro Carvalho Chehab:
> Em 20-04-2011 05:14, Stefan Ringel escreveu:
>> Am 19.04.2011 23:21, schrieb Mauro Carvalho Chehab:
>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>
>>>> add mts parameter
>>> Stefan,
>>>
>>> The MTS config depends on the specific board design (generally present on
>>> mono NTSC cards). So, it should be inside the cards struct, and not
>>> provided as an userspace parameter.
>>>
>>> Mauro.
>> No. It wrong. I think edge board must work under all region and TV standards and if I set MTS, it doesn't work in Germany (PAL_BG and DVB-T). The best is to set outside region specific params.
> Stefan,
>
> Not all boards have MTS wired.
standard option that param is not auto.
MTS = 0 or not set means load firmware without MTS.
MTS = 1 means load firmware with MTS.
That means, if you MTS then add a param MTS=1.
Have you other method to detect norm BTSC and EIAJ and set it? I have 
not that.
> Also, MTS works only for BTSC and EIAJ,
> e. g. STD M/N. The SIF output works for all standards, depending of the audio
> decoder capabilities, and if the SIF is properly wired. AFAIK, tm5600/6000/tm6010
> is a worldwide decoder, so if SIF is wired, it should be capable of also decoding
> BTSC, EIAJ and the other sound standards found elsewhere.
>
> In other words, boards shipped outside NTSC or PAL-M Countries use SIF and supports
> worldwide standards. however, most boards shipped in US with xc3028 have only
> MTS wired and won't work outside NTSC/PAL-M/PAL-N area (America, Japan and a few
> other places).
>
Which board is only MTS?

Which board is only no MTS?

Which board will both?
>>>> .
>>>>
>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>> ---
>>>>    drivers/staging/tm6000/tm6000-cards.c |    7 +++++++
>>>>    1 files changed, 7 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c
>>>> index 146c7e8..eef58da 100644
>>>> --- a/drivers/staging/tm6000/tm6000-cards.c
>>>> +++ b/drivers/staging/tm6000/tm6000-cards.c
>>>> @@ -61,6 +61,10 @@ module_param_array(card,  int, NULL, 0444);
>>>>
>>>>    static unsigned long tm6000_devused;
>>>>
>>>> +static unsigned int xc2028_mts;
>>>> +module_param(xc2028_mts, int, 0644);
>>>> +MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)");
>>>> +
>>>>
>>>>    struct tm6000_board {
>>>>        char            *name;
>>>> @@ -685,6 +689,9 @@ static void tm6000_config_tuner(struct tm6000_core *dev)
>>>>            ctl.demod = XC3028_FE_ZARLINK456;
>>>>            ctl.vhfbw7 = 1;
>>>>            ctl.uhfbw8 = 1;
>>>> +        if (xc2028_mts)
>>>> +            ctl.mts = 1;
>>>> +
>>>>            xc2028_cfg.tuner = TUNER_XC2028;
>>>>            xc2028_cfg.priv  =&ctl;
>>>>
>>> -- 
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] tm6000: add mts parameter

[Mauro Carvalho Chehab]

Em 20-04-2011 11:19, Stefan Ringel escreveu:
> Am 20.04.2011 14:37, schrieb Mauro Carvalho Chehab:
>> Em 20-04-2011 05:14, Stefan Ringel escreveu:
>>> Am 19.04.2011 23:21, schrieb Mauro Carvalho Chehab:
>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>
>>>>> add mts parameter
>>>> Stefan,
>>>>
>>>> The MTS config depends on the specific board design (generally present on
>>>> mono NTSC cards). So, it should be inside the cards struct, and not
>>>> provided as an userspace parameter.
>>>>
>>>> Mauro.
>>> No. It wrong. I think edge board must work under all region and TV standards and if I set MTS, it doesn't work in Germany (PAL_BG and DVB-T). The best is to set outside region specific params.
>> Stefan,
>>
>> Not all boards have MTS wired.
> standard option that param is not auto.
> MTS = 0 or not set means load firmware without MTS.
> MTS = 1 means load firmware with MTS.
> That means, if you MTS then add a param MTS=1.
> Have you other method to detect norm BTSC and EIAJ and set it? I have not that.

Yes. Audio standard is related to video standard. So, it is easy to map on what
standards you have BTSC or EIAJ.

You could find that info listed on some places, like:
	http://www.videouniversity.com/articles/world-wide-tv-standards
	http://en.wikipedia.org/wiki/BTSC
and on good analog TV books.

Basically, BTSC/EIAJ applies only to PAL/M, PAL/N and NTSC/M. So, if the standard is
not PAL/MN, mts should always be equal to 0. We may have a patch at tuner-xc2028 for that.

If standard is V4L_STD_MN, we have:

For NTSC standards:
	if standard == V4L2_STD_NTSC_M_KR, audio is A2 (Korea) and mts should be 0.
	if standard == V4L2_STD_NTSC_M_JP, audio is EIAJ (Japan).
	All the rest use BTSC (or are mono, but the BTSC decoder is designed to be
backward compatible with NTSC mono FM transmission).

For PAL:
	V4L2_STD_PAL_M - always BTSC
	V4L2_STD_PAL_Nc (only Argentina) - always BTSC
	V4L2_STD_PAL_N  (Paraguay/Uruguay) - they also use FM for audio. I think it is also BTSC.

So, basically, assuming that some device could potentiallt have both SIF and MTS baseband 
wired and that the audio decoder is not capable of decoding EIAJ/BTSC, it makes sense to 
add something like this at tuner-xc2028:

/* MTS is only valid for M/N standars, except in Korea */
if (!(std & V4L2_STD_MN) || (std == V4L2_STD_NTSC_M_KR))
	mts = 0;

and, for such device, specify xc2028 with mts = 1.

For devices that support only mts, it makes sense to change the supported standards to
just V4L2_STD_MN.

However, we cannot assume that (std & V4L2_STD_MN) && (std != V4L2_STD_NTSC_M_KR) is always
mts, as it will depend on how xc2028/xc3028 is wired to the bridge/audio demod.

>> Also, MTS works only for BTSC and EIAJ,
>> e. g. STD M/N. The SIF output works for all standards, depending of the audio
>> decoder capabilities, and if the SIF is properly wired. AFAIK, tm5600/6000/tm6010
>> is a worldwide decoder, so if SIF is wired, it should be capable of also decoding
>> BTSC, EIAJ and the other sound standards found elsewhere.
>>
>> In other words, boards shipped outside NTSC or PAL-M Countries use SIF and supports
>> worldwide standards. however, most boards shipped in US with xc3028 have only
>> MTS wired and won't work outside NTSC/PAL-M/PAL-N area (America, Japan and a few
>> other places).
>>
> Which board is only MTS?

Developers need to test, but, based on my experience with other xc3028/2028 devices, 
in general, the ones sold in US are only MTS.

> Which board is only no MTS?
> Which board will both?

Except if the tm5600/tm6000 SIF decoder for BTSC/EIAJ is broken, we don't
need to map the differences between only SIF and SIF + MTS.

All boards sold in Europe should support SIF, so mts should be 0 for them.

Mauro.

Re: [PATCH 1/5] tm6000: add mts parameter

[Stefan Ringel]

Am 20.04.2011 17:17, schrieb Mauro Carvalho Chehab:
> Em 20-04-2011 11:19, Stefan Ringel escreveu:
>> Am 20.04.2011 14:37, schrieb Mauro Carvalho Chehab:
>>> Em 20-04-2011 05:14, Stefan Ringel escreveu:
>>>> Am 19.04.2011 23:21, schrieb Mauro Carvalho Chehab:
>>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>>
>>>>>> add mts parameter
>>>>> Stefan,
>>>>>
>>>>> The MTS config depends on the specific board design (generally present on
>>>>> mono NTSC cards). So, it should be inside the cards struct, and not
>>>>> provided as an userspace parameter.
>>>>>
>>>>> Mauro.
>>>> No. It wrong. I think edge board must work under all region and TV standards and if I set MTS, it doesn't work in Germany (PAL_BG and DVB-T). The best is to set outside region specific params.
>>> Stefan,
>>>
>>> Not all boards have MTS wired.
>> standard option that param is not auto.
>> MTS = 0 or not set means load firmware without MTS.
>> MTS = 1 means load firmware with MTS.
>> That means, if you MTS then add a param MTS=1.
>> Have you other method to detect norm BTSC and EIAJ and set it? I have not that.
> Yes. Audio standard is related to video standard. So, it is easy to map on what
> standards you have BTSC or EIAJ.
>
> You could find that info listed on some places, like:
> 	http://www.videouniversity.com/articles/world-wide-tv-standards
> 	http://en.wikipedia.org/wiki/BTSC
> and on good analog TV books.
>
> Basically, BTSC/EIAJ applies only to PAL/M, PAL/N and NTSC/M. So, if the standard is
> not PAL/MN, mts should always be equal to 0. We may have a patch at tuner-xc2028 for that.
>
> If standard is V4L_STD_MN, we have:
>
> For NTSC standards:
> 	if standard == V4L2_STD_NTSC_M_KR, audio is A2 (Korea) and mts should be 0.
> 	if standard == V4L2_STD_NTSC_M_JP, audio is EIAJ (Japan).
> 	All the rest use BTSC (or are mono, but the BTSC decoder is designed to be
> backward compatible with NTSC mono FM transmission).
>
> For PAL:
> 	V4L2_STD_PAL_M - always BTSC
> 	V4L2_STD_PAL_Nc (only Argentina) - always BTSC
> 	V4L2_STD_PAL_N  (Paraguay/Uruguay) - they also use FM for audio. I think it is also BTSC.
>
> So, basically, assuming that some device could potentiallt have both SIF and MTS baseband
> wired and that the audio decoder is not capable of decoding EIAJ/BTSC, it makes sense to
> add something like this at tuner-xc2028:
>
> /* MTS is only valid for M/N standars, except in Korea */
> if (!(std&  V4L2_STD_MN) || (std == V4L2_STD_NTSC_M_KR))
> 	mts = 0;
>
> and, for such device, specify xc2028 with mts = 1.
>
> For devices that support only mts, it makes sense to change the supported standards to
> just V4L2_STD_MN.
>
> However, we cannot assume that (std&  V4L2_STD_MN)&&  (std != V4L2_STD_NTSC_M_KR) is always
> mts, as it will depend on how xc2028/xc3028 is wired to the bridge/audio demod.
>
Is that better to use no mts parameter and always mts = 0?
>>> Also, MTS works only for BTSC and EIAJ,
>>> e. g. STD M/N. The SIF output works for all standards, depending of the audio
>>> decoder capabilities, and if the SIF is properly wired. AFAIK, tm5600/6000/tm6010
>>> is a worldwide decoder, so if SIF is wired, it should be capable of also decoding
>>> BTSC, EIAJ and the other sound standards found elsewhere.
>>>
>>> In other words, boards shipped outside NTSC or PAL-M Countries use SIF and supports
>>> worldwide standards. however, most boards shipped in US with xc3028 have only
>>> MTS wired and won't work outside NTSC/PAL-M/PAL-N area (America, Japan and a few
>>> other places).
>>>
>> Which board is only MTS?
> Developers need to test, but, based on my experience with other xc3028/2028 devices,
> in general, the ones sold in US are only MTS.
>
>> Which board is only no MTS?
>> Which board will both?
> Except if the tm5600/tm6000 SIF decoder for BTSC/EIAJ is broken, we don't
> need to map the differences between only SIF and SIF + MTS.
>
> All boards sold in Europe should support SIF, so mts should be 0 for them.
>
> Mauro.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] tm6000: add mts parameter

[Mauro Carvalho Chehab]

Em 20-04-2011 12:27, Stefan Ringel escreveu:
> Am 20.04.2011 17:17, schrieb Mauro Carvalho Chehab:
>> Em 20-04-2011 11:19, Stefan Ringel escreveu:
>>> Am 20.04.2011 14:37, schrieb Mauro Carvalho Chehab:
>>>> Em 20-04-2011 05:14, Stefan Ringel escreveu:
>>>>> Am 19.04.2011 23:21, schrieb Mauro Carvalho Chehab:
>>>>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>>>>
>>>>>>> add mts parameter
>>>>>> Stefan,
>>>>>>
>>>>>> The MTS config depends on the specific board design (generally present on
>>>>>> mono NTSC cards). So, it should be inside the cards struct, and not
>>>>>> provided as an userspace parameter.
>>>>>>
>>>>>> Mauro.
>>>>> No. It wrong. I think edge board must work under all region and TV standards and if I set MTS, it doesn't work in Germany (PAL_BG and DVB-T). The best is to set outside region specific params.
>>>> Stefan,
>>>>
>>>> Not all boards have MTS wired.
>>> standard option that param is not auto.
>>> MTS = 0 or not set means load firmware without MTS.
>>> MTS = 1 means load firmware with MTS.
>>> That means, if you MTS then add a param MTS=1.
>>> Have you other method to detect norm BTSC and EIAJ and set it? I have not that.
>> Yes. Audio standard is related to video standard. So, it is easy to map on what
>> standards you have BTSC or EIAJ.
>>
>> You could find that info listed on some places, like:
>>     http://www.videouniversity.com/articles/world-wide-tv-standards
>>     http://en.wikipedia.org/wiki/BTSC
>> and on good analog TV books.
>>
>> Basically, BTSC/EIAJ applies only to PAL/M, PAL/N and NTSC/M. So, if the standard is
>> not PAL/MN, mts should always be equal to 0. We may have a patch at tuner-xc2028 for that.
>>
>> If standard is V4L_STD_MN, we have:
>>
>> For NTSC standards:
>>     if standard == V4L2_STD_NTSC_M_KR, audio is A2 (Korea) and mts should be 0.
>>     if standard == V4L2_STD_NTSC_M_JP, audio is EIAJ (Japan).
>>     All the rest use BTSC (or are mono, but the BTSC decoder is designed to be
>> backward compatible with NTSC mono FM transmission).
>>
>> For PAL:
>>     V4L2_STD_PAL_M - always BTSC
>>     V4L2_STD_PAL_Nc (only Argentina) - always BTSC
>>     V4L2_STD_PAL_N  (Paraguay/Uruguay) - they also use FM for audio. I think it is also BTSC.
>>
>> So, basically, assuming that some device could potentiallt have both SIF and MTS baseband
>> wired and that the audio decoder is not capable of decoding EIAJ/BTSC, it makes sense to
>> add something like this at tuner-xc2028:
>>
>> /* MTS is only valid for M/N standars, except in Korea */
>> if (!(std&  V4L2_STD_MN) || (std == V4L2_STD_NTSC_M_KR))
>>     mts = 0;
>>
>> and, for such device, specify xc2028 with mts = 1.
>>
>> For devices that support only mts, it makes sense to change the supported standards to
>> just V4L2_STD_MN.
>>
>> However, we cannot assume that (std&  V4L2_STD_MN)&&  (std != V4L2_STD_NTSC_M_KR) is always
>> mts, as it will depend on how xc2028/xc3028 is wired to the bridge/audio demod.
>>
> Is that better to use no mts parameter and always mts = 0?

No. The better is to use a per-board mts parameter, as we have on all other drivers
that use xc2028/xc3028.

Mauro.