From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-in-08.arcor-online.net ([151.189.21.48]:58098 "EHLO mail-in-08.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785Ab1DTIOL (ORCPT ); Wed, 20 Apr 2011 04:14:11 -0400 Message-ID: <4DAE95CE.4020705@arcor.de> Date: Wed, 20 Apr 2011 10:14:06 +0200 From: Stefan Ringel MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org, d.belimov@gmail.com Subject: Re: [PATCH 1/5] tm6000: add mts parameter References: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de> <4DADFCD2.1090401@redhat.com> In-Reply-To: <4DADFCD2.1090401@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-ID: Sender: Am 19.04.2011 23:21, schrieb Mauro Carvalho Chehab: > Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >> From: Stefan Ringel >> >> add mts parameter > Stefan, > > The MTS config depends on the specific board design (generally present on > mono NTSC cards). So, it should be inside the cards struct, and not > provided as an userspace parameter. > > Mauro. No. It wrong. I think edge board must work under all region and TV standards and if I set MTS, it doesn't work in Germany (PAL_BG and DVB-T). The best is to set outside region specific params. >> . >> >> Signed-off-by: Stefan Ringel >> --- >> drivers/staging/tm6000/tm6000-cards.c | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c >> index 146c7e8..eef58da 100644 >> --- a/drivers/staging/tm6000/tm6000-cards.c >> +++ b/drivers/staging/tm6000/tm6000-cards.c >> @@ -61,6 +61,10 @@ module_param_array(card, int, NULL, 0444); >> >> static unsigned long tm6000_devused; >> >> +static unsigned int xc2028_mts; >> +module_param(xc2028_mts, int, 0644); >> +MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)"); >> + >> >> struct tm6000_board { >> char *name; >> @@ -685,6 +689,9 @@ static void tm6000_config_tuner(struct tm6000_core *dev) >> ctl.demod = XC3028_FE_ZARLINK456; >> ctl.vhfbw7 = 1; >> ctl.uhfbw8 = 1; >> + if (xc2028_mts) >> + ctl.mts = 1; >> + >> xc2028_cfg.tuner = TUNER_XC2028; >> xc2028_cfg.priv =&ctl; >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html