Re: [PATCH 3/5] tm6000: add audio mode parameter

[Stefan Ringel <stefan.ringel@arcor.de>]

Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab:
> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>
>> add audio mode parameter
> Why we need a parameter for it? It should be determined based on
> the standard.
>
tm6010 has a sif decoder, and I think if auto detect doesn't work, use 
can set the audio standard, which it has in your region. Or it's better 
if users can see image but can hear audio?
>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>> ---
>>   drivers/staging/tm6000/tm6000-stds.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
>> index da3e51b..a9e1921 100644
>> --- a/drivers/staging/tm6000/tm6000-stds.c
>> +++ b/drivers/staging/tm6000/tm6000-stds.c
>> @@ -22,12 +22,17 @@
>>   #include "tm6000.h"
>>   #include "tm6000-regs.h"
>>
>> +static unsigned int tm6010_a_mode;
>> +module_param(tm6010_a_mode, int, 0644);
>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
>> +
>>   struct tm6000_reg_settings {
>>   	unsigned char req;
>>   	unsigned char reg;
>>   	unsigned char value;
>>   };
>>
>> +/* must be updated */
>>   enum tm6000_audio_std {
>>   	BG_NICAM,
>>   	BTSC,