From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-in-15.arcor-online.net ([151.189.21.55]:33770 "EHLO mail-in-15.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839Ab1DTIgS (ORCPT ); Wed, 20 Apr 2011 04:36:18 -0400 Message-ID: <4DAE9B00.7050404@arcor.de> Date: Wed, 20 Apr 2011 10:36:16 +0200 From: Stefan Ringel MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org, d.belimov@gmail.com Subject: Re: [PATCH 3/5] tm6000: add audio mode parameter References: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de> <1301948324-27186-3-git-send-email-stefan.ringel@arcor.de> <4DADFDF1.9020108@redhat.com> In-Reply-To: <4DADFDF1.9020108@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-ID: Sender: Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab: > Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >> From: Stefan Ringel >> >> add audio mode parameter > Why we need a parameter for it? It should be determined based on > the standard. > tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio? >> Signed-off-by: Stefan Ringel >> --- >> drivers/staging/tm6000/tm6000-stds.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c >> index da3e51b..a9e1921 100644 >> --- a/drivers/staging/tm6000/tm6000-stds.c >> +++ b/drivers/staging/tm6000/tm6000-stds.c >> @@ -22,12 +22,17 @@ >> #include "tm6000.h" >> #include "tm6000-regs.h" >> >> +static unsigned int tm6010_a_mode; >> +module_param(tm6010_a_mode, int, 0644); >> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); >> + >> struct tm6000_reg_settings { >> unsigned char req; >> unsigned char reg; >> unsigned char value; >> }; >> >> +/* must be updated */ >> enum tm6000_audio_std { >> BG_NICAM, >> BTSC,