From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-in-14.arcor-online.net ([151.189.21.54]:50617 "EHLO mail-in-14.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839Ab1DTIg7 (ORCPT ); Wed, 20 Apr 2011 04:36:59 -0400 Message-ID: <4DAE9B29.1040301@arcor.de> Date: Wed, 20 Apr 2011 10:36:57 +0200 From: Stefan Ringel MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org, d.belimov@gmail.com Subject: Re: [PATCH 2/5] tm6000: add dtv78 parameter References: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de> <1301948324-27186-2-git-send-email-stefan.ringel@arcor.de> <4DADFD31.1010200@redhat.com> In-Reply-To: <4DADFD31.1010200@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-ID: Sender: Am 19.04.2011 23:22, schrieb Mauro Carvalho Chehab: > Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >> From: Stefan Ringel >> >> add dtv78 parameter > The dtv78 entry is a hack meant for card usage in Australia, that > speeds up channel detection there. Again, it should be specified > only when needed, and at per-board basis. I have test and auto detect doesn't work right. That is also region specific staff and it's better to set outside. In other words in Germany it must set this param and in other country, which use only 7MHz or 8MHz it doesn't set (i.e. Australia). >> >> Signed-off-by: Stefan Ringel >> --- >> drivers/staging/tm6000/tm6000-cards.c | 11 +++++++++-- >> 1 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/tm6000/tm6000-cards.c b/drivers/staging/tm6000/tm6000-cards.c >> index eef58da..cf2e76c 100644 >> --- a/drivers/staging/tm6000/tm6000-cards.c >> +++ b/drivers/staging/tm6000/tm6000-cards.c >> @@ -65,6 +65,9 @@ static unsigned int xc2028_mts; >> module_param(xc2028_mts, int, 0644); >> MODULE_PARM_DESC(xc2028_mts, "enable mts firmware (xc2028/3028 only)"); >> >> +static unsigned int xc2028_dtv78; >> +module_param(xc2028_dtv78, int, 0644); >> +MODULE_PARM_DESC(xc2028_dtv78, "enable dualband config (xc2028/3028 only)"); >> >> struct tm6000_board { >> char *name; >> @@ -687,8 +690,12 @@ static void tm6000_config_tuner(struct tm6000_core *dev) >> ctl.read_not_reliable = 0; >> ctl.msleep = 10; >> ctl.demod = XC3028_FE_ZARLINK456; >> - ctl.vhfbw7 = 1; >> - ctl.uhfbw8 = 1; >> + >> + if (xc2028_dtv78) { >> + ctl.vhfbw7 = 1; >> + ctl.uhfbw8 = 1; >> + } >> + >> if (xc2028_mts) >> ctl.mts = 1; >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html