Re: [git:v4l-dvb/for_v2.6.40] [media] gspca - kinect: move communications buffers out of stack

Re: [git:v4l-dvb/for_v2.6.40] [media] gspca - kinect: move communications buffers out of stack

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

On Fri, 29 Apr 2011 16:42:04 +0200
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> This is an automatic generated email to let you know that the following patch were queued at the 
> http://git.linuxtv.org/media_tree.git tree:
> 
> Subject: [media] gspca - kinect: move communications buffers out of stack
> Author:  Antonio Ospite <ospite@studenti.unina.it>
> Date:    Thu Apr 21 06:51:34 2011 -0300
>

Hi Mauro, actually this one is from Drew Fisher as well, git-am should
have picked up the additional From header:
http://www.spinics.net/lists/linux-media/msg31576.html

> Move large communications buffers out of stack and into device
> structure. This prevents the frame size from being >1kB and fixes a
> compiler warning when CONFIG_FRAME_WARN=1024:
> 
> drivers/media/video/gspca/kinect.c: In function ‘send_cmd.clone.0’:
> drivers/media/video/gspca/kinect.c:202: warning: the frame size of 1548 bytes is larger than 1024 bytes
> 
> Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> Signed-off-by: Drew Fisher <drew.m.fisher@gmail.com>
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> 
>  drivers/media/video/gspca/kinect.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [git:v4l-dvb/for_v2.6.40] [media] gspca - kinect: move communications buffers out of stack

[Mauro Carvalho Chehab]

Em 29-04-2011 12:27, Antonio Ospite escreveu:
> On Fri, 29 Apr 2011 16:42:04 +0200
> Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> 
>> This is an automatic generated email to let you know that the following patch were queued at the 
>> http://git.linuxtv.org/media_tree.git tree:
>>
>> Subject: [media] gspca - kinect: move communications buffers out of stack
>> Author:  Antonio Ospite <ospite@studenti.unina.it>
>> Date:    Thu Apr 21 06:51:34 2011 -0300
>>
> 
> Hi Mauro, actually this one is from Drew Fisher as well, git-am should
> have picked up the additional From header:
> http://www.spinics.net/lists/linux-media/msg31576.html

Gah!

Patchwork suffered a crash. Patches got recovered yesterday, but all of them missed
the e-mail body:
	https://patchwork.kernel.org/patch/724331/

I'm needing to manually edit each patch before applying due to that.

I'll revert the patch and re-apply it with the proper authorship.

> 
>> Move large communications buffers out of stack and into device
>> structure. This prevents the frame size from being >1kB and fixes a
>> compiler warning when CONFIG_FRAME_WARN=1024:
>>
>> drivers/media/video/gspca/kinect.c: In function ‘send_cmd.clone.0’:
>> drivers/media/video/gspca/kinect.c:202: warning: the frame size of 1548 bytes is larger than 1024 bytes
>>
>> Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>> Signed-off-by: Drew Fisher <drew.m.fisher@gmail.com>
>> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>>  drivers/media/video/gspca/kinect.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
> 

Re: [git:v4l-dvb/for_v2.6.40] [media] gspca - kinect: move communications buffers out of stack

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

On Fri, 29 Apr 2011 12:43:55 -0300
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> Em 29-04-2011 12:27, Antonio Ospite escreveu:
> > On Fri, 29 Apr 2011 16:42:04 +0200
> > Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> > 
> >> This is an automatic generated email to let you know that the following patch were queued at the 
> >> http://git.linuxtv.org/media_tree.git tree:
> >>
> >> Subject: [media] gspca - kinect: move communications buffers out of stack
> >> Author:  Antonio Ospite <ospite@studenti.unina.it>
> >> Date:    Thu Apr 21 06:51:34 2011 -0300
> >>
> > 
> > Hi Mauro, actually this one is from Drew Fisher as well, git-am should
> > have picked up the additional From header:
> > http://www.spinics.net/lists/linux-media/msg31576.html
> 
> Gah!
> 
> Patchwork suffered a crash. Patches got recovered yesterday, but all of them missed
> the e-mail body:
> 	https://patchwork.kernel.org/patch/724331/
> 
> I'm needing to manually edit each patch before applying due to that.
>

Just FYI, gmane stores a raw representation of messages which can be
used with git-am, take:
http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/31735
and add /raw at the end of the URL.

> I'll revert the patch and re-apply it with the proper authorship.
> 

Thanks a lot.

Best regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [git:v4l-dvb/for_v2.6.40] [media] gspca - kinect: move communications buffers out of stack

[Mauro Carvalho Chehab]

Em 29-04-2011 13:16, Antonio Ospite escreveu:
> On Fri, 29 Apr 2011 12:43:55 -0300
> Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> 
>> Em 29-04-2011 12:27, Antonio Ospite escreveu:
>>> On Fri, 29 Apr 2011 16:42:04 +0200
>>> Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>>>
>>>> This is an automatic generated email to let you know that the following patch were queued at the 
>>>> http://git.linuxtv.org/media_tree.git tree:
>>>>
>>>> Subject: [media] gspca - kinect: move communications buffers out of stack
>>>> Author:  Antonio Ospite <ospite@studenti.unina.it>
>>>> Date:    Thu Apr 21 06:51:34 2011 -0300
>>>>
>>>
>>> Hi Mauro, actually this one is from Drew Fisher as well, git-am should
>>> have picked up the additional From header:
>>> http://www.spinics.net/lists/linux-media/msg31576.html
>>
>> Gah!
>>
>> Patchwork suffered a crash. Patches got recovered yesterday, but all of them missed
>> the e-mail body:
>> 	https://patchwork.kernel.org/patch/724331/
>>
>> I'm needing to manually edit each patch before applying due to that.
>>
> 
> Just FYI, gmane stores a raw representation of messages which can be
> used with git-am, take:
> http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/31735
> and add /raw at the end of the URL.

Good to know about the /raw mode of gmane.

I have also my own copy of the patches, but the thing is that the control I use here to know
what patches are still pending is based on patchwork. With pathwork.kernel.org broken,
my legs are also broken :/

After finishing to apply the current stuff there, I intend to think on another process that
won't make me dependent on a software/hardware where I cannot rely on it, nor fix the issues
directly. So, I'm thinking on abandoning the usage of patchwork, but the point is: what other
alternatives are left?

> 
>> I'll revert the patch and re-apply it with the proper authorship.
>>
> 
> Thanks a lot.
> 
> Best regards,
>    Antonio
>