From: Stefan Ringel arcor <stefan.ringel@arcor.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org, d.belimov@gmail.com
Subject: Re: [PATCH 3/5] tm6000: add audio mode parameter
Date: Tue, 03 May 2011 16:25:07 +0200 [thread overview]
Message-ID: <4DC01043.6090309@arcor.de> (raw)
In-Reply-To: <4DBFD3CD.9070008@redhat.com>
Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab:
> Em 20-04-2011 05:36, Stefan Ringel escreveu:
>> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab:
>>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu:
>>>> From: Stefan Ringel<stefan.ringel@arcor.de>
>>>>
>>>> add audio mode parameter
>>> Why we need a parameter for it? It should be determined based on
>>> the standard.
>>>
>> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio?
> I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with
> my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio
> decoding.
>
In the next patch I will send it. A preview I have send to be test (
https://patchwork.kernel.org/patch/722021/ ).
>>>> Signed-off-by: Stefan Ringel<stefan.ringel@arcor.de>
>>>> ---
>>>> drivers/staging/tm6000/tm6000-stds.c | 5 +++++
>>>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
>>>> index da3e51b..a9e1921 100644
>>>> --- a/drivers/staging/tm6000/tm6000-stds.c
>>>> +++ b/drivers/staging/tm6000/tm6000-stds.c
>>>> @@ -22,12 +22,17 @@
>>>> #include "tm6000.h"
>>>> #include "tm6000-regs.h"
>>>>
>>>> +static unsigned int tm6010_a_mode;
>>>> +module_param(tm6010_a_mode, int, 0644);
>>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)");
>>>> +
>>>> struct tm6000_reg_settings {
>>>> unsigned char req;
>>>> unsigned char reg;
>>>> unsigned char value;
>>>> };
>>>>
>>>> +/* must be updated */
>>>> enum tm6000_audio_std {
>>>> BG_NICAM,
>>>> BTSC,
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-03 14:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 20:18 [PATCH 1/5] tm6000: add mts parameter stefan.ringel
2011-04-04 20:18 ` [PATCH 2/5] tm6000: add dtv78 parameter stefan.ringel
2011-04-19 21:22 ` Mauro Carvalho Chehab
2011-04-20 8:36 ` Stefan Ringel
[not found] ` <4DAE96F8.2070307@arcor.de>
[not found] ` <4DAED3E0.2030606@redhat.com>
2011-04-20 14:30 ` Stefan Ringel
2011-05-03 10:04 ` Mauro Carvalho Chehab
2011-05-03 16:37 ` Stefan Ringel
2011-04-04 20:18 ` [PATCH 3/5] tm6000: add audio mode parameter stefan.ringel
2011-04-19 21:26 ` Mauro Carvalho Chehab
2011-04-20 8:36 ` Stefan Ringel
2011-05-03 10:07 ` Mauro Carvalho Chehab
2011-05-03 14:25 ` Stefan Ringel arcor [this message]
2011-05-03 14:42 ` Mauro Carvalho Chehab
2011-05-03 14:52 ` Stefan Ringel
2011-05-03 15:02 ` Stefan Ringel
2011-04-04 20:18 ` [PATCH 4/5] tm6000: add kernel module desciption stefan.ringel
2011-04-04 20:18 ` [PATCH 5/5] tm6000: add CARDLIST stefan.ringel
2011-04-19 21:21 ` [PATCH 1/5] tm6000: add mts parameter Mauro Carvalho Chehab
2011-04-20 8:14 ` Stefan Ringel
2011-04-20 12:37 ` Mauro Carvalho Chehab
2011-04-20 14:19 ` Stefan Ringel
2011-04-20 15:17 ` Mauro Carvalho Chehab
2011-04-20 15:27 ` Stefan Ringel
2011-04-20 16:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC01043.6090309@arcor.de \
--to=stefan.ringel@arcor.de \
--cc=d.belimov@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox