From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-in-02.arcor-online.net ([151.189.21.42]:53103 "EHLO mail-in-02.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073Ab1ECO0p (ORCPT ); Tue, 3 May 2011 10:26:45 -0400 Message-ID: <4DC01043.6090309@arcor.de> Date: Tue, 03 May 2011 16:25:07 +0200 From: Stefan Ringel arcor MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org, d.belimov@gmail.com Subject: Re: [PATCH 3/5] tm6000: add audio mode parameter References: <1301948324-27186-1-git-send-email-stefan.ringel@arcor.de> <1301948324-27186-3-git-send-email-stefan.ringel@arcor.de> <4DADFDF1.9020108@redhat.com> <4DAE9B00.7050404@arcor.de> <4DBFD3CD.9070008@redhat.com> In-Reply-To: <4DBFD3CD.9070008@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-ID: Sender: Am 03.05.2011 12:07, schrieb Mauro Carvalho Chehab: > Em 20-04-2011 05:36, Stefan Ringel escreveu: >> Am 19.04.2011 23:26, schrieb Mauro Carvalho Chehab: >>> Em 04-04-2011 17:18, stefan.ringel@arcor.de escreveu: >>>> From: Stefan Ringel >>>> >>>> add audio mode parameter >>> Why we need a parameter for it? It should be determined based on >>> the standard. >>> >> tm6010 has a sif decoder, and I think if auto detect doesn't work, use can set the audio standard, which it has in your region. Or it's better if users can see image but can hear audio? > I did some tests with SIF and MTS here. None of them were capable of working with BTSC signals with > my devices. Adding a parameter won't help it at all. What we need to do is to fix the audio > decoding. > In the next patch I will send it. A preview I have send to be test ( https://patchwork.kernel.org/patch/722021/ ). >>>> Signed-off-by: Stefan Ringel >>>> --- >>>> drivers/staging/tm6000/tm6000-stds.c | 5 +++++ >>>> 1 files changed, 5 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c >>>> index da3e51b..a9e1921 100644 >>>> --- a/drivers/staging/tm6000/tm6000-stds.c >>>> +++ b/drivers/staging/tm6000/tm6000-stds.c >>>> @@ -22,12 +22,17 @@ >>>> #include "tm6000.h" >>>> #include "tm6000-regs.h" >>>> >>>> +static unsigned int tm6010_a_mode; >>>> +module_param(tm6010_a_mode, int, 0644); >>>> +MODULE_PARM_DESC(tm6010_a_mode, "set sif audio mode (tm6010 only)"); >>>> + >>>> struct tm6000_reg_settings { >>>> unsigned char req; >>>> unsigned char reg; >>>> unsigned char value; >>>> }; >>>> >>>> +/* must be updated */ >>>> enum tm6000_audio_std { >>>> BG_NICAM, >>>> BTSC, >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html