From: Antti Palosaari <crope@iki.fi>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org, Steven Toth <stoth@hauppauge.com>
Subject: Re: [GIT PULL FOR 2.6.40] Anysee
Date: Wed, 04 May 2011 23:36:39 +0300 [thread overview]
Message-ID: <4DC1B8D7.6020701@iki.fi> (raw)
In-Reply-To: <4DC178C8.4040603@redhat.com>
Updated PULL requested!
Cc: Steven Toth as cx24116 driver author.
On 05/04/2011 07:03 PM, Mauro Carvalho Chehab wrote:
> Em 29-04-2011 14:05, Antti Palosaari escreveu:
>> Moikka Mauro,
>>
>> PULL following patches for the 2.6.40.
>>
>> This basically adds support for two Anysee satellite models:
>> 1. E30 S2 Plus
>> 2. E7 S2
>>
>>
>> t. Antti
>>
>> The following changes since commit f5bc5d1d4730bce69fbfdc8949ff50b49c70d934:
>>
>> anysee: add more info about known board configs (2011-04-13 02:17:11 +0300)
>>
>> are available in the git repository at:
>> git://linuxtv.org/anttip/media_tree.git anysee
>>
>> Antti Palosaari (3):
>> cx24116: add config option to split firmware download
>> anysee: add support for Anysee E30 S2 Plus
>> anysee: add support for Anysee E7 S2
>
> As I said you on irc, at cx24116, please add a logic to explicitly check if
> I2C size is equal to zero. While your logic works, it is tricky, and having
> a more readable code at the expense of something like:
> if (i2c_max == 0)
> i2c_max = 65535;
>
> seems to be the right thing to do.
For some reason as I mentioned on IRC, this change increases binary size
52 bytes, whilst functionality remains same. Feel free to select this
new or old patch.
t. Antti
The following changes since commit f5bc5d1d4730bce69fbfdc8949ff50b49c70d934:
anysee: add more info about known board configs (2011-04-13 02:17:11
+0300)
are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git anysee
Antti Palosaari (4):
cx24116: add config option to split firmware download
anysee: add support for Anysee E30 S2 Plus
anysee: add support for Anysee E7 S2
cx24116: make FW DL split more readable
drivers/media/dvb/dvb-usb/Kconfig | 4 +
drivers/media/dvb/dvb-usb/anysee.c | 103
+++++++++++++++++++++++++++++++++
drivers/media/dvb/dvb-usb/anysee.h | 1 +
drivers/media/dvb/frontends/cx24116.c | 19 +++++-
drivers/media/dvb/frontends/cx24116.h | 3 +
5 files changed, 127 insertions(+), 3 deletions(-)
--
http://palosaari.fi/
next prev parent reply other threads:[~2011-05-04 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 17:05 [GIT PULL FOR 2.6.40] Anysee Antti Palosaari
2011-05-04 16:03 ` Mauro Carvalho Chehab
2011-05-04 20:36 ` Antti Palosaari [this message]
2011-05-25 21:43 ` Antti Palosaari
2011-06-01 11:40 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 10:12 Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC1B8D7.6020701@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=stoth@hauppauge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox