public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Issa Gorissen <flop.m@usa.net>
To: Ralph Metzler <rjkm@metzlerbros.de>
Cc: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
	"\"Sébastien RAILLARD (COEXSI)\"" <sr@coexsi.fr>,
	"Oliver Endriss" <o.endriss@gmx.de>
Subject: Re: DVB nGene CI : TS Discontinuities issues
Date: Sun, 08 May 2011 18:44:44 +0200	[thread overview]
Message-ID: <4DC6C87C.1090100@usa.net> (raw)
In-Reply-To: <19909.47855.351946.831380@morden.metzler>

On 07/05/11 23:34, Ralph Metzler wrote:
> Before blaming packet loss on the CI data path also please make
> certain that you have no buffer overflows in the input part of 
> the sec device.
> In the ngene driver you can e.g. add a printk in tsin_exchange():
>
> if (dvb_ringbuffer_free(&dev->tsin_rbuf) > len) {
> ...
> } else
>     printk ("buffer overflow !!!!\n");

Ralph,

void *tsin_exchange(void *priv, void *buf, u32 len, u32 clock, u32 flags)
{
    struct ngene_channel *chan = priv;
    struct ngene *dev = chan->dev;


    if (flags & DF_SWAP32)
        swap_buffer(buf, len);
    if (dev->ci.en && chan->number == 2) {
        if (dvb_ringbuffer_free(&dev->tsin_rbuf) > len) {
            dvb_ringbuffer_write(&dev->tsin_rbuf, buf, len);
            wake_up_interruptible(&dev->tsin_rbuf.queue);
        } else
            printk (KERN_WARNING "ngene transport interface:
tsin_exchange: buffer overflow !!!!\n");

        return 0;
    }
    if (chan->users > 0) {
        dvb_dmx_swfilter(&chan->demux, buf, len);
    }
    return NULL;
}



just prints the buffer overflow warning just after the module is loaded,
no other action made.

  parent reply	other threads:[~2011-05-08 16:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03 10:59 DVB nGene CI : TS Discontinuities issues Sébastien RAILLARD (COEXSI)
2011-05-07 15:15 ` Issa Gorissen
     [not found]   ` <19909.47855.351946.831380@morden.metzler>
2011-05-08 16:44     ` Issa Gorissen [this message]
2011-05-09  0:41     ` Issa Gorissen
2011-05-09  7:04       ` Sébastien RAILLARD (COEXSI)
2011-05-09 20:39         ` Issa Gorissen
  -- strict thread matches above, loose matches on Subject: below --
2011-05-11 13:12 Issa Gorissen
2011-05-11 13:35 ` Sébastien RAILLARD (COEXSI)
2011-05-12 20:40 ` Issa Gorissen
2011-05-13 11:54   ` Ralph Metzler
2012-02-26 17:11     ` Anssi Hannula
2012-02-26 22:14       ` Ralph Metzler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC6C87C.1090100@usa.net \
    --to=flop.m@usa.net \
    --cc=linux-media@vger.kernel.org \
    --cc=o.endriss@gmx.de \
    --cc=rjkm@metzlerbros.de \
    --cc=sr@coexsi.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox