From: Andreas Oberritter <obi@linuxtv.org>
To: Steve Kerrison <steve@stevekerrison.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Antti Palosaari <crope@iki.fi>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 6/6] Documentation: Update to include DVB-T2 additions
Date: Mon, 09 May 2011 00:05:04 +0200 [thread overview]
Message-ID: <4DC71390.404@linuxtv.org> (raw)
In-Reply-To: <1304881988.2920.18.camel@ares>
On 05/08/2011 09:13 PM, Steve Kerrison wrote:
> Hi Mauro
>
>> + <para>3) DVB-T specifies 2K and 8K as valid sizes.</para>
>>> + <para>4) DVB-T2 specifies 1K, 2K, 4K, 8K, 16K and 32K.</para>
>>
>> It makes sense to add here that ISDB-T specifies 2K, 4K and 8K.
>> (yeah, sorry, it is my fault that I didn't notice it before ;) )
>
> Actually note 1) in that list declares the sizes supported by ISDB-T;
> but the patch doesn't show it. So there is no blame to assign :)
>
>> -#define DTV_MAX_COMMAND DTV_ISDBS_TS_ID
>>> +#define DTV_DVBT2_PLP_ID 43
>>> +
>>
>> Please document the PLP_ID as well. Just like ISDB-T, the best seems to
>> create a section with DVB-T2 specific parameters, and add this one there,
>> explaining its meaning.
>
> I have created a section for DVB-T2 parameters. It's within the main
> ISDB-T section. If that's not appropriate I guess it can be hauled out
> as it grows. However, much like Antti, I don't know much about PLP or
> the other features of the T2 specification, so cannot contribute a great
> deal yet. PLP_ID isn't used by the cxd2820r driver - it's simply
> specified in Andreas' API patch.
In DVB-T2, each TS is contained in a 'Physical Layer Pipe' (PLP).
Multiple PLPs with individual tuning parameters may be combined on a
single transmitter frequency.
I don't know whether multiple PLP mode is or will be used in any
country. If no PLP ID or an invalid PLP ID is specified, the behaviour
of a demod may be undefined, i.e. it may select a random PLP or fail to
tune.
In DVB-SI, the PLP ID is carried within the T2 delivery system descriptor.
Regards,
Andreas
prev parent reply other threads:[~2011-05-08 22:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110506125542.ADA1D162E7@stevekerrison.com>
2011-05-06 13:46 ` [git:v4l-dvb/for_v2.6.40] [media] Sony CXD2820R DVB-T/T2/C demodulator driver Antti Palosaari
2011-05-06 15:30 ` Mauro Carvalho Chehab
2011-05-06 15:46 ` Mauro Carvalho Chehab
2011-05-08 15:51 ` [PATCH 0/6] DVB-T2 API updates, documentation and accompanying small fixes Steve Kerrison
2011-05-08 16:04 ` Mauro Carvalho Chehab
2011-05-08 19:17 ` [PATCH v2 0/5] " Steve Kerrison
2011-05-08 19:17 ` [PATCH v2 1/5] DVB: Add basic API support for DVB-T2 and bump minor version Steve Kerrison
2011-05-08 22:22 ` Andreas Oberritter
2011-05-08 22:38 ` Andreas Oberritter
2011-05-12 21:11 ` [PATCH v3] " Steve Kerrison
2011-05-08 19:17 ` [PATCH v2 2/5] drxd: Fix warning caused by new entries in an enum Steve Kerrison
2011-05-08 22:10 ` Andreas Oberritter
2011-05-09 9:15 ` Steve Kerrison
2011-05-09 9:25 ` Mauro Carvalho Chehab
2011-05-08 19:17 ` [PATCH v2 3/5] mxl5005: " Steve Kerrison
2011-05-08 22:11 ` Andreas Oberritter
2011-05-08 19:17 ` [PATCH v2 4/5] cxd2820r: Update frontend capabilities to advertise QAM-256 Steve Kerrison
2011-05-09 21:45 ` Antti Palosaari
2011-05-08 19:17 ` [PATCH v2 5/5] Documentation: Update to include DVB-T2 additions Steve Kerrison
2011-05-12 21:18 ` Steve Kerrison
[not found] ` <1304875061.2920.13.camel@ares>
2011-05-08 22:26 ` [PATCH 0/6] DVB-T2 API updates, documentation and accompanying small fixes Andreas Oberritter
2011-05-09 3:10 ` Mauro Carvalho Chehab
2011-05-12 22:06 ` Antti Palosaari
2011-05-08 15:51 ` [PATCH 1/6] DVB: Add basic API support for DVB-T2 and bump minor version Steve Kerrison
2011-05-08 15:51 ` [PATCH 2/6] cxd2820r: Remove temporary T2 API hack Steve Kerrison
2011-05-08 16:06 ` Mauro Carvalho Chehab
2011-05-08 15:51 ` [PATCH 3/6] drxd: Fix warning caused by new entries in an enum Steve Kerrison
2011-05-08 15:51 ` [PATCH 4/6] mxl5005: " Steve Kerrison
2011-05-08 15:51 ` [PATCH 5/6] cxd2820r: Update frontend capabilities to advertise QAM-256 Steve Kerrison
2011-05-08 15:51 ` [PATCH 6/6] Documentation: Update to include DVB-T2 additions Steve Kerrison
2011-05-08 16:20 ` Mauro Carvalho Chehab
2011-05-08 19:13 ` Steve Kerrison
2011-05-08 22:05 ` Andreas Oberritter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC71390.404@linuxtv.org \
--to=obi@linuxtv.org \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=steve@stevekerrison.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox