From: Jarod Wilson <jarod@redhat.com>
To: linux-media@vger.kernel.org
Cc: "Juan Jesús García de Soria" <skandalfo@gmail.com>
Subject: Re: [PATCH] [media] ite-cir: finish tx before suspending
Date: Mon, 09 May 2011 16:07:27 -0400 [thread overview]
Message-ID: <4DC8497F.9030002@redhat.com> (raw)
In-Reply-To: <1304971156-26650-1-git-send-email-jarod@redhat.com>
Jarod Wilson wrote:
> Continuing with IR transmit after resuming from suspend seems fairly
> useless, given that the only place we can actually end up suspending is
> after IR has been send and we're simply mdelay'ing. Lets simplify the
> resume path by just waiting on tx to complete in the suspend path, then
> we know we can't be transmitting on resume, and reinitialization of the
> hardware registers becomes more straight-forward.
>
> CC: Juan Jesús García de Soria<skandalfo@gmail.com>
> Signed-off-by: Jarod Wilson<jarod@redhat.com>
> ---
> Nb: this patch relies upon my earlier patch to add the init_hardware
> calls to the resume path in the first place.
Also note: I don't have tx-capable hardware (or at least, there's no
tx hardware wired up), so I haven't actually tested this, but the code
added to ite_suspend is more or less cloned from ite_close.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2011-05-09 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 18:57 [PATCH] [media] ite-cir: make IR receive work after resume Juan Jesús García de Soria Lucena
2011-05-09 19:45 ` Jarod Wilson
2011-05-09 19:59 ` [PATCH] [media] ite-cir: finish tx before suspending Jarod Wilson
2011-05-09 20:07 ` Jarod Wilson [this message]
2011-05-09 20:00 ` [PATCH] [media] ite-cir: make IR receive work after resume Juan Jesús García de Soria Lucena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC8497F.9030002@redhat.com \
--to=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=skandalfo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox