From: Andreas Oberritter <obi@linuxtv.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: linux-media@vger.kernel.org
Subject: Re: dvb-core/dvb_frontend.c: Synchronizing legacy and new tuning API
Date: Wed, 11 May 2011 22:17:22 +0200 [thread overview]
Message-ID: <4DCAEED2.6040906@linuxtv.org> (raw)
In-Reply-To: <87sjslaxwz.fsf@nemi.mork.no>
On 05/11/2011 08:34 PM, Bjørn Mork wrote:
> I see in drivers/media/dvb/dvb-core/dvb_frontend.c that there is some
> synchronization between the old and the new API.
>
> But it is incomplete: The new FE_GET_PROPERTY will report only cached
> values, which is whatever the application has written and not the
> actual tuned values like FE_GET_FRONTEND will. The problem is that
> FE_GET_PROPERTY only will call fe->ops.get_property even for legacy
> drivers. It could have fallen back to calling fe->ops.get_frontend
> followed by a cache synchronization.
>
> Is this difference intentional (because it costs too much, doesn't
> matter, or whatever)? Or should I prepare a patch for dvb_frontend.c?
Please try the patches submitted for testing:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg31194.html
Regards,
Andreas
next prev parent reply other threads:[~2011-05-11 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 18:34 dvb-core/dvb_frontend.c: Synchronizing legacy and new tuning API Bjørn Mork
2011-05-11 20:17 ` Andreas Oberritter [this message]
2011-05-12 7:04 ` Bjørn Mork
2011-05-12 7:12 ` HoP
2011-05-12 11:13 ` Bjørn Mork
2011-05-13 8:10 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCAEED2.6040906@linuxtv.org \
--to=obi@linuxtv.org \
--cc=bjorn@mork.no \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox