From: Ryan Mallon <ryan@bluewatersys.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
mchehab@redhat.com, linux-kernel@vger.kernel.org,
Josh Wu <josh.wu@atmel.com>,
lars.haring@atmel.com, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI) support
Date: Fri, 13 May 2011 09:29:18 +1200 [thread overview]
Message-ID: <4DCC512E.1000603@bluewatersys.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1105121413220.24486@axis700.grange>
On 05/13/2011 12:14 AM, Guennadi Liakhovetski wrote:
> On Thu, 12 May 2011, Jean-Christophe PLAGNIOL-VILLARD wrote:
>
> [snip]
>
>>> + if (0 == *nbuffers)
>> please invert the test
>
> Don't think this is required by CodingStyle or anything like that. If it
> were, you'd have to revamp half of the kernel.
It should at least be consistent within a file, which it is not true in
this case. I think the preferred style is to have the variable on the left.
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2011-05-12 21:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 7:42 [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI) support Josh Wu
2011-05-12 7:47 ` Russell King - ARM Linux
2011-05-12 9:26 ` [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI)support Wu, Josh
2011-05-12 9:32 ` Guennadi Liakhovetski
2011-05-12 9:56 ` Wu, Josh
2011-05-27 12:06 ` Wu, Josh
2011-05-12 9:34 ` [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI) support Russell King - ARM Linux
2011-05-13 4:57 ` [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI)support Wu, Josh
2011-05-12 11:45 ` [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI) support Jean-Christophe PLAGNIOL-VILLARD
2011-05-12 12:14 ` Guennadi Liakhovetski
2011-05-12 21:29 ` Ryan Mallon [this message]
2011-05-17 6:35 ` Wu, Josh
2011-05-12 21:25 ` Ryan Mallon
2011-05-13 1:25 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-17 8:59 ` Wu, Josh
2011-05-17 20:58 ` Ryan Mallon
2011-05-18 4:58 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-13 13:50 ` Guennadi Liakhovetski
2011-05-13 20:35 ` Sylwester Nawrocki
2011-05-13 20:43 ` Guennadi Liakhovetski
2011-05-13 19:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCC512E.1000603@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=g.liakhovetski@gmx.de \
--cc=josh.wu@atmel.com \
--cc=lars.haring@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox