From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Manoel PN <pinusdtv@hotmail.com>
Cc: linux-media@vger.kernel.org, lgspn@hotmail.com
Subject: Re: [PATCH 2/4] Modifications to the driver mb86a20s
Date: Fri, 13 May 2011 08:57:48 +0200 [thread overview]
Message-ID: <4DCCD66C.5000600@infradead.org> (raw)
In-Reply-To: <BLU157-w550E2F1986AB3A248199C0D8880@phx.gbl>
Em 13-05-2011 04:05, Manoel PN escreveu:
>
> This patch implements mb86a20s_read_snr and adds mb86a20s_read_ber and mb86a20s_read_ucblocks both without practical utility but that programs as dvbsnoop need.
Please try to align comments into up to 75 columns. It looks nicer
when people look it into git. Also, please avoid using "This patch",
as it provides no information.
I suggest you to take a look at those kernel guides (there are more
good stuff for developers at the kernel trees, but those are the
minimal stuff that a developer should know when submitting a patch):
http://git.linuxtv.org/media_tree.git?a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=HEAD
http://git.linuxtv.org/media_tree.git?a=blob_plain;f=Documentation/CodingStyle;hb=HEAD
>
>
> Signed-off-by: Manoel Pinheiro <pinusdtv@hotmail.com>
>
>
>
You forgot to attach the patch.
next prev parent reply other threads:[~2011-05-13 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 2:05 [PATCH 2/4] Modifications to the driver mb86a20s Manoel PN
2011-05-13 6:57 ` Mauro Carvalho Chehab [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-13 2:08 Manoel PN
2011-05-13 7:08 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCCD66C.5000600@infradead.org \
--to=mchehab@infradead.org \
--cc=lgspn@hotmail.com \
--cc=linux-media@vger.kernel.org \
--cc=pinusdtv@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox