public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL FOR 2.6.40] v4l2 subdev driver for Samsung S5P MIPI CSI receiver
@ 2011-05-13 16:15 Sylwester Nawrocki
  2011-05-15  7:46 ` Laurent Pinchart
  0 siblings, 1 reply; 3+ messages in thread
From: Sylwester Nawrocki @ 2011-05-13 16:15 UTC (permalink / raw)
  To: linux-media@vger.kernel.org; +Cc: Mauro Carvalho Chehab

Hi Mauro,

The following changes since commit f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:

  [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)

are available in the git repository at:
  git://git.infradead.org/users/kmpark/linux-2.6-samsung s5p-csis

Sylwester Nawrocki (3):
      v4l: Add V4L2_MBUS_FMT_JPEG_1X8 media bus format
      v4l: Move s5p-fimc driver into Video capture devices
      v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers

It's a new driver for MIPI CSI receiver available in S5PVxxx/EXYNOS4 SoCs.
The first patch adds definition of a media bus code for JPEG format.
 
I've done three further driver amendments comparing to the last (v5) version 
posted on the mailing lists, i.e.:
 - slightly improved description of struct csis_state
 - moved the pad number check from __s5pcsis_get_format directly to set_fmt/get_fmt
   pad level operation handlers
 - replaced __init attribute of s5pcsis_probe() with __devinit and added
   __devexit for s5pcsis_remove()

Gitweb: http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/heads/s5p-csis

 Documentation/DocBook/v4l/subdev-formats.xml |   46 ++
 drivers/media/video/Kconfig                  |   28 +-
 drivers/media/video/s5p-fimc/Makefile        |    6 +-
 drivers/media/video/s5p-fimc/mipi-csis.c     |  725 ++++++++++++++++++++++++++
 drivers/media/video/s5p-fimc/mipi-csis.h     |   22 +
 include/linux/v4l2-mediabus.h                |    3 +
 6 files changed, 820 insertions(+), 10 deletions(-)
 create mode 100644 drivers/media/video/s5p-fimc/mipi-csis.c
 create mode 100644 drivers/media/video/s5p-fimc/mipi-csis.h

--
Regards, 
Sylwester Nawrocki
Samsung Poland R&D Center

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT PULL FOR 2.6.40] v4l2 subdev driver for Samsung S5P MIPI CSI receiver
  2011-05-13 16:15 [GIT PULL FOR 2.6.40] v4l2 subdev driver for Samsung S5P MIPI CSI receiver Sylwester Nawrocki
@ 2011-05-15  7:46 ` Laurent Pinchart
  2011-05-15  9:43   ` Sylwester Nawrocki
  0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2011-05-15  7:46 UTC (permalink / raw)
  To: Sylwester Nawrocki; +Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab

Hi Sylwester,

On Friday 13 May 2011 18:15:42 Sylwester Nawrocki wrote:
> Hi Mauro,
> 
> The following changes since commit
> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:
> 
>   [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09
> 05:47:20 +0200)
> 
> are available in the git repository at:
>   git://git.infradead.org/users/kmpark/linux-2.6-samsung s5p-csis
> 
> Sylwester Nawrocki (3):
>       v4l: Add V4L2_MBUS_FMT_JPEG_1X8 media bus format
>       v4l: Move s5p-fimc driver into Video capture devices
>       v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers
> 
> It's a new driver for MIPI CSI receiver available in S5PVxxx/EXYNOS4 SoCs.
> The first patch adds definition of a media bus code for JPEG format.
> 
> I've done three further driver amendments comparing to the last (v5)
> version posted on the mailing lists, i.e.:
>  - slightly improved description of struct csis_state
>  - moved the pad number check from __s5pcsis_get_format directly to
> set_fmt/get_fmt pad level operation handlers
>  - replaced __init attribute of s5pcsis_probe() with __devinit and added
>    __devexit for s5pcsis_remove()

I've reviewed the patches yesterday, I think there's still a couple of small 
issues you might want to address.

> 
> Gitweb:
> http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/head
> s/s5p-csis
> 
>  Documentation/DocBook/v4l/subdev-formats.xml |   46 ++
>  drivers/media/video/Kconfig                  |   28 +-
>  drivers/media/video/s5p-fimc/Makefile        |    6 +-
>  drivers/media/video/s5p-fimc/mipi-csis.c     |  725
> ++++++++++++++++++++++++++ drivers/media/video/s5p-fimc/mipi-csis.h     | 
>  22 +
>  include/linux/v4l2-mediabus.h                |    3 +
>  6 files changed, 820 insertions(+), 10 deletions(-)
>  create mode 100644 drivers/media/video/s5p-fimc/mipi-csis.c
>  create mode 100644 drivers/media/video/s5p-fimc/mipi-csis.h

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT PULL FOR 2.6.40] v4l2 subdev driver for Samsung S5P MIPI CSI receiver
  2011-05-15  7:46 ` Laurent Pinchart
@ 2011-05-15  9:43   ` Sylwester Nawrocki
  0 siblings, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2011-05-15  9:43 UTC (permalink / raw)
  To: linux-media@vger.kernel.org
  Cc: Laurent Pinchart, Sylwester Nawrocki, Mauro Carvalho Chehab

Hi Laurent,

On 05/15/2011 09:46 AM, Laurent Pinchart wrote:
> On Friday 13 May 2011 18:15:42 Sylwester Nawrocki wrote:
>> Hi Mauro,
>>
>> The following changes since commit
>> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:
>>
>>    [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09
>> 05:47:20 +0200)
>>
>> are available in the git repository at:
>>    git://git.infradead.org/users/kmpark/linux-2.6-samsung s5p-csis
>>
>> Sylwester Nawrocki (3):
>>        v4l: Add V4L2_MBUS_FMT_JPEG_1X8 media bus format
>>        v4l: Move s5p-fimc driver into Video capture devices
>>        v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers
>>
>> It's a new driver for MIPI CSI receiver available in S5PVxxx/EXYNOS4 SoCs.
>> The first patch adds definition of a media bus code for JPEG format.
>>
>> I've done three further driver amendments comparing to the last (v5)
>> version posted on the mailing lists, i.e.:
>>   - slightly improved description of struct csis_state
>>   - moved the pad number check from __s5pcsis_get_format directly to
>> set_fmt/get_fmt pad level operation handlers
>>   - replaced __init attribute of s5pcsis_probe() with __devinit and added
>>     __devexit for s5pcsis_remove()
> 
> I've reviewed the patches yesterday, I think there's still a couple of small
> issues you might want to address.

Yeah, I've noticed that ;-) Thanks for getting back to this.

Mauro, please ignore this pull request, my apologies for he noise.

--
Regards,
Sylwester Nawrocki


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-05-15  9:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-13 16:15 [GIT PULL FOR 2.6.40] v4l2 subdev driver for Samsung S5P MIPI CSI receiver Sylwester Nawrocki
2011-05-15  7:46 ` Laurent Pinchart
2011-05-15  9:43   ` Sylwester Nawrocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox