From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:62402 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989Ab1EOJnd (ORCPT ); Sun, 15 May 2011 05:43:33 -0400 Received: by ewy4 with SMTP id 4so1024148ewy.19 for ; Sun, 15 May 2011 02:43:32 -0700 (PDT) Message-ID: <4DCFA040.20209@gmail.com> Date: Sun, 15 May 2011 11:43:28 +0200 From: Sylwester Nawrocki MIME-Version: 1.0 To: "linux-media@vger.kernel.org" CC: Laurent Pinchart , Sylwester Nawrocki , Mauro Carvalho Chehab Subject: Re: [GIT PULL FOR 2.6.40] v4l2 subdev driver for Samsung S5P MIPI CSI receiver References: <4DCD592E.8060302@samsung.com> <201105150946.05466.laurent.pinchart@ideasonboard.com> In-Reply-To: <201105150946.05466.laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-ID: Sender: Hi Laurent, On 05/15/2011 09:46 AM, Laurent Pinchart wrote: > On Friday 13 May 2011 18:15:42 Sylwester Nawrocki wrote: >> Hi Mauro, >> >> The following changes since commit >> f9b51477fe540fb4c65a05027fdd6f2ecce4db3b: >> >> [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 >> 05:47:20 +0200) >> >> are available in the git repository at: >> git://git.infradead.org/users/kmpark/linux-2.6-samsung s5p-csis >> >> Sylwester Nawrocki (3): >> v4l: Add V4L2_MBUS_FMT_JPEG_1X8 media bus format >> v4l: Move s5p-fimc driver into Video capture devices >> v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers >> >> It's a new driver for MIPI CSI receiver available in S5PVxxx/EXYNOS4 SoCs. >> The first patch adds definition of a media bus code for JPEG format. >> >> I've done three further driver amendments comparing to the last (v5) >> version posted on the mailing lists, i.e.: >> - slightly improved description of struct csis_state >> - moved the pad number check from __s5pcsis_get_format directly to >> set_fmt/get_fmt pad level operation handlers >> - replaced __init attribute of s5pcsis_probe() with __devinit and added >> __devexit for s5pcsis_remove() > > I've reviewed the patches yesterday, I think there's still a couple of small > issues you might want to address. Yeah, I've noticed that ;-) Thanks for getting back to this. Mauro, please ignore this pull request, my apologies for he noise. -- Regards, Sylwester Nawrocki