* [PATCH 1/1] v4l: Document EACCES in VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS
@ 2011-05-13 13:24 Sakari Ailus
2011-05-15 7:50 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2011-05-13 13:24 UTC (permalink / raw)
To: linux-media; +Cc: hverkuil
VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS return EACCES when setting a read-only
control or getting a write-only control. Document this.
Signed-off-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
---
Documentation/DocBook/v4l/vidioc-g-ctrl.xml | 7 +++++++
Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml | 7 +++++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/Documentation/DocBook/v4l/vidioc-g-ctrl.xml b/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
index 8b5e6ff..5146d00 100644
--- a/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
+++ b/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
@@ -117,6 +117,13 @@ because another applications took over control of the device function
this control belongs to.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><errorcode>EACCES</errorcode></term>
+ <listitem>
+ <para>Attempt to set a read-only control or to get a
+ write-only control.</para>
+ </listitem>
+ </varlistentry>
</variablelist>
</refsect1>
</refentry>
diff --git a/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml b/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
index 3aa7f8f..5e73517 100644
--- a/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
+++ b/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
@@ -294,6 +294,13 @@ The field <structfield>size</structfield> is set to a value that is enough
to store the payload and this error code is returned.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><errorcode>EACCES</errorcode></term>
+ <listitem>
+ <para>Attempt to try or set a read-only control or to get a
+ write-only control.</para>
+ </listitem>
+ </varlistentry>
</variablelist>
</refsect1>
</refentry>
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] v4l: Document EACCES in VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS
2011-05-13 13:24 [PATCH 1/1] v4l: Document EACCES in VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS Sakari Ailus
@ 2011-05-15 7:50 ` Laurent Pinchart
2011-05-15 15:22 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2011-05-15 7:50 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media, hverkuil
Hi Sakari,
On Friday 13 May 2011 15:24:13 Sakari Ailus wrote:
> VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS return EACCES when setting a read-only
> control or getting a write-only control. Document this.
You might want to modify the commit message to include VIDIOC_S_CTRL and
VIDIOC_S_EXT_CTRLS. Setting a control with the VIDIOC_G_(EXT_)CTRL(S) ioctls
is a bit difficult :-)
> Signed-off-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
> ---
> Documentation/DocBook/v4l/vidioc-g-ctrl.xml | 7 +++++++
> Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml | 7 +++++++
> 2 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
> b/Documentation/DocBook/v4l/vidioc-g-ctrl.xml index 8b5e6ff..5146d00
> 100644
> --- a/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
> +++ b/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
> @@ -117,6 +117,13 @@ because another applications took over control of the
> device function this control belongs to.</para>
> </listitem>
> </varlistentry>
> + <varlistentry>
> + <term><errorcode>EACCES</errorcode></term>
> + <listitem>
> + <para>Attempt to set a read-only control or to get a
> + write-only control.</para>
Should you s/set/try or set/ ?
> + </listitem>
> + </varlistentry>
> </variablelist>
> </refsect1>
> </refentry>
> diff --git a/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
> b/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml index 3aa7f8f..5e73517
> 100644
> --- a/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
> +++ b/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
> @@ -294,6 +294,13 @@ The field <structfield>size</structfield> is set to a
> value that is enough to store the payload and this error code is
> returned.</para>
> </listitem>
> </varlistentry>
> + <varlistentry>
> + <term><errorcode>EACCES</errorcode></term>
> + <listitem>
> + <para>Attempt to try or set a read-only control or to get a
> + write-only control.</para>
> + </listitem>
> + </varlistentry>
> </variablelist>
> </refsect1>
> </refentry>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] v4l: Document EACCES in VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS
2011-05-15 7:50 ` Laurent Pinchart
@ 2011-05-15 15:22 ` Sakari Ailus
0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2011-05-15 15:22 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, hverkuil
Laurent Pinchart wrote:
> Hi Sakari,
Hi, Laurent!
Thanks for the comments!
> On Friday 13 May 2011 15:24:13 Sakari Ailus wrote:
>> VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS return EACCES when setting a read-only
>> control or getting a write-only control. Document this.
>
> You might want to modify the commit message to include VIDIOC_S_CTRL and
> VIDIOC_S_EXT_CTRLS. Setting a control with the VIDIOC_G_(EXT_)CTRL(S) ioctls
> is a bit difficult :-)
I'll do that. I was thinking of the documentation when reading this, not
the actual ioctls. ;-)
>> Signed-off-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
>> ---
>> Documentation/DocBook/v4l/vidioc-g-ctrl.xml | 7 +++++++
>> Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml | 7 +++++++
>> 2 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
>> b/Documentation/DocBook/v4l/vidioc-g-ctrl.xml index 8b5e6ff..5146d00
>> 100644
>> --- a/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
>> +++ b/Documentation/DocBook/v4l/vidioc-g-ctrl.xml
>> @@ -117,6 +117,13 @@ because another applications took over control of the
>> device function this control belongs to.</para>
>> </listitem>
>> </varlistentry>
>> + <varlistentry>
>> + <term><errorcode>EACCES</errorcode></term>
>> + <listitem>
>> + <para>Attempt to set a read-only control or to get a
>> + write-only control.</para>
>
> Should you s/set/try or set/ ?
No, since you can only try controls using the TRY_EXT_CTRLS. There is no
VIDIOC_TRY_CTRL.
>> + </listitem>
>> + </varlistentry>
>> </variablelist>
>> </refsect1>
>> </refentry>
>> diff --git a/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
>> b/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml index 3aa7f8f..5e73517
>> 100644
>> --- a/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
>> +++ b/Documentation/DocBook/v4l/vidioc-g-ext-ctrls.xml
>> @@ -294,6 +294,13 @@ The field <structfield>size</structfield> is set to a
>> value that is enough to store the payload and this error code is
>> returned.</para>
>> </listitem>
>> </varlistentry>
>> + <varlistentry>
>> + <term><errorcode>EACCES</errorcode></term>
>> + <listitem>
>> + <para>Attempt to try or set a read-only control or to get a
>> + write-only control.</para>
>> + </listitem>
>> + </varlistentry>
>> </variablelist>
>> </refsect1>
>> </refentry>
>
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-15 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-13 13:24 [PATCH 1/1] v4l: Document EACCES in VIDIOC_G_CTRL and VIDIOC_G_EXT_CTRLS Sakari Ailus
2011-05-15 7:50 ` Laurent Pinchart
2011-05-15 15:22 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox