Re: [RFC v4] V4L2 API for flash devices

[Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>]

Andy Walls wrote:
> On Sat, 2011-05-07 at 14:46 +0200, Hans Verkuil wrote:
>> On Thursday, May 05, 2011 20:49:21 Sakari Ailus wrote:
>>>
>>>
>>> enum v4l2_flash_strobe_whence {
>>> 	V4L2_FLASH_STROBE_WHENCE_SOFTWARE,
>>> 	V4L2_FLASH_STROBE_WHENCE_EXTERNAL,
>>> };
>>
>> Perhaps use 'type' instead of 'whence'? English isn't my native language,
>> but it sounds pretty archaic to me.
> 
> "SOURCE" is better than "WHENCE" here.
> 
> 
> "whence" is certainly very formal and used very little.  "whence" likely
> still gets some use in English, simply because a terse synonym doesn't
> exist.
> 
> The problem with using whence is that many English speakers won't know
> its correct definition.
> 
> 	"whence" means "from what source, origin, or place"
> 
> In your use here, the implicit "from" in the definition of whence is
> essential.  However, most (American) English speakers that I know think
> "whence" simply means "where".

Thanks for the feedback, Andy!

WHENCE has since changed to MODE (or at least should have been), but I
think SOURCE is even better. I'll switch to that.

Regards,

-- 
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com