Re: [PATCH v17 5/6] davinci vpbe: Build infrastructure for VPBE driver

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

Manjunath Hadli wrote:

> This patch adds the build infra-structure for Davinci
> VPBE dislay driver.

> Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> Acked-by: Muralidharan Karicheri <m-karicheri2@ti.com>
> Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
[...]

> diff --git a/drivers/media/video/davinci/Kconfig b/drivers/media/video/davinci/Kconfig
> index 6b19540..a7f11e7 100644
> --- a/drivers/media/video/davinci/Kconfig
> +++ b/drivers/media/video/davinci/Kconfig
> @@ -91,3 +91,25 @@ config VIDEO_ISIF
>  
>  	   To compile this driver as a module, choose M here: the
>  	   module will be called vpfe.
> +
> +config VIDEO_DM644X_VPBE
> +	tristate "DM644X VPBE HW module"

    BTW, as this seems DM644x specific, shouldn't this depend on 
CONFIG_ARCH_DAVINCI_DM644x?

> +	select VIDEO_VPSS_SYSTEM
> +	select VIDEOBUF_DMA_CONTIG
> +	help
> +	    Enables VPBE modules used for display on a DM644x
> +	    SoC.
> +
> +	    To compile this driver as a module, choose M here: the
> +	    module will be called vpbe.
> +
> +
> +config VIDEO_VPBE_DISPLAY
> +	tristate "VPBE V4L2 Display driver"
> +	select VIDEO_DM644X_VPBE

    Or this one, if it selects VIDEO_DM644X_VPBE?

> +	default y

    Hm, "y" shouldn't be the default.

WBR, Sergei