From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: Andy Walls <awalls@md.metrocast.net>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, Steven Toth <stoth@kernellabs.com>
Subject: Re: [PATCH] cx18: Move spinlock and vb_type initialisation into stream_init
Date: Fri, 20 May 2011 20:21:15 -0300 [thread overview]
Message-ID: <4DD6F76B.5010906@infradead.org> (raw)
In-Reply-To: <1305035390-31439-1-git-send-email-simon.farnsworth@onelan.co.uk>
Em 10-05-2011 10:49, Simon Farnsworth escreveu:
> The initialisation of vb_type in serialized_open was preventing
> REQBUFS from working reliably. Remove it, and move the spinlock into
> stream_init for good measure - it's only used when we have a stream
> that supports videobuf anyway.
>
> Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
> ---
> Mauro,
>
> This fixes a bug I introduced, and noticed while trying to work out
> how videobuf works and interacts with the rest of the driver, in
> preparation for working out how to port this code to videobuf2.
>
> Briefly, if you open a device node at the wrong time, you lose
> videobuf support forever.
>
> Please consider this for 2.6.40,
/me is assuming that Andy is ok with it.
Ok, I'm adding this to my series, as it is part of the code you added.
Thanks,
Mauro.
next prev parent reply other threads:[~2011-05-20 23:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1QGwlS-0006ys-15@www.linuxtv.org>
2011-05-02 19:11 ` [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture Hans Verkuil
2011-05-02 19:21 ` Devin Heitmueller
2011-05-02 19:35 ` Mauro Carvalho Chehab
2011-05-02 19:40 ` Devin Heitmueller
2011-05-02 20:02 ` Hans Verkuil
2011-05-02 20:59 ` Devin Heitmueller
2011-05-02 21:31 ` Hans Verkuil
2011-05-03 1:59 ` Mauro Carvalho Chehab
2011-05-03 2:40 ` Andy Walls
2011-05-03 3:28 ` Mauro Carvalho Chehab
2011-05-03 5:15 ` Hans Verkuil
2011-05-03 11:29 ` Mauro Carvalho Chehab
2011-05-03 13:07 ` Devin Heitmueller
2011-05-03 12:49 ` Devin Heitmueller
2011-05-03 13:59 ` Hans Verkuil
2011-05-03 14:26 ` Simon Farnsworth
2011-05-03 15:03 ` Mauro Carvalho Chehab
2011-05-03 16:13 ` Hans Verkuil
2011-05-03 9:03 ` Simon Farnsworth
2011-05-03 10:56 ` Mauro Carvalho Chehab
2011-05-03 11:57 ` [PATCH] cx18: Clean up mmap() support for raw YUV Simon Farnsworth
2011-05-03 16:24 ` Hans Verkuil
2011-05-03 22:51 ` Andy Walls
2011-05-03 23:01 ` Mauro Carvalho Chehab
2011-05-03 23:38 ` Andy Walls
2011-05-04 0:17 ` Mauro Carvalho Chehab
2011-05-04 9:32 ` Simon Farnsworth
2011-05-04 11:31 ` Mauro Carvalho Chehab
2011-05-04 11:39 ` [PATCH] cx18: Bump driver version to 1.5.0 Simon Farnsworth
2011-05-04 12:20 ` Andy Walls
2011-05-05 12:42 ` [PATCH] cx18: Fix warnings introduced during cleanup Simon Farnsworth
2011-05-05 13:41 ` Mauro Carvalho Chehab
2011-05-05 13:44 ` Simon Farnsworth
2011-05-10 13:49 ` [PATCH] cx18: Move spinlock and vb_type initialisation into stream_init Simon Farnsworth
2011-05-20 23:21 ` Mauro Carvalho Chehab [this message]
2011-05-05 11:41 ` [PATCH] cx18: Clean up mmap() support for raw YUV Mauro Carvalho Chehab
2011-05-05 12:44 ` Simon Farnsworth
2011-05-05 13:39 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD6F76B.5010906@infradead.org \
--to=mchehab@infradead.org \
--cc=awalls@md.metrocast.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=simon.farnsworth@onelan.co.uk \
--cc=stoth@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox