* [RFC] Make dvb_net.c optional
@ 2011-05-19 8:35 Hans Petter Selasky
2011-05-21 10:58 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Hans Petter Selasky @ 2011-05-19 8:35 UTC (permalink / raw)
To: linux-media@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
Hi,
In my setup I am building the DVB code without dvb_net.c, because there is no
IP-stack currently in my "Linux kernel". Is this worth a separate
configuration entry?
--HPS
[-- Attachment #2: dvb_net.diff --]
[-- Type: text/x-patch, Size: 957 bytes --]
From e7fe34933638e882e1ed1eab1761ecd14ef9125e Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Thu, 19 May 2011 02:26:33 +0200
Subject: [PATCH] Make dvb_net configurable.
---
../media_tree/drivers/media/dvb/dvb-core/Makefile | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/../media_tree/drivers/media/dvb/dvb-core/Makefile b/../media_tree/drivers/media/dvb/dvb-core/Makefile
index 0b51828..8f22bcd 100644
--- a/../media_tree/drivers/media/dvb/dvb-core/Makefile
+++ b/../media_tree/drivers/media/dvb/dvb-core/Makefile
@@ -2,8 +2,10 @@
# Makefile for the kernel DVB device drivers.
#
+dvb-net-$(CONFIG_DVB_NET) := dvb_net.o
+
dvb-core-objs := dvbdev.o dmxdev.o dvb_demux.o dvb_filter.o \
dvb_ca_en50221.o dvb_frontend.o \
- dvb_net.o dvb_ringbuffer.o dvb_math.o
+ $(dvb-net-y) dvb_ringbuffer.o dvb_math.o
obj-$(CONFIG_DVB_CORE) += dvb-core.o
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC] Make dvb_net.c optional
2011-05-19 8:35 [RFC] Make dvb_net.c optional Hans Petter Selasky
@ 2011-05-21 10:58 ` Mauro Carvalho Chehab
2011-05-22 9:17 ` Hans Petter Selasky
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2011-05-21 10:58 UTC (permalink / raw)
To: Hans Petter Selasky; +Cc: linux-media@vger.kernel.org
Em 19-05-2011 05:35, Hans Petter Selasky escreveu:
> Hi,
>
> In my setup I am building the DVB code without dvb_net.c, because there is no
> IP-stack currently in my "Linux kernel". Is this worth a separate
> configuration entry?
I have no problems with that, but your patch is wrong ;) It is not adding the new
symbol at the Kconfig. IMHO, if we add such patch, the defaut for config DVB_NET
should be y, and such symbol needs to depend on having the network enabled.
Cheers,
Mauro
>
> --HPS
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] Make dvb_net.c optional
2011-05-21 10:58 ` Mauro Carvalho Chehab
@ 2011-05-22 9:17 ` Hans Petter Selasky
0 siblings, 0 replies; 3+ messages in thread
From: Hans Petter Selasky @ 2011-05-22 9:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media@vger.kernel.org
On Saturday 21 May 2011 12:58:33 Mauro Carvalho Chehab wrote:
> Em 19-05-2011 05:35, Hans Petter Selasky escreveu:
> > Hi,
> >
> > In my setup I am building the DVB code without dvb_net.c, because there
> > is no IP-stack currently in my "Linux kernel". Is this worth a separate
> > configuration entry?
>
> I have no problems with that, but your patch is wrong ;) It is not adding
> the new symbol at the Kconfig. IMHO, if we add such patch, the defaut for
> config DVB_NET should be y, and such symbol needs to depend on having the
> network enabled.
Yes, I know my patch is not complete. Then I will go ahead and make a complete
patch and post it. Thank you!
--HPS
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-22 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-19 8:35 [RFC] Make dvb_net.c optional Hans Petter Selasky
2011-05-21 10:58 ` Mauro Carvalho Chehab
2011-05-22 9:17 ` Hans Petter Selasky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox