[PATCHES] Various MODULE parameter releated fixes

[PATCHES] Various MODULE parameter releated fixes

[Hans Petter Selasky]

[-- Attachment #1: Type: text/plain, Size: 6 bytes --]

--HPS

[-- Attachment #2: tda7432.diff --]
[-- Type: text/x-patch, Size: 1019 bytes --]

From 0e135fa9cd9cb377bd8930253a547d6d9ae6d01b Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Thu, 19 May 2011 02:46:40 +0200
Subject: [PATCH] Parameter description should be after parameter.

---
 ../media_tree/drivers/media/video/tda7432.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/../media_tree/drivers/media/video/tda7432.c b/../media_tree/drivers/media/video/tda7432.c
index 3941f95..398b9fb 100644
--- a/../media_tree/drivers/media/video/tda7432.c
+++ b/../media_tree/drivers/media/video/tda7432.c
@@ -50,8 +50,8 @@ static int loudness; /* disable loudness by default */
 static int debug;	 /* insmod parameter */
 module_param(debug, int, S_IRUGO | S_IWUSR);
 module_param(loudness, int, S_IRUGO);
-MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
 module_param(maxvol, int, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
 
 
 
-- 
1.7.1.1


[-- Attachment #3: tda8261.diff --]
[-- Type: text/x-patch, Size: 825 bytes --]

From 7191938e7da088ccb5e8bad36e99ca495e53d206 Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Thu, 19 May 2011 02:56:48 +0200
Subject: [PATCH] Remove invalid parameter description.

---
 ../media_tree/drivers/media/dvb/frontends/tda8261.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/../media_tree/drivers/media/dvb/frontends/tda8261.c b/../media_tree/drivers/media/dvb/frontends/tda8261.c
index 1742056..53c7d8f 100644
--- a/../media_tree/drivers/media/dvb/frontends/tda8261.c
+++ b/../media_tree/drivers/media/dvb/frontends/tda8261.c
@@ -224,7 +224,6 @@ exit:
 }
 
 EXPORT_SYMBOL(tda8261_attach);
-MODULE_PARM_DESC(verbose, "Set verbosity level");
 
 MODULE_AUTHOR("Manu Abraham");
 MODULE_DESCRIPTION("TDA8261 8PSK/QPSK Tuner");
-- 
1.7.1.1


[-- Attachment #4: cx24116.c.diff --]
[-- Type: text/x-patch, Size: 393 bytes --]

--- cx24116.c.orig	2011-03-20 23:11:40.000000000 +0100
+++ cx24116.c	2011-03-20 23:12:35.000000000 +0100
@@ -137,7 +137,7 @@
 /* SNR measurements */
 static int esno_snr;
 module_param(esno_snr, int, 0644);
-MODULE_PARM_DESC(debug, "SNR return units, 0=PERCENTAGE 0-100, "\
+MODULE_PARM_DESC(esno_snr, "SNR return units, 0=PERCENTAGE 0-100, "\
 	"1=ESNO(db * 10) (default:0)");
 
 enum cmds {

Re: [PATCHES] Various MODULE parameter releated fixes

[Mauro Carvalho Chehab]

Em 19-05-2011 05:38, Hans Petter Selasky escreveu:
> --HPS

The patches look sane, but, please send one patch per email. Otherwise,
only the first patch will be caught by patchwork:
	https://patchwork.kernel.org/patch/796522/

Also, please sign your patches (with Signed-off-by:) and send them in-lined,
otherwise replies (like this one) become very bad, as the patch is not replied
on most email clients used by developers.

Thanks,
Mauro.

Re: [PATCHES] Various MODULE parameter releated fixes

[Hans Petter Selasky]

On Saturday 21 May 2011 13:01:57 Mauro Carvalho Chehab wrote:
> Em 19-05-2011 05:38, Hans Petter Selasky escreveu:
> > --HPS
> 
> The patches look sane, but, please send one patch per email. Otherwise,
> only the first patch will be caught by patchwork:
> 	https://patchwork.kernel.org/patch/796522/
> 
> Also, please sign your patches (with Signed-off-by:) and send them
> in-lined, otherwise replies (like this one) become very bad, as the patch
> is not replied on most email clients used by developers.

Ok. Got it. Will do.

--HPS